[Gutenberg] - React Native 0.69.4 Upgrade #19326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Status] In Progress
Gutenberg
You can test the changes in Jetpack from this Pull Request by:
|
You can test the changes in WordPress from this Pull Request by:
|
2 tasks
This was referenced Oct 5, 2022
derekblank
force-pushed
the
gutenberg/react-native-0.69
branch
from
f03a8c7
to
40a17c8
Compare
derekblank
force-pushed
the
gutenberg/react-native-0.69
branch
from
a8eaa50
to
825d981
Compare
# Conflicts: # Podfile # Podfile.lock
Generated by 🚫 dangerJS |
added 2 commits
October 21, 2022 15:32
|
The CI issues are now solved and all checks are green ✅ |
# Conflicts: # Podfile # Podfile.lock
…-button Update logic for GutenbergViewController to fix media upload statuses
# Conflicts: # Podfile # Podfile.lock
fluiddot
suggested changes
Dec 5, 2022
There was a problem hiding this comment.
@derekblank I reviewed the PR and noticed a couple of issues in the latest code changes that are most likely causing the CI check failures. It would be great to solve them in order to know if all checks are 🟢 .
|
CI checks are now passing 🟢 |
fluiddot
approved these changes
Dec 7, 2022
| @@ -17532,6 +17532,7 @@ | |||
| E16AB92514D978240047A2E5 /* Sources */, | |||
| E16AB92614D978240047A2E5 /* Frameworks */, | |||
| E16AB92714D978240047A2E5 /* Resources */, | |||
| 42C1BDE416A90FA718A28797 /* [CP] Copy Pods Resources */, | |||
There was a problem hiding this comment.
It's interesting that we didn't have this phase before in the WordPressTest scheme 🤔. I understand that it won't have any impact but let's keep an eye just in case this produces an undesired effect when running the UI tests.
There was a problem hiding this comment.
I'll keep an eye for that 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds changes to support the React Native
0.69.4upgrade.Includes #19573 to fix some issues found while testing media uploads in the editor.
It also updates how the Gutenberg pods are installed by introducing
gutenberg_podsso we can reuse the same reference forshared_test_pods.Related PRs
Feature branch
Android integration
iOS integration
To test:
CI checks should pass, as well as checking the editor opens correctly with the builds from this PR.
Regression Notes
Potential unintended areas of impact
Editor
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing, CI tests.
What automated tests I added (or what prevented me from doing so)
None as there is no added functionality
PR submission checklist:
RELEASE-NOTES.txtif necessary.