Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Split TrackStateProxy into own header, public #2807

Merged
merged 4 commits into from
Dec 14, 2023
Merged

refactor!: Split TrackStateProxy into own header, public #2807

merged 4 commits into from
Dec 14, 2023

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Dec 11, 2023 •
edited
Loading

This moves TrackStateProxy into its own header file, and moves it out
of the detail_lt namespace.

Blocked by:

BREAKING CHANGE: Acts::detail_lt::TrackStateProxy moves to Acts::TrackStateProxy and include Acts/EventData/TrackStateProxy.hpp

@paulgessinger paulgessinger added the 🛑 blocked This item is blocked by another item label Dec 11, 2023
@paulgessinger paulgessinger added this to the v32.0.0 milestone Dec 11, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Component - Plugins Affects one or more Plugins Event Data Model labels Dec 11, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2023 •
edited
Loading

Codecov Report

Attention: 94 lines in your changes are missing coverage. Please review.

Comparison is base (1a2deaf) 48.62% compared to head (259bff4) 48.62%.

❗ Current head 259bff4 differs from pull request most recent head 01fead7. Consider uploading reports for the commit 01fead7 to get more accurate results

Files Patch % Lines
Core/include/Acts/EventData/TrackStateProxy.hpp 68.14% 4 Missing and 82 partials ⚠️
Core/include/Acts/EventData/TrackStateProxy.ipp 61.90% 0 Missing and 8 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2807   +/-   ##
=======================================
  Coverage   48.62%   48.62%           
=======================================
  Files         480      482    +2     
  Lines       28033    28032    -1     
  Branches    13263    13262    -1     
=======================================
+ Hits        13630    13631    +1     
+ Misses       4803     4801    -2     
  Partials     9600     9600

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulgessinger paulgessinger marked this pull request as ready for review December 12, 2023 14:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2023 •
edited
Loading

📊: Physics performance monitoring for 01fead7

Full contents

physmon summary

@paulgessinger paulgessinger mentioned this pull request Dec 13, 2023
Merged
paulgessinger and others added 3 commits December 13, 2023 22:48
@paulgessinger
refactor!: Split TrackStateProxy into own header, public
00c64b0 
This moves TrackStateProxy into it's own header file, and moves it out
of the `detail_lt` namespace.
@paulgessinger
fix aliasing error
388e77b
@paulgessinger
format fix
259bff4
@paulgessinger paulgessinger force-pushed the refactor/track-state-proxy-public branch from 1cda4aa to 259bff4 Compare December 13, 2023 21:49
@github-actions github-actions bot removed the Component - Plugins Affects one or more Plugins label Dec 13, 2023
@paulgessinger paulgessinger removed the 🛑 blocked This item is blocked by another item label Dec 13, 2023
andiwand
andiwand approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean cut - I like it!

EdwardMoyse
EdwardMoyse approved these changes Dec 14, 2023
View reviewed changes
Copy link

@EdwardMoyse EdwardMoyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Definitely in favour of this!

@kodiakhq kodiakhq bot merged commit 01f0877 into acts-project:main Dec 14, 2023
51 checks passed
@acts-project-service
Copy link
Collaborator

acts-project-service commented Dec 14, 2023 •
edited
Loading

✅ Athena integration test results [01f0877]

✅ All tests successful

status job report
🟢 run_unit_tests
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsBenchmarkWithSpot.sh 8 100
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateAmbiguityResolution.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateResolvedTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsGSFRefitting.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Dec 14, 2023
kodiakhq bot pushed a commit that referenced this pull request Dec 18, 2023
@paulgessinger
docs: Track EDM doxygen comment updates (#2816)
ba0ab93 
This is pulled out of #2797 and includes only the doxygen comment changes.

Blocked by:
- #2712
- #2817 
- #2807
@paulgessinger paulgessinger removed the Breaks Athena build This PR breaks the Athena build label Jan 23, 2024
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
@paulgessinger @LaraCalic
refactor!: Split TrackStateProxy into own header, public (acts-projec…
263f810 
…t#2807)

This moves TrackStateProxy into its own header file, and moves it out
of the `detail_lt` namespace.

Blocked by: 
- acts-project#2712

BREAKING CHANGE: `Acts::detail_lt::TrackStateProxy` moves to `Acts::TrackStateProxy` and include `Acts/EventData/TrackStateProxy.hpp`
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
@paulgessinger @LaraCalic
docs: Track EDM doxygen comment updates (acts-project#2816)
af985da 
This is pulled out of acts-project#2797 and includes only the doxygen comment changes.

Blocked by:
- acts-project#2712
- acts-project#2817 
- acts-project#2807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdwardMoyse EdwardMoyse EdwardMoyse approved these changes

@andiwand andiwand andiwand approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module Event Data Model
Projects
None yet
Milestone
v32.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@paulgessinger @acts-project-service @andiwand @EdwardMoyse