docs: Document Track EDM #2797

paulgessinger · 2023-12-11T09:47:45Z

Blocked by:

paulgessinger · 2023-12-11T09:47:51Z

@andiwand

codecov · 2023-12-11T10:14:52Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19464fa) 48.84% compared to head (92bce34) 48.84%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2797   +/-   ##
=======================================
  Coverage   48.84%   48.84%           
=======================================
  Files         495      495           
  Lines       28909    28909           
  Branches    13732    13732           
=======================================
  Hits        14122    14122           
  Misses       4890     4890           
  Partials     9897     9897

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2023-12-11T10:59:45Z

📊: Physics performance monitoring for `92bce34`

Full contents

physmon summary

This is pulled out of #2797 and includes only the doxygen comment changes. Blocked by: - #2712 - #2817 - #2807

commit 9cc6174 Merge: acf3c1b ba0ab93 Author: Paul Gessinger <hello@paulgessinger.com> Date: Mon Dec 18 19:10:14 2023 +0100 Merge remote-tracking branch 'origin/main' into doc/track-edm # Conflicts: # Core/include/Acts/EventData/MultiTrajectory.hpp # Core/include/Acts/EventData/MultiTrajectoryBackendConcept.hpp # Core/include/Acts/EventData/TrackContainer.hpp # Core/include/Acts/EventData/TrackContainerBackendConcept.hpp # Core/include/Acts/EventData/TrackProxy.hpp # Core/include/Acts/EventData/TrackStateProxy.hpp # Core/include/Acts/EventData/VectorMultiTrajectory.hpp # Core/include/Acts/EventData/VectorTrackContainer.hpp # Plugins/Podio/include/Acts/Plugins/Podio/PodioTrackContainer.hpp # Plugins/Podio/include/Acts/Plugins/Podio/PodioTrackStateContainer.hpp # docs/core/eventdata/index.md # docs/core/eventdata/measurements.md # docs/core/eventdata/particle_hypothesis.md # docs/core/eventdata/tracks.md # docs/requirements.txt commit acf3c1b Author: Paul Gessinger <hello@paulgessinger.com> Date: Wed Dec 13 08:21:34 2023 +0100 sections commit 2bd5ee9 Author: Paul Gessinger <hello@paulgessinger.com> Date: Tue Dec 12 22:44:01 2023 +0100 using namespace commit ef5f417 Author: Paul Gessinger <hello@paulgessinger.com> Date: Tue Dec 12 22:28:12 2023 +0100 describe proxy accessors commit a27b470 Author: Paul Gessinger <hello@paulgessinger.com> Date: Tue Dec 12 21:59:17 2023 +0100 fix doxygen error commit 29d0954 Author: Paul Gessinger <hello@paulgessinger.com> Date: Tue Dec 12 19:16:02 2023 +0100 wip: write about accessors commit 5efe30f Author: Paul Gessinger <hello@paulgessinger.com> Date: Tue Dec 12 19:15:29 2023 +0100 feat: Generalize Accessors for Tracks and TrackStates Uses the same underlying pattern but now works for both tracks and trackstates commit 1a7f560 Merge: 88806fe 8c0b283 Author: Paul Gessinger <hello@paulgessinger.com> Date: Tue Dec 12 17:37:42 2023 +0100 Merge branch 'feat/track-edm-make-object' into doc/track-edm commit 88806fe Author: Paul Gessinger <hello@paulgessinger.com> Date: Tue Dec 12 17:28:28 2023 +0100 remove the make functions in favor of acts-project#2817 commit 8c0b283 Author: Paul Gessinger <hello@paulgessinger.com> Date: Tue Dec 12 17:11:54 2023 +0100 feat: Track EDM: Add functions to create and return proxies commit c89e7ce Author: Paul Gessinger <hello@paulgessinger.com> Date: Tue Dec 12 17:02:33 2023 +0100 some reshuffling in MTJ commit b2d2b4e Author: Paul Gessinger <hello@paulgessinger.com> Date: Tue Dec 12 17:02:22 2023 +0100 compile fix commit ebc9779 Author: Paul Gessinger <hello@paulgessinger.com> Date: Tue Dec 12 16:51:33 2023 +0100 add makeTrackState function to MTJ commit 27cc858 Author: Paul Gessinger <hello@paulgessinger.com> Date: Tue Dec 12 16:36:52 2023 +0100 comment fixes to multitrajectory commit 7be6aa1 Author: Paul Gessinger <hello@paulgessinger.com> Date: Tue Dec 12 15:13:00 2023 +0100 progress commit 3f799d1 Author: Paul Gessinger <hello@paulgessinger.com> Date: Tue Dec 12 14:09:19 2023 +0100 fixes commit db90029 Author: Paul Gessinger <hello@paulgessinger.com> Date: Tue Dec 12 09:21:08 2023 +0100 track proxy comments sort of done commit cc33f7c Author: Paul Gessinger <hello@paulgessinger.com> Date: Mon Dec 11 17:30:55 2023 +0100 fix bad merge (particleHypothesis got reverted) commit 4126080 Author: Paul Gessinger <hello@paulgessinger.com> Date: Mon Dec 11 15:19:46 2023 +0100 tmp commit 3634e24 Author: Paul Gessinger <hello@paulgessinger.com> Date: Mon Dec 11 11:25:01 2023 +0100 don't automatically run white paper index commit 66869d7 Author: Paul Gessinger <hello@paulgessinger.com> Date: Mon Dec 11 10:46:34 2023 +0100 split up event data into folder with sub files commit 56ca27b Author: Paul Gessinger <hello@paulgessinger.com> Date: Tue Dec 12 15:46:39 2023 +0100 format fix commit c1b54da Author: Paul Gessinger <paul.gessinger@cern.ch> Date: Tue Dec 12 14:21:14 2023 +0100 fix aliasing error commit b5da69a Author: Paul Gessinger <hello@paulgessinger.com> Date: Mon Dec 11 17:23:33 2023 +0100 refactor!: Split TrackStateProxy into own header, public This moves TrackStateProxy into it's own header file, and moves it out of the `detail_lt` namespace. commit bb039f9 Merge: 620da1d f7106bc Author: Paul Gessinger <hello@paulgessinger.com> Date: Mon Dec 11 15:23:52 2023 +0100 Merge remote-tracking branch 'origin/main' into refactor/track-edm-copy-dynamic-backends commit 620da1d Author: Paul Gessinger <hello@paulgessinger.com> Date: Mon Dec 4 17:03:24 2023 +0100 fix another concept violation commit c9df58e Author: Paul Gessinger <hello@paulgessinger.com> Date: Mon Dec 4 16:37:42 2023 +0100 fix concepts commit 3e024c1 Merge: e6b50de cf14470 Author: Paul Gessinger <paul.gessinger@cern.ch> Date: Wed Nov 29 18:54:01 2023 +0100 Merge branch 'main' into refactor/track-edm-copy-dynamic-backends commit e6b50de Author: Paul Gessinger <hello@paulgessinger.com> Date: Wed Nov 29 18:43:08 2023 +0100 Revert "centralize dynamic columns recovery and use typelist" This reverts commit 6dcf392. commit 4ddf5c3 Author: Paul Gessinger <hello@paulgessinger.com> Date: Wed Nov 29 18:41:35 2023 +0100 Revert "build: Add target to build all unit tests" This reverts commit 4bbe4af. commit 6dcf392 Author: Paul Gessinger <hello@paulgessinger.com> Date: Wed Nov 29 18:40:26 2023 +0100 centralize dynamic columns recovery and use typelist commit edfa27f Author: Paul Gessinger <hello@paulgessinger.com> Date: Wed Nov 29 18:20:19 2023 +0100 dynamic column test implementation working Added construction from mutable to const track state container (albeit fragile) commit 0a7506f Author: Paul Gessinger <hello@paulgessinger.com> Date: Wed Nov 29 17:18:53 2023 +0100 fix track container test commit 4bbe4af Author: Paul Gessinger <hello@paulgessinger.com> Date: Wed Nov 29 17:17:32 2023 +0100 build: Add target to build all unit tests commit 32d9918 Author: Paul Gessinger <hello@paulgessinger.com> Date: Wed Nov 29 16:58:06 2023 +0100 complete actual copy implementation commit a694752 Merge: 0bcaf7f 1bf0daf Author: Paul Gessinger <paul.gessinger@cern.ch> Date: Wed Nov 29 16:02:57 2023 +0100 Merge branch 'main' into refactor/track-edm-copy-dynamic-backends commit 0bcaf7f Author: Paul Gessinger <hello@paulgessinger.com> Date: Wed Nov 22 14:36:41 2023 +0100 missing include commit e5dd9fb Author: Paul Gessinger <hello@paulgessinger.com> Date: Wed Nov 22 14:31:40 2023 +0100 Add particle hypo support in PODIO backend commit bfb8f41 Author: Paul Gessinger <hello@paulgessinger.com> Date: Wed Nov 22 14:11:14 2023 +0100 update PODIO track backend to be complete and current (missing particle hypothesis still) commit 8956d6c Author: Paul Gessinger <hello@paulgessinger.com> Date: Wed Nov 22 11:26:28 2023 +0100 feat: Dyn col copying btw. different backend (Track+TrackState)

andiwand

1/2

docs/glossary.md

docs/core/eventdata/index.md

docs/core/eventdata/tracks.md

andiwand

2/2

docs/core/eventdata/tracks.md

andiwand · 2024-02-13T12:50:15Z

Thank you @paulgessinger, I think this is excellent!

paulgessinger · 2024-02-14T14:21:37Z

@AJPfleger can you have another look?

acts-project-service · 2024-02-14T18:00:30Z

✅ Athena integration test results [`d043298`]

✅ All tests successful

status	job	report
🟢	run_unit_tests
🟢	test_ActsEFTrackFit
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsConversionWorkflow
🟢	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsPersistifyEDM
🟢	test_ActsGSFRefitting
🟢	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🟢	test_ActsITkTest
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco

tboldagh · 2024-02-15T13:28:27Z

@paulgessinger I am late to this game it seems (sorry buffer overflow). I just wonder if we could point from the docu to Athena repo. It is public for something.

paulgessinger · 2024-02-15T14:12:23Z

@tboldagh Absolutely. Where do you want it to point to? I can make the change, or feel free to submit a PR updating the documentation with the link.

@beomki-yeo

After #2797 the white papers were missing in the read the docs build. Thanks @beomki-yeo for noticing. https://acts--3067.org.readthedocs.build/en/3067/white_papers/index.html

Blocked by: - acts-project#2816 - acts-project#2817 - acts-project#2819

@beomki-yeo

After acts-project#2797 the white papers were missing in the read the docs build. Thanks @beomki-yeo for noticing. https://acts--3067.org.readthedocs.build/en/3067/white_papers/index.html

Blocked by: - acts-project#2816 - acts-project#2817 - acts-project#2819

@beomki-yeo

After acts-project#2797 the white papers were missing in the read the docs build. Thanks @beomki-yeo for noticing. https://acts--3067.org.readthedocs.build/en/3067/white_papers/index.html

paulgessinger added this to the next milestone Dec 11, 2023

github-actions bot added Component - Core Affects the Core module Infrastructure Changes to build tools, continous integration, ... Component - Plugins Affects one or more Plugins Component - Documentation Affects the documentation Vertexing labels Dec 11, 2023

paulgessinger linked an issue Dec 11, 2023 that may be closed by this pull request

Write documentation on the Track EDM #2788

Closed

andiwand previously approved these changes Dec 11, 2023

View reviewed changes

paulgessinger dismissed andiwand’s stale review via 99bdf4d December 12, 2023 08:21

paulgessinger force-pushed the doc/track-edm branch from f17281f to 99bdf4d Compare December 12, 2023 08:21

github-actions bot added Event Data Model and removed Vertexing labels Dec 12, 2023

paulgessinger force-pushed the doc/track-edm branch from 99bdf4d to c89e7ce Compare December 12, 2023 16:03

paulgessinger mentioned this pull request Dec 12, 2023

docs: Track EDM doxygen comment updates #2816

Merged

paulgessinger added the 🛑 blocked This item is blocked by another item label Dec 12, 2023

github-actions bot added Component - Examples Affects the Examples module Track Finding labels Dec 12, 2023

kodiakhq bot pushed a commit that referenced this pull request Dec 18, 2023

docs: Track EDM doxygen comment updates (#2816)

ba0ab93

This is pulled out of #2797 and includes only the doxygen comment changes. Blocked by: - #2712 - #2817 - #2807

paulgessinger force-pushed the doc/track-edm branch from 9cc6174 to 74fc6ce Compare December 18, 2023 18:15

github-actions bot removed Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Event Data Model Track Finding labels Dec 18, 2023

spelling

2449f13

paulgessinger marked this pull request as ready for review December 18, 2023 19:29

andiwand reviewed Feb 13, 2024

View reviewed changes

PR feedback

e1fd72b

github-actions bot added Component - Core Affects the Core module Event Data Model labels Feb 13, 2024

andiwand reviewed Feb 13, 2024

View reviewed changes

paulgessinger added 2 commits February 13, 2024 15:32

More PR feedback

fe72428

add clea to podio track backend

10cc72d

AJPfleger previously approved these changes Feb 14, 2024

View reviewed changes

github-actions bot added the Component - Plugins Affects one or more Plugins label Feb 14, 2024

a few spell fixes

3925c1e

paulgessinger dismissed AJPfleger’s stale review via 3925c1e February 14, 2024 14:40

AJPfleger approved these changes Feb 14, 2024

View reviewed changes

paulgessinger added the automerge label Feb 14, 2024

Merge branch 'main' into doc/track-edm

92bce34

kodiakhq bot merged commit d043298 into acts-project:main Feb 14, 2024
54 checks passed

github-actions bot removed the automerge label Feb 14, 2024

paulgessinger deleted the doc/track-edm branch February 15, 2024 14:12

paulgessinger modified the milestones: next, v33.0.0 Mar 6, 2024

AJPfleger mentioned this pull request Mar 28, 2024

docs: missing white papers section in RTD #3067

Merged

EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024

docs: Document Track EDM (acts-project#2797)

6e717f5

Blocked by: - acts-project#2816 - acts-project#2817 - acts-project#2819

asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024

docs: Document Track EDM (acts-project#2797)

4b49ff7

Blocked by: - acts-project#2816 - acts-project#2817 - acts-project#2819

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: Document Track EDM #2797

docs: Document Track EDM #2797

paulgessinger commented Dec 11, 2023 •

edited

Loading

paulgessinger commented Dec 11, 2023

codecov bot commented Dec 11, 2023 •

edited

Loading

github-actions bot commented Dec 11, 2023 •

edited

Loading

andiwand left a comment

andiwand left a comment

andiwand commented Feb 13, 2024

paulgessinger commented Feb 14, 2024

acts-project-service commented Feb 14, 2024

tboldagh commented Feb 15, 2024

paulgessinger commented Feb 15, 2024

docs: Document Track EDM #2797

docs: Document Track EDM #2797

Conversation

paulgessinger commented Dec 11, 2023 • edited Loading

paulgessinger commented Dec 11, 2023

codecov bot commented Dec 11, 2023 • edited Loading

Codecov Report

github-actions bot commented Dec 11, 2023 • edited Loading

📊: Physics performance monitoring for 92bce34

physmon summary

andiwand left a comment

Choose a reason for hiding this comment

andiwand left a comment

Choose a reason for hiding this comment

andiwand commented Feb 13, 2024

paulgessinger commented Feb 14, 2024

acts-project-service commented Feb 14, 2024

✅ Athena integration test results [d043298]

✅ All tests successful

tboldagh commented Feb 15, 2024

paulgessinger commented Feb 15, 2024

paulgessinger commented Dec 11, 2023 •

edited

Loading

codecov bot commented Dec 11, 2023 •

edited

Loading

github-actions bot commented Dec 11, 2023 •

edited

Loading

📊: Physics performance monitoring for `92bce34`

✅ Athena integration test results [`d043298`]