Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Track EDM doxygen comment updates #2816

Merged
merged 45 commits into from
Dec 18, 2023

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Dec 12, 2023

paulgessinger and others added 30 commits November 22, 2023 11:30
Added construction from mutable to const track state container (albeit fragile)
This moves TrackStateProxy into it's own header file, and moves it out
of the `detail_lt` namespace.
@paulgessinger paulgessinger added 🛑 blocked This item is blocked by another item and removed 🛑 blocked This item is blocked by another item labels Dec 13, 2023
paulgessinger and others added 3 commits December 15, 2023 13:52
…-project#2712)

This PR adds:

- Support for MultiTrajectory to copy Dynamic Columns at all (not implemented before)
- TrackContainer to copy dynamic columns between backends, by refactoring the way the columns are looked up.
  - This requires changing the backend contract to add a method `dynamicKeys_impl` to get hashes of all the dynamic column keys + changing the `copyDynamicColumns_impl` method.
…t#2820)

This was an inconsistency due to different parallel developments.

Blocked by:
- acts-project#2712
@paulgessinger paulgessinger removed the 🛑 blocked This item is blocked by another item label Dec 15, 2023
@paulgessinger paulgessinger marked this pull request as ready for review December 15, 2023 15:14
andiwand
andiwand previously approved these changes Dec 18, 2023
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I added some comments - ping me for re-approval if necessary

Core/include/Acts/EventData/TrackContainer.hpp Outdated Show resolved Hide resolved
Core/include/Acts/EventData/TrackContainer.hpp Outdated Show resolved Hide resolved
Core/include/Acts/EventData/MultiTrajectory.hpp Outdated Show resolved Hide resolved
Core/include/Acts/EventData/TrackStateProxy.hpp Outdated Show resolved Hide resolved
Core/include/Acts/EventData/TrackStateProxy.hpp Outdated Show resolved Hide resolved
Core/include/Acts/EventData/TrackProxy.hpp Show resolved Hide resolved
Core/include/Acts/EventData/TrackProxy.hpp Show resolved Hide resolved
Core/include/Acts/EventData/TrackProxy.hpp Outdated Show resolved Hide resolved
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
@paulgessinger
Copy link
Member Author

Suggestions applied, format fixed. This should be green now @andiwand.

@kodiakhq kodiakhq bot merged commit ba0ab93 into acts-project:main Dec 18, 2023
52 checks passed
@acts-project-service
Copy link
Collaborator

acts-project-service commented Dec 18, 2023

🔴 Athena integration test results

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Dec 18, 2023
@paulgessinger paulgessinger deleted the doc/track-edm-doxygen-only branch December 18, 2023 16:32
kodiakhq bot pushed a commit that referenced this pull request Dec 19, 2023
Uses the same underlying pattern but now works for both tracks and
trackstates

Blocked by:
- #2816

BREAKING CHANGE: `TrackAcessor` and `ConstTrackAccessor` become `ProxyAccessor` and `ConstProxyAccessor`, and move to `Acts/EventData/ProxyAccessor.hpp`.
@paulgessinger paulgessinger modified the milestones: next, v32.0.0 Jan 19, 2024
@paulgessinger paulgessinger added Breaks Athena build This PR breaks the Athena build and removed Breaks Athena build This PR breaks the Athena build labels Jan 23, 2024
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
This is pulled out of acts-project#2797 and includes only the doxygen comment changes.

Blocked by:
- acts-project#2712
- acts-project#2817 
- acts-project#2807
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
…2819)

Uses the same underlying pattern but now works for both tracks and
trackstates

Blocked by:
- acts-project#2816

BREAKING CHANGE: `TrackAcessor` and `ConstTrackAccessor` become `ProxyAccessor` and `ConstProxyAccessor`, and move to `Acts/EventData/ProxyAccessor.hpp`.
kodiakhq bot pushed a commit that referenced this pull request Feb 14, 2024
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module Component - Plugins Affects one or more Plugins Event Data Model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants