-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Track EDM doxygen comment updates #2816
Merged
kodiakhq
merged 45 commits into
acts-project:main
from
paulgessinger:doc/track-edm-doxygen-only
Dec 18, 2023
Merged
docs: Track EDM doxygen comment updates #2816
kodiakhq
merged 45 commits into
acts-project:main
from
paulgessinger:doc/track-edm-doxygen-only
Dec 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulgessinger
added
🛑 blocked
This item is blocked by another item
and removed
🛑 blocked
This item is blocked by another item
labels
Dec 13, 2023
…-project#2712) This PR adds: - Support for MultiTrajectory to copy Dynamic Columns at all (not implemented before) - TrackContainer to copy dynamic columns between backends, by refactoring the way the columns are looked up. - This requires changing the backend contract to add a method `dynamicKeys_impl` to get hashes of all the dynamic column keys + changing the `copyDynamicColumns_impl` method.
…t#2820) This was an inconsistency due to different parallel developments. Blocked by: - acts-project#2712
andiwand
previously approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I added some comments - ping me for re-approval if necessary
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Suggestions applied, format fixed. This should be green now @andiwand. |
andiwand
approved these changes
Dec 18, 2023
acts-project-service
added
the
Breaks Athena build
This PR breaks the Athena build
label
Dec 18, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 19, 2023
Uses the same underlying pattern but now works for both tracks and trackstates Blocked by: - #2816 BREAKING CHANGE: `TrackAcessor` and `ConstTrackAccessor` become `ProxyAccessor` and `ConstProxyAccessor`, and move to `Acts/EventData/ProxyAccessor.hpp`.
paulgessinger
added
Breaks Athena build
This PR breaks the Athena build
and removed
Breaks Athena build
This PR breaks the Athena build
labels
Jan 23, 2024
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
This is pulled out of acts-project#2797 and includes only the doxygen comment changes. Blocked by: - acts-project#2712 - acts-project#2817 - acts-project#2807
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
…2819) Uses the same underlying pattern but now works for both tracks and trackstates Blocked by: - acts-project#2816 BREAKING CHANGE: `TrackAcessor` and `ConstTrackAccessor` become `ProxyAccessor` and `ConstProxyAccessor`, and move to `Acts/EventData/ProxyAccessor.hpp`.
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaks Athena build
This PR breaks the Athena build
Component - Core
Affects the Core module
Component - Plugins
Affects one or more Plugins
Event Data Model
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pulled out of #2797 and includes only the doxygen comment changes.
Blocked by: