Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Generalize Accessors for Tracks and TrackStates #2819

Merged
merged 6 commits into from
Dec 19, 2023
Merged

feat!: Generalize Accessors for Tracks and TrackStates #2819

merged 6 commits into from
Dec 19, 2023

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Dec 12, 2023 •
edited
Loading

Uses the same underlying pattern but now works for both tracks and
trackstates

Blocked by:

BREAKING CHANGE: TrackAcessor and ConstTrackAccessor become ProxyAccessor and ConstProxyAccessor, and move to Acts/EventData/ProxyAccessor.hpp.

@paulgessinger paulgessinger added this to the next milestone Dec 12, 2023
@paulgessinger paulgessinger added the 🛑 blocked This item is blocked by another item label Dec 12, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Component - Documentation Affects the documentation Event Data Model Track Finding labels Dec 12, 2023
@paulgessinger paulgessinger changed the title feat: Generalize Accessors for Tracks and TrackStates feat!: Generalize Accessors for Tracks and TrackStates Dec 12, 2023
@paulgessinger
Copy link
Member Author

This could also avoid being breaking by typedefing, but we're scheduled for a major version anyway, so I'm not doing that.

@github-actions github-actions bot added Track Fitting and removed Component - Documentation Affects the documentation labels Dec 12, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (601c041) 48.82% compared to head (6c15bdf) 48.86%.

Files Patch % Lines
Core/include/Acts/EventData/ProxyAccessor.hpp 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2819      +/-   ##
==========================================
+ Coverage   48.82%   48.86%   +0.04%     
==========================================
  Files         484      485       +1     
  Lines       28173    28175       +2     
  Branches    13292    13280      -12     
==========================================
+ Hits        13755    13769      +14     
  Misses       4821     4821              
+ Partials     9597     9585      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2023 •
edited
Loading

📊: Physics performance monitoring for 6c15bdf

Full contents

physmon summary

@paulgessinger paulgessinger mentioned this pull request Dec 18, 2023
Merged
paulgessinger and others added 3 commits December 18, 2023 22:20
@paulgessinger
feat: Generalize Accessors for Tracks and TrackStates
cc5f023 
Uses the same underlying pattern but now works for both tracks and
trackstates
@paulgessinger
fix doxygen error
453e624
@paulgessinger
fix remaining uses of TrackAccessor
03319e4
@github-actions github-actions bot removed the Component - Plugins Affects one or more Plugins label Dec 18, 2023
@paulgessinger paulgessinger marked this pull request as ready for review December 18, 2023 21:22
@paulgessinger paulgessinger removed the 🛑 blocked This item is blocked by another item label Dec 18, 2023
@acts-project-service
Copy link
Collaborator

acts-project-service commented Dec 18, 2023 •
edited
Loading

✅ Athena integration test results [288471d]

✅ All tests successful

status job report
🟢 run_unit_tests
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsBenchmarkWithSpot.sh 8 100
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateAmbiguityResolution.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateResolvedTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsGSFRefitting.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco

andiwand
andiwand approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@kodiakhq kodiakhq bot merged commit 288471d into acts-project:main Dec 19, 2023
52 checks passed
@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Dec 19, 2023
@paulgessinger paulgessinger modified the milestones: next, v32.0.0 Jan 19, 2024
@paulgessinger paulgessinger removed the Breaks Athena build This PR breaks the Athena build label Jan 23, 2024
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
@paulgessinger @LaraCalic
feat!: Generalize Accessors for Tracks and TrackStates (acts-project#…
97eaaa1 
…2819)

Uses the same underlying pattern but now works for both tracks and
trackstates

Blocked by:
- acts-project#2816

BREAKING CHANGE: `TrackAcessor` and `ConstTrackAccessor` become `ProxyAccessor` and `ConstProxyAccessor`, and move to `Acts/EventData/ProxyAccessor.hpp`.
kodiakhq bot pushed a commit that referenced this pull request Feb 14, 2024
@paulgessinger
docs: Document Track EDM (#2797)
d043298 
Blocked by:

- #2816 
- #2817
- #2819
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
@paulgessinger @EleniXoch
docs: Document Track EDM (acts-project#2797)
6e717f5 
Blocked by:

- acts-project#2816 
- acts-project#2817
- acts-project#2819
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
@paulgessinger @asalzburger
docs: Document Track EDM (acts-project#2797)
4b49ff7 
Blocked by:

- acts-project#2816 
- acts-project#2817
- acts-project#2819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andiwand andiwand andiwand approved these changes

@EdwardMoyse EdwardMoyse Awaiting requested review from EdwardMoyse

Assignees
No one assigned
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Event Data Model Track Finding Track Fitting
Projects
None yet
Milestone
v32.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@paulgessinger @acts-project-service @andiwand