Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(edm): Add functions to create and return track(state) proxies #2817

Merged
merged 4 commits into from
Dec 13, 2023
Merged

feat(edm): Add functions to create and return track(state) proxies #2817

merged 4 commits into from
Dec 13, 2023

Conversation

paulgessinger
Copy link
Member

This adds convenience functions to create a track and a track state and returns a corresponding proxy object directly, instead of the index.

@paulgessinger paulgessinger added this to the v32.0.0 milestone Dec 12, 2023
@paulgessinger paulgessinger changed the title feat: Track EDM: Add functions to create and return proxies feat(edm): Add functions to create and return track(state) proxies Dec 12, 2023
paulgessinger added a commit to paulgessinger/acts that referenced this pull request Dec 12, 2023
@paulgessinger
remove the make functions in favor of acts-project#2817
88806fe
paulgessinger added a commit to paulgessinger/acts that referenced this pull request Dec 12, 2023
@paulgessinger
remove the make functions in favor of acts-project#2817
55e6fdf
This was referenced Dec 12, 2023
Merged
Merged
@github-actions github-actions bot added Component - Core Affects the Core module Event Data Model labels Dec 12, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2023 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (dfb07ef) 48.62% compared to head (f21fb5c) 48.62%.
Report is 1 commits behind head on main.

Files Patch % Lines
...ts/EventData/detail/MultiTrajectoryTestsCommon.hpp 25.00% 0 Missing and 6 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2817   +/-   ##
=======================================
  Coverage   48.62%   48.62%           
=======================================
  Files         480      480           
  Lines       28019    28031   +12     
  Branches    13256    13262    +6     
=======================================
+ Hits        13624    13630    +6     
  Misses       4801     4801           
- Partials     9594     9600    +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2023 •
edited
Loading

📊: Physics performance monitoring for f21fb5c

Full contents

physmon summary

@andiwand
Copy link
Contributor

nice!

EdwardMoyse
EdwardMoyse approved these changes Dec 13, 2023
View reviewed changes
Copy link

@EdwardMoyse EdwardMoyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kodiakhq kodiakhq bot merged commit 9007810 into acts-project:main Dec 13, 2023
52 checks passed
@acts-project-service
Copy link
Collaborator

acts-project-service commented Dec 13, 2023 •
edited
Loading

✅ Athena integration test results [9007810]

✅ All tests successful

status job report
🟢 run_unit_tests
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsBenchmarkWithSpot.sh 8 100
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateAmbiguityResolution.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateResolvedTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsGSFRefitting.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Dec 13, 2023
kodiakhq bot pushed a commit that referenced this pull request Dec 18, 2023
@paulgessinger
docs: Track EDM doxygen comment updates (#2816)
ba0ab93 
This is pulled out of #2797 and includes only the doxygen comment changes.

Blocked by:
- #2712
- #2817 
- #2807
paulgessinger added a commit to paulgessinger/acts that referenced this pull request Dec 18, 2023
@paulgessinger
Squashed commit of the following:
74fc6ce 
commit 9cc6174
Merge: acf3c1b ba0ab93
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Mon Dec 18 19:10:14 2023 +0100

    Merge remote-tracking branch 'origin/main' into doc/track-edm

    # Conflicts:
    #	Core/include/Acts/EventData/MultiTrajectory.hpp
    #	Core/include/Acts/EventData/MultiTrajectoryBackendConcept.hpp
    #	Core/include/Acts/EventData/TrackContainer.hpp
    #	Core/include/Acts/EventData/TrackContainerBackendConcept.hpp
    #	Core/include/Acts/EventData/TrackProxy.hpp
    #	Core/include/Acts/EventData/TrackStateProxy.hpp
    #	Core/include/Acts/EventData/VectorMultiTrajectory.hpp
    #	Core/include/Acts/EventData/VectorTrackContainer.hpp
    #	Plugins/Podio/include/Acts/Plugins/Podio/PodioTrackContainer.hpp
    #	Plugins/Podio/include/Acts/Plugins/Podio/PodioTrackStateContainer.hpp
    #	docs/core/eventdata/index.md
    #	docs/core/eventdata/measurements.md
    #	docs/core/eventdata/particle_hypothesis.md
    #	docs/core/eventdata/tracks.md
    #	docs/requirements.txt

commit acf3c1b
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Wed Dec 13 08:21:34 2023 +0100

    sections

commit 2bd5ee9
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Tue Dec 12 22:44:01 2023 +0100

    using namespace

commit ef5f417
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Tue Dec 12 22:28:12 2023 +0100

    describe proxy accessors

commit a27b470
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Tue Dec 12 21:59:17 2023 +0100

    fix doxygen error

commit 29d0954
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Tue Dec 12 19:16:02 2023 +0100

    wip: write about accessors

commit 5efe30f
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Tue Dec 12 19:15:29 2023 +0100

    feat: Generalize Accessors for Tracks and TrackStates

    Uses the same underlying pattern but now works for both tracks and
    trackstates

commit 1a7f560
Merge: 88806fe 8c0b283
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Tue Dec 12 17:37:42 2023 +0100

    Merge branch 'feat/track-edm-make-object' into doc/track-edm

commit 88806fe
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Tue Dec 12 17:28:28 2023 +0100

    remove the make functions in favor of acts-project#2817

commit 8c0b283
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Tue Dec 12 17:11:54 2023 +0100

    feat: Track EDM: Add functions to create and return proxies

commit c89e7ce
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Tue Dec 12 17:02:33 2023 +0100

    some reshuffling in MTJ

commit b2d2b4e
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Tue Dec 12 17:02:22 2023 +0100

    compile fix

commit ebc9779
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Tue Dec 12 16:51:33 2023 +0100

    add makeTrackState function to MTJ

commit 27cc858
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Tue Dec 12 16:36:52 2023 +0100

    comment fixes to multitrajectory

commit 7be6aa1
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Tue Dec 12 15:13:00 2023 +0100

    progress

commit 3f799d1
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Tue Dec 12 14:09:19 2023 +0100

    fixes

commit db90029
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Tue Dec 12 09:21:08 2023 +0100

    track proxy comments sort of done

commit cc33f7c
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Mon Dec 11 17:30:55 2023 +0100

    fix bad merge (particleHypothesis got reverted)

commit 4126080
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Mon Dec 11 15:19:46 2023 +0100

    tmp

commit 3634e24
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Mon Dec 11 11:25:01 2023 +0100

    don't automatically run white paper index

commit 66869d7
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Mon Dec 11 10:46:34 2023 +0100

    split up event data into folder with sub files

commit 56ca27b
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Tue Dec 12 15:46:39 2023 +0100

    format fix

commit c1b54da
Author: Paul Gessinger <paul.gessinger@cern.ch>
Date:   Tue Dec 12 14:21:14 2023 +0100

    fix aliasing error

commit b5da69a
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Mon Dec 11 17:23:33 2023 +0100

    refactor!: Split TrackStateProxy into own header, public

    This moves TrackStateProxy into it's own header file, and moves it out
    of the `detail_lt` namespace.

commit bb039f9
Merge: 620da1d f7106bc
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Mon Dec 11 15:23:52 2023 +0100

    Merge remote-tracking branch 'origin/main' into refactor/track-edm-copy-dynamic-backends

commit 620da1d
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Mon Dec 4 17:03:24 2023 +0100

    fix another concept violation

commit c9df58e
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Mon Dec 4 16:37:42 2023 +0100

    fix concepts

commit 3e024c1
Merge: e6b50de cf14470
Author: Paul Gessinger <paul.gessinger@cern.ch>
Date:   Wed Nov 29 18:54:01 2023 +0100

    Merge branch 'main' into refactor/track-edm-copy-dynamic-backends

commit e6b50de
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Wed Nov 29 18:43:08 2023 +0100

    Revert "centralize dynamic columns recovery and use typelist"

    This reverts commit 6dcf392.

commit 4ddf5c3
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Wed Nov 29 18:41:35 2023 +0100

    Revert "build: Add target to build all unit tests"

    This reverts commit 4bbe4af.

commit 6dcf392
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Wed Nov 29 18:40:26 2023 +0100

    centralize dynamic columns recovery and use typelist

commit edfa27f
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Wed Nov 29 18:20:19 2023 +0100

    dynamic column test implementation working

    Added construction from mutable to const track state container (albeit fragile)

commit 0a7506f
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Wed Nov 29 17:18:53 2023 +0100

    fix track container test

commit 4bbe4af
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Wed Nov 29 17:17:32 2023 +0100

    build: Add target to build all unit tests

commit 32d9918
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Wed Nov 29 16:58:06 2023 +0100

    complete actual copy implementation

commit a694752
Merge: 0bcaf7f 1bf0daf
Author: Paul Gessinger <paul.gessinger@cern.ch>
Date:   Wed Nov 29 16:02:57 2023 +0100

    Merge branch 'main' into refactor/track-edm-copy-dynamic-backends

commit 0bcaf7f
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Wed Nov 22 14:36:41 2023 +0100

    missing include

commit e5dd9fb
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Wed Nov 22 14:31:40 2023 +0100

    Add particle hypo support in PODIO backend

commit bfb8f41
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Wed Nov 22 14:11:14 2023 +0100

    update PODIO track backend to be complete and current (missing particle
    hypothesis still)

commit 8956d6c
Author: Paul Gessinger <hello@paulgessinger.com>
Date:   Wed Nov 22 11:26:28 2023 +0100

    feat: Dyn col copying btw. different backend (Track+TrackState)
@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Jan 23, 2024
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
@paulgessinger @LaraCalic
feat(edm): Add functions to create and return track(state) proxies (a…
9aac0d9 
…cts-project#2817)

This adds convenience functions to create a track and a track state and returns a corresponding proxy object directly, instead of the index.
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
@paulgessinger @LaraCalic
docs: Track EDM doxygen comment updates (acts-project#2816)
af985da 
This is pulled out of acts-project#2797 and includes only the doxygen comment changes.

Blocked by:
- acts-project#2712
- acts-project#2817 
- acts-project#2807
kodiakhq bot pushed a commit that referenced this pull request Feb 14, 2024
@paulgessinger
docs: Document Track EDM (#2797)
d043298 
Blocked by:

- #2816 
- #2817
- #2819
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 6, 2024
@paulgessinger @EleniXoch
docs: Document Track EDM (acts-project#2797)
6e717f5 
Blocked by:

- acts-project#2816 
- acts-project#2817
- acts-project#2819
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
@paulgessinger @asalzburger
docs: Document Track EDM (acts-project#2797)
4b49ff7 
Blocked by:

- acts-project#2816 
- acts-project#2817
- acts-project#2819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdwardMoyse EdwardMoyse EdwardMoyse approved these changes

@andiwand andiwand andiwand approved these changes

Assignees
No one assigned
Labels
Component - Core Affects the Core module Event Data Model
Projects
None yet
Milestone
v32.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@paulgessinger @andiwand @acts-project-service @EdwardMoyse