ServiceNow CMR integration #3392
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added servicenow CMR template for github actions
updated template to remove skms and swap it with ServiceNow
started adding servicenow api calls
added the servicenow cmr calls.
test branch added
removed skms.yml where we are using servicenow
updated function calls and parameters
test update
Updated calls to output to file and check output for successful curl calls. Fixes jq parsing command.
testing output
fixed github env variable declarations for token, cmr_id, transaction_id, release_title
added output to console for response from curl
fixed file existence and size check
small update
fixed curl statements and timestamps
another small update
testing theory
testing arguments
second attempt
updated branch to remove caching from GitHub Actions, hopefully.
reverted changes of new branch
another small fix
testing a thought
moved release summary to last param where it stops other parameters from being read.
testing out semantics for env variables
updated shell commands to fix errors
small github env fixes
updated curl statement
updated calls and timespans
added new python scripts and removed shell script
added sanitization method
updated servicenow integration to use python
updated variables and added headers
fixed cmr_id parsing and cmr closing
added small test change for PR
fixing environment variable access
amauch-adobe
requested review from
narcis-radu,
thedoc31,
mokimo,
Ruchika4 and
jedjedjedM
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3392 +/- ##
==========================================
- Coverage 98.21% 96.48% -1.74%
==========================================
Files 64 254 +190
Lines 7848 59031 +51183
==========================================
+ Hits 7708 56955 +49247
- Misses 140 2076 +1936 ☔ View full report in Codecov by Sentry. |
fixed branches in yaml
mokimo
approved these changes
Dec 18, 2024
narcis-radu
approved these changes
Dec 18, 2024
updated approvers, removed executor so that the default "Change Management API Integration" user is used instead.
changed stage variables, urls to prod
thedoc31
approved these changes
Dec 18, 2024
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Ruchika4
approved these changes
Dec 19, 2024
mokimo
approved these changes
Dec 19, 2024
|
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-156500
Test URLs: