Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): disable HTTP caching #1880

Merged
merged 3 commits into from
Jan 10, 2025
Merged

feat(rust): disable HTTP caching #1880

merged 3 commits into from
Jan 10, 2025

Conversation

imobachgs
Copy link
Contributor

Problem

When connecting to the same machine (e.g. a server) but using a different version of Agama (e.g., you are using a new build), the browser cache could display the old UI.

Solution

Disable the cache by setting the no-store value. In the future, we could prefer using a different mechanism, like the Etag header.

Testing

  • Tested manually

@ancorgs
Copy link
Contributor

ancorgs commented Jan 10, 2025

To me, using etag (eg. based on the machine-id) sounds like the right approach.

I kind of fear no-store could be too much and cause some performance problems.

Buy I'm pretty clueless so it's pure speculation on my side.

@imobachgs
Copy link
Contributor Author

I do not expect any performance problem to be honest. You only need to load the code once (the HTML and a big JavaScript file).

Reloading the app is the only case but, for Agama 11, I would say it is good enough.

@imobachgs
Copy link
Contributor Author

And it is not enough with setting the etag value only. So for Agama 11 I prefer the "conservative" solution. However, I will do some tests.

@imobachgs imobachgs marked this pull request as ready for review January 10, 2025 08:55
Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, despite the weird error on CI, which doesn't look related to this PR.

@imobachgs imobachgs merged commit 9ac7280 into master Jan 10, 2025
8 of 9 checks passed
@imobachgs imobachgs deleted the cache-control branch January 10, 2025 09:46
@imobachgs imobachgs mentioned this pull request Jan 10, 2025
imobachgs added a commit that referenced this pull request Jan 13, 2025
Update to release version 11.

* #1495
* #1564
* #1617
* #1618
* #1625
* #1626
* #1627
* #1628
* #1630
* #1631
* #1632
* #1633
* #1634
* #1635
* #1636
* #1639
* #1640
* #1641
* #1642
* #1643
* #1644
* #1645
* #1646
* #1647
* #1648
* #1649
* #1650
* #1651
* #1652
* #1654
* #1655
* #1656
* #1657
* #1660
* #1663
* #1666
* #1667
* #1668
* #1670
* #1671
* #1673
* #1674
* #1675
* #1676
* #1677
* #1681
* #1682
* #1683
* #1684
* #1687
* #1688
* #1689
* #1690
* #1691
* #1692
* #1693
* #1694
* #1695
* #1696
* #1698
* #1699
* #1702
* #1703
* #1704
* #1705
* #1707
* #1708
* #1709
* #1710
* #1711
* #1712
* #1713
* #1714
* #1715
* #1716
* #1717
* #1718
* #1720
* #1721
* #1722
* #1723
* #1727
* #1728
* #1729
* #1731
* #1732
* #1733
* #1734
* #1735
* #1736
* #1737
* #1740
* #1741
* #1743
* #1744
* #1745
* #1746
* #1751
* #1753
* #1754
* #1755
* #1757
* #1762
* #1763
* #1764
* #1765
* #1766
* #1767
* #1769
* #1771
* #1772
* #1773
* #1774
* #1777
* #1778
* #1785
* #1786
* #1787
* #1788
* #1789
* #1790
* #1791
* #1792
* #1793
* #1794
* #1795
* #1796
* #1797
* #1798
* #1799
* #1800
* #1802
* #1803
* #1804
* #1805
* #1807
* #1808
* #1809
* #1810
* #1811
* #1812
* #1814
* #1815
* #1821
* #1822
* #1823
* #1824
* #1825
* #1826
* #1827
* #1828
* #1830
* #1831
* #1832
* #1833
* #1834
* #1835
* #1836
* #1837
* #1838
* #1839
* #1840
* #1841
* #1842
* #1843
* #1844
* #1845
* #1847
* #1848
* #1849
* #1850
* #1851
* #1854
* #1855
* #1856
* #1857
* #1860
* #1861
* #1863
* #1864
* #1865
* #1866
* #1867
* #1871
* #1872
* #1873
* #1875
* #1876
* #1877
* #1878
* #1880
* #1881
* #1882
* #1883
* #1884
* #1885
* #1886
* #1888
* #1889
* #1890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants