Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bulk backporting of recent changes from main #1953

Merged
merged 11 commits into from
May 4, 2024
Merged

chore: bulk backporting of recent changes from main #1953

merged 11 commits into from
May 4, 2024

Conversation

krancour
Copy link
Member

@krancour krancour commented May 4, 2024

Fixes #1934

maksimstankevic and others added 11 commits May 3, 2024 19:53
@maksimstankevic @krancour
feat(controller): Apply Warehouse Git subscription path filters to al…
9f8ec81 
…l CommitSelectionStrategy types (akuity#1918)

Signed-off-by: Maksim Stankevic <maksim.stankevic1@gmail.com>
@krancour
fix(api): fix bug in kargo role update logic (akuity#1937)
66b7fb4 
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour
chore: remove dead generated code (akuity#1938)
b6e3b82 
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@rbreeze @krancour
fix(ui): Manual Approval mode became activated after promotions (akui…
7ef7658 
…ty#1941)

Signed-off-by: Remington Breeze <remington@breeze.software>
@krancour
fix(chart): update and clean up global admin and viewer roles (akuity…
db81342 
…#1944)

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@rbreeze @krancour
chore(ui): update logo (akuity#1940)
e45d15f 
Signed-off-by: Remington Breeze <remington@breeze.software>
@krancour @hiddeco
feat(controller): auto-create project-level admin and viewer roles on…
ba87cd3 
… project creation (akuity#1942)

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Co-authored-by: Hidde Beydals <hiddeco@users.noreply.github.com>
@krancour
docs: roadmap adjustments (akuity#1932)
7359aad 
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour
fix(controller): add missing annotation to role bindings (akuity#1948)
f27bdeb 
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour
refactor: improve ux for managing roles (akuity#1947)
04b205b 
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@rbreeze @krancour
feat(ui): Permissions Management (akuity#1939)
3d475f9 
Signed-off-by: Remington Breeze <remington@breeze.software>
@krancour krancour added this to the v0.6.0 milestone May 4, 2024
@krancour krancour self-assigned this May 4, 2024
@krancour krancour requested review from a team as code owners May 4, 2024 00:15
@krancour krancour changed the title bulk backporting of recent changes from main chore: bulk backporting of recent changes from main May 4, 2024
@krancour krancour enabled auto-merge (squash) May 4, 2024 00:18
@codecov Codecov
Copy link

codecov bot commented May 4, 2024

Codecov Report

Attention: Patch coverage is 86.87500% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 46.21%. Comparing base (ce6da17) to head (3d475f9).

Files Patch % Lines
internal/api/rbac/policy_rules.go 73.68% 10 Missing ⚠️
internal/api/rbac/roles.go 70.37% 4 Missing and 4 partials ⚠️
internal/cli/cmd/grant/grant.go 0.00% 8 Missing ⚠️
internal/cli/cmd/revoke/revoke.go 0.00% 8 Missing ⚠️
...nternal/controller/management/projects/projects.go 97.63% 2 Missing and 2 partials ⚠️
internal/controller/warehouses/git.go 94.28% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-0.6    #1953      +/-   ##
===============================================
+ Coverage        45.63%   46.21%   +0.57%     
===============================================
  Files              235      235              
  Lines            15862    16042     +180     
===============================================
+ Hits              7239     7414     +175     
- Misses            8263     8264       +1     
- Partials           360      364       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour merged commit dfe3a41 into akuity:release-0.6 May 4, 2024
17 checks passed
@krancour krancour deleted the krancour/0.6-backports branch June 28, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbreeze rbreeze rbreeze approved these changes

Assignees

@krancour krancour

Labels
area/release-process kind/chore priority/high
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@krancour @rbreeze @maksimstankevic