-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ip-restriction wasm-go plugin #759
Conversation
@Renz7, @johnlanni 想请教一下为什么 IP 是通过请求头进行获取,而不是使用 proxywasm.GetProperty([]string{"source","address"}) |
你说的有道理,查了下相关的文档 |
可以加个配置,允许用户配置ip来源:
|
cc @WeixinX |
@SpecialYang 支持IP黑白名单的插件,有空一起review下 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其他的我认为没什么问题 ~
@Renz7 请再按上述要求做一下代码调整,调整完成后我将代码合入 |
OK 我尽快 |
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Co-authored-by: Xunzhuo <bitliu@tencent.com>
@johnlanni @WeixinX PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #759 +/- ##
==========================================
+ Coverage 38.13% 38.16% +0.02%
==========================================
Files 61 61
Lines 10436 10436
==========================================
+ Hits 3980 3983 +3
+ Misses 6156 6154 -2
+ Partials 300 299 -1 |
Ⅰ. Describe what this PR did
ip-restriction impl.
Ⅱ. Does this pull request fix one issue?
fixes #607
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews