Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing sonar as sensor_msgs/Range implementation #39

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ongun-kanat
Copy link
Contributor

This patch implements enhancement in issue #35 also fixes redundancy in #37.
Thanks

@reed-adept
Copy link

An alternative would be to have one topic that publishes a set of Range messages, but perhaps that's not how Range is intended to be used? How is Range usually used for multiple instances of the same range sensor? Also would we also need to publish the sonar sensor locations (using tf)?

@ongun-kanat
Copy link
Contributor Author

Maybe further solution like creating a new message type for sonar messages in RosAria can be better/more flexible. As I see sensor_msgs/Range is used to publish single range data. If we create our own message type we can also publish tf info in it.

@reed-adept
Copy link

Using a standard type is best, just wondering what the most typical way of using Range is.

@ongun-kanat
Copy link
Contributor Author

In the manual (http://docs.ros.org/api/sensor_msgs/html/msg/Range.html) it says it is for single range data. This guy (https://fleshandmachines.wordpress.com/2011/09/16/arduino-double-sonar-with-ros/) also used similar solution. He uses multiple topics for sensor_msgs/Range data.

@ongun-kanat
Copy link
Contributor Author

I've added missing parts of range message. Tested on Pioneer3DX robot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants