Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add signature generation configuration #5442

Closed
wants to merge 26 commits into from
Closed

docs: add signature generation configuration #5442

wants to merge 26 commits into from

Conversation

Meschreiber
Copy link
Contributor

Adds experimental configuration for enhanced signature generation

Meschreiber and others added 6 commits June 12, 2024 17:38
@Meschreiber
Add raw info about operation signature configuration
09e7412
@Meschreiber
Copyedit
6e791d6
@Geal
use the JSON path implementation from serde-json-bytes (#5346)
a1dd372 
JSON path usage in custom instruments was requiring a transformation to serde_json::Value before selecting, which had a performance impact. This updates the serde_json_bytes crate version to 0.2.3, where it introduces a JSON path implementation ported over from jsonpath_rust and improved.
The overhead of JSON selection was measured at 2.6% with a router on dev at acb1bdb, and 0.1% with this commit
@dylan-apollo
Rename the scaffold Cargo.toml files so that they don't confuse car…
e3412dc 
…go (#5438)
@duckki
fixed a (type-position, schema) inconsistency in `compute_nodes_for_k…
5de98ef 
…ey_resolution` (#5435)

Partially fixes https://apollographql.atlassian.net/browse/FED-251
@Meschreiber
Add example before/after signatures
4fff2b4
@Meschreiber Meschreiber requested a review from a team as a code owner June 13, 2024 21:45
@Meschreiber Meschreiber marked this pull request as draft June 13, 2024 21:45
@github-actions GitHub Actions
Copy link
Contributor

@Meschreiber, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Jun 13, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • reload - Reload test over a long period of time at a constant rate of users
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • no-tracing - Basic stress test, no tracing
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • xlarge-request - Stress test with 10 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • xxlarge-request - Stress test with 100 MB request payload
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • large-request - Stress test with a 1 MB request payload
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled

@Meschreiber Meschreiber requested a review from bonnici June 13, 2024 21:48
@Meschreiber Meschreiber marked this pull request as ready for review June 13, 2024 21:48
bonnici
bonnici reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@bonnici bonnici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the enterprise-only tag.

docs/source/configuration/overview.mdx Outdated Show resolved Hide resolved
bnjjj and others added 3 commits June 14, 2024 11:31
@bnjjj
add selector for router service in custom telemetry (#5392)
e15d0d9 
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@BrynCooke
Add cost information to protobuf traces (#5430)
028b287 
Co-authored-by: bryn <bryn@apollographql.com>
@Meschreiber
Remove Enterprise tag
497c041
@Meschreiber Meschreiber requested a review from bonnici June 14, 2024 14:36
Meschreiber and others added 3 commits June 14, 2024 08:37
@Meschreiber
Merge branch 'dev' into docs/add-signature-generation-configuration
7885a34
@sachindshinde @dariuszkuc
Fix bug in selection set equality checking (#5457)
6be2b07 
This PR fixes a bug in selection set equality checking where it compares the schema and selection set's type when it shouldn't.

Note that we encountered this bug when discovering that condition exclusion wasn't working as expected. With this bugfix, computing how to jump to each subgraph should be much faster when there are many subgraphs.

Co-authored-by: Derek Kuc <dkuc@apollographql.com>
@sachindshinde
Fix bug in interface object type collection during query planner cons…
bbe1f35 
…truction (#5453)
@Meschreiber Meschreiber requested a review from a team June 14, 2024 20:54
duckki and others added 6 commits June 14, 2024 19:42
@duckki
fix: fixed filter_on_schema (#5459)
b4326a3 
This PR fixes a small logic bug in filter_on_schema.
4 of the requires.rs test failures are gone.
@duckki
test: updated plan_simple_root_field_query_for_multiple_subgraphs t…
8f848ee 
…est (#5455)
@duckki @lrlna
Updated/added the comments on tests (#5445)
1b3434c 
Co-authored-by: Iryna Shestak <shestak.irina@gmail.com>
@duckki
fixed inputs_for_require to use the entity_type/schema (#5460)
3fc39ab 
- Eliminated most of the remaining failures of FED-251.

(Partially) Fixes https://apollographql.atlassian.net/browse/FED-251
@lrlna
fix(bridge_query_planner): change log level for mismatches (#5450)
0f388fc 
When using `experimental_query_planner_mode:both`, emit mismatch metrics as debug rather than warn as there are still a fair few mismatches.
@Meschreiber
Merge branch 'dev' into docs/add-signature-generation-configuration
e90de4b
@Meschreiber Meschreiber changed the base branch from dev to 1.49.0 June 17, 2024 17:35
@Meschreiber
Copy link
Contributor Author

Closed in favor of #5466

@abernix abernix mentioned this pull request Jun 17, 2024
Merged
@abernix abernix deleted the docs/add-signature-generation-configuration branch January 20, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonnici bonnici bonnici approved these changes

@dariuszkuc dariuszkuc Awaiting requested review from dariuszkuc

@sachindshinde sachindshinde Awaiting requested review from sachindshinde

@goto-bus-stop goto-bus-stop Awaiting requested review from goto-bus-stop

@SimonSapin SimonSapin Awaiting requested review from SimonSapin

@lrlna lrlna Awaiting requested review from lrlna

@TylerBloom TylerBloom Awaiting requested review from TylerBloom

@duckki duckki Awaiting requested review from duckki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Meschreiber @bonnici @Geal @dylan-apollo @duckki @bnjjj @BrynCooke @sachindshinde @lrlna @abernix