Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove velodyne subtree #1966

Merged
merged 6 commits into from
Feb 14, 2019
Merged

Fix/remove velodyne subtree #1966

merged 6 commits into from
Feb 14, 2019

Conversation

amc-nu
Copy link
Member

@amc-nu amc-nu commented Feb 7, 2019

Status

PRODUCTION / DEVELOPMENT

Description

autowarefoundation/autoware_ai#545

Steps to Test

  1. Install the official package using rosdep.
$ rosdep update
$ rosdep install -y --from-paths src --ignore-src --rosdistro $ROS_DISTRO
  1. Launch RTM using run.
  2. Launch Velodyne drivers as usual from the Sensing tab.

Copy link

@aohsato aohsato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested VLP-32C but this published to /velodyne_points topic not remapped. Plz check #1967.
Additionally, I suggest merging velodyne_xxx.launch files to one launch and switching model by argument OR creating launch package like velodyne_launch.

@amc-nu
Copy link
Member Author

amc-nu commented Feb 7, 2019

For the time being cross compilation is failing on CI. To fix this issue, @sgermanserrano will kindly update the docker image used.

@sgermanserrano
Copy link

@amc-nu @aohsato I'm working on the updated image to fix also #1930

@amc-nu
Copy link
Member Author

amc-nu commented Feb 14, 2019

Thanks for updating the image @sgermanserrano

@amc-nu amc-nu merged commit 3af11e6 into develop Feb 14, 2019
@amc-nu amc-nu deleted the fix/remove_velodyne_subtree branch February 14, 2019 13:16
anubhavashok pushed a commit to NuronLabs/autoware.ai that referenced this pull request Sep 7, 2021
* Removed subtree

* Add rtm launchfiles

* Launch files adapted to upstream driver

* Added install commands for runtiume manager velodyne launch files

* Fix remapping VLP-32C topic name (autowarefoundation#1967)

* Updated cross-build image date (autowarefoundation#1975)
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants