feat(Core/CFBG): Added support module mod-cfbg #2064

Winfidonarleyan · 2019-07-05T10:13:38Z

Really? - Yes

Finally, PR, which adds support for the module mod-cfbg
(A little humor, in connection with the recent events 👍 )

CHANGES PROPOSED:

Added support mod-cfbg module

ISSUES ADDRESSED: No

TESTS PERFORMED:

Build win (VS 16.1.3)
Test in-game Random BG
Test in-game WSG

HOW TO TEST THE CHANGES:

Apply this PR
Added module mod-cfbg
Enable system

KNOWN ISSUES AND TODO LIST:

Test all BG + queue
Test all Arena + queue
Fix cpam chat
Fix language for fake players

Target branch(es): Master

solidmaxtor · 2019-07-05T10:48:41Z

I am add PR and add ../modules/mod-cfbg.
but all error in compilation for me.

Winfidonarleyan · 2019-07-05T10:53:27Z

@solidmaxtor I don't understand your message.

solidmaxtor · 2019-07-05T10:59:48Z

i am use you git clone comand for download module, but all error is repeat in compile for me.

apps/ci/ci-install-modules.sh

solidmaxtor · 2019-07-05T21:43:49Z

Test again:
Same error i am test PR 2064 only and pr2010+2064, with and without mod-cfbg, all same error.
(i am check ./acore.sh to install mod-cgbf work perfect)

Maybe this image help for check what is error or what am I failing XD

Winfidonarleyan · 2019-07-06T05:46:00Z

Need to resolve conflicts

FrancescoBorzi · 2019-07-06T11:48:07Z

@solidmaxtor you are using a branch that is not clean. Copy paste this command (this will also reset your sources, any unsaved work will be lost):

git checkout master; git reset --hard; git pull;

Now you are in a clean master branch, you can follow again the procedure to test PRs and test this one.

solidmaxtor · 2019-07-06T12:41:11Z

Last compile all pass ok
I will add in main server por active test.

solidmaxtor · 2019-07-07T15:51:05Z

2 days test, no crashes, no reports for me.
Is possible config this for specific leves? 10 to 79 maybe for no affect level 80 bg?

Winfidonarleyan · 2019-07-07T17:55:21Z

@solidmaxtor, The main thing for us is to test the support of the module, then we can redo the module as we want.
And thanks for testing

Winfidonarleyan · 2019-07-07T17:56:26Z

And, need test game chat in bg

Winfidonarleyan · 2019-07-07T18:19:04Z

@wowmane, Hello, ahah, maybe maybe

FrancescoBorzi · 2019-07-08T17:26:26Z

Excellent @Winfidonarleyan and thanks a lot @solidmaxtor and @wowmane for testing it

solidmaxtor · 2019-07-09T00:07:23Z

Hello, i am test in main server now, report many chat errors inside cross BG for Messengers in code or addons spam codes.

And have xtrain chat mensajes in all server.

i am erase second imagen i find error in module, i am test othe imagen .

Winfidonarleyan · 2019-07-09T11:39:55Z

Is this really about cross BG?

ELdoBA · 2019-07-09T11:45:09Z

Interesting. Will be great if someone else test this in game, and take a look on these chats. This doesn't mean, this issue is caused by cfbg. If i get some free time today, i'll give a test

FrancescoBorzi · 2019-07-09T19:04:11Z

Just to be safe: waiting for one more feedback to confirm that there are no issues here

solidmaxtor · 2019-07-13T05:38:01Z

Compile and test today, this is mi report

FINE - Cross repaying players
FINE - Cross factions
ERROR - BG chat does not work correctly
FINE - Finishing BG Restores factions correctly
ERROR - Finishing BG does not restore the MORF players must reloge

FrancescoBorzi · 2019-07-13T10:56:19Z

@Winfidonarleyan please check the report from @solidmaxtor

Winfidonarleyan · 2019-07-13T17:40:55Z

Morf change at leave bg only, chat need test and maybe rework, I don't have time right now.

andoys · 2019-07-24T09:24:00Z

Testing this on my server starting today :)
Edit:

Crossfaction Random Battleground queue message is not shown to everyone? only people who queue for some reason

Random Chat in guild and raid:

ELdoBA · 2019-07-26T13:22:46Z

After applying https://github.com/azerothcore/azerothcore-wotlk/pull/2064/files + module, we have a lot bugs now in battlegrounds

Issues at this moment, keep im mind that everything is not tested, so the list will be updated when i confirm new issue:

Random Spam Chat in Raid and Guild (If you write something in Raid chat, all of these messages will be shown also in guild, but in other structure, like numbers, symbols, etc etc - Too much spam.)
If you queue bg as a group there's chance you cannot attack each other bcoz you are friendly with the opssite factions.
When the Finishing Battleground, players are staying in their fake morphs provided for CFBG, leaving it doesn't restore Morph players (need to relog always)
BG Chat not working properly (Same like first)
Everything caused by module and this PR : feat(Core/CFBG): Added support module mod-cfbg #2064 and module https://github.com/Winfidonarleyan/mod-cfbg

talamortis · 2019-07-26T17:39:07Z

Can I please add, Why are you adding more hooks to the core and altering the main source code when its not needed?

andoys · 2019-08-03T04:05:06Z

I have tested latest:

Text for CFBG Random Battleground (Levels: 80 - 80). Registered x/x announcement is not GLOBAL. Only self can see the message.

i tested with 10 accounts. Lowered Random BG queue. But CFBG queue still won't start even 10/10. Maybe not detecting number of players correctly in queue.

Had to go do .debug bg for BG to start

Chat spam fixed
Tauren Warrior became Human Warrior in BG but can't understand Alliance Chat. (/say /battleground)
Draenei Warrior became Blood Efl Warrior in BG bug can't understand Horde Chat (/say /battleground)

Winfidonarleyan · 2019-08-04T05:30:19Z

@andoys Thanks for the feedback

Winfidonarleyan · 2019-08-04T09:36:57Z

Okay, I update module

Fix chat for not same-origin factions Winfidonarleyan/mod-cfbg@ed5bd36
Added support global announce (if enabled in conf) Winfidonarleyan/mod-cfbg@0fbaf3b

andoys · 2019-08-04T11:30:24Z

Latest CFBG Module test:

Queue global announcement now working
[] Random BG queue still not work ? set to 5 minimum team and still won't queue up even with 10/10. Had to .debug bg again.
Tauren Warrior who became Human Warrior can now be understood by all factions:
Morphing also fixed after BG:

Winfidonarleyan · 2019-08-04T13:14:15Z

You not set for big bg, Therefore, your queue does not work

andoys · 2019-08-04T13:34:54Z

Ahh its not part of this pull.
anyway tested working

tronx-antares · 2019-08-04T13:56:19Z

When will it be compatible?

Winfidonarleyan · 2019-08-04T14:05:16Z

After merge @tronx-antares

tronx-antares · 2019-08-04T14:07:27Z

Oks I'll be waiting for the module because I want to try it !! @Winfidonarleyan

* fix(Core/DB/Quest): Let Them Eat Crow (azerothcore#1680) * Import pending SQL update file... Referenced commit(s): 091e7c1 * fix (Core/Dungeon/Boss Script): Remove Goblin Rocket Pack from inventory. (azerothcore#2095) * fix(Core/Raid/Boss Script): Naxxramas boss loatheb kill event (azerothcore#2098) * fix(DB/SAI): Revamp Crystalweb Cavern (azerothcore#2105) * Import pending SQL update file... Referenced commit(s): 51e54da * chore: improved pull_request_template.md (azerothcore#2166) * chore(README.md): add Discord badge (azerothcore#2162) * fix(DB/Core): Throwing spells for Instructor Razuvious and Drakkari Battle Riders (azerothcore#2109) * Import pending SQL update file... Referenced commit(s): 5e34574 * feat(core/AI): implement DoCastSelf helper (azerothcore#2179) * Updated client data downloader url with vmaps 4.3 * feat(Core/CFBG): Added support module mod-cfbg (azerothcore#2064) https://github.com/Winfidonarleyan/mod-cfbg - Original module https://github.com/azerothcore/mod-cfbg - the fork in AC * fix(Core/Instance): Fix instance resetting exploit (azerothcore#2172) * fix(Core/Instance): Fix instance resetting exploit - Fix issue with instance reset exploit Co-Authored-By: Lee <talamortis@users.noreply.github.com> * Added another check Added a check to see if any players are in the current instance before teleporting the player to the entrance. * fix(DB/SAI): Mirage Raceway - goblin / gnome racing (azerothcore#2119) * Import pending SQL update file... Referenced commit(s): 825fde8 * fix(Scripts/Karazhan): Cleanup in opera event (azerothcore#2163) * fix(Core/Commands): Support morph uint32 ids (azerothcore#1753) * fix(DB/creature): Random movement for "Icemaw Bear" and "Ravenous Jormungar" (azerothcore#2149) * Import pending SQL update file... Referenced commit(s): 0232f0b * fix(Core/SpellInfo): Magmadar's Enrage dispel fix (azerothcore#2146) Putting the Magmadar's Enrage spell as a Buff to make it dispellable. * fix(DB/creature): Thorim position (Temple of Storms) (azerothcore#2160) * Import pending SQL update file... Referenced commit(s): ff1e6c0

FrancescoBorzi reviewed Jul 5, 2019

View reviewed changes

apps/ci/ci-install-modules.sh Outdated Show resolved Hide resolved

Winfidonarleyan added New Feature labels Jul 6, 2019

FrancescoBorzi added To Be Merged and removed Waiting to be tested labels Jul 8, 2019

FrancescoBorzi removed the To Be Merged label Jul 9, 2019

Winfidonarleyan mentioned this pull request Jul 10, 2019

[CFBG module part 3] Core/BG: Rework functions, delete ASSERT's. #2010

Merged

Winfidonarleyan added the WIP label Jul 26, 2019

Delete useless code

d9b8eb9

Update ci-install-modules.sh

f418367

Winfidonarleyan added To Be Merged and removed Waiting to be tested labels Aug 5, 2019

FrancescoBorzi requested review from talamortis, Nefertumm, Helias, milestorme, ELdoBA and Rochet2 August 5, 2019 13:31

Helias approved these changes Aug 5, 2019

View reviewed changes

Winfidonarleyan removed Ready for Review labels Aug 6, 2019

Winfidonarleyan merged commit d40e894 into azerothcore:master Aug 6, 2019

Winfidonarleyan deleted the cfbg-module branch August 6, 2019 02:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Core/CFBG): Added support module mod-cfbg #2064

feat(Core/CFBG): Added support module mod-cfbg #2064

Winfidonarleyan commented Jul 5, 2019 •

edited

Loading

solidmaxtor commented Jul 5, 2019 •

edited

Loading

Winfidonarleyan commented Jul 5, 2019

solidmaxtor commented Jul 5, 2019 •

edited

Loading

solidmaxtor commented Jul 5, 2019

Winfidonarleyan commented Jul 6, 2019

FrancescoBorzi commented Jul 6, 2019

solidmaxtor commented Jul 6, 2019

solidmaxtor commented Jul 7, 2019

Winfidonarleyan commented Jul 7, 2019 •

edited

Loading

Winfidonarleyan commented Jul 7, 2019 •

edited

Loading

Winfidonarleyan commented Jul 7, 2019

FrancescoBorzi commented Jul 8, 2019

solidmaxtor commented Jul 9, 2019 •

edited

Loading

Winfidonarleyan commented Jul 9, 2019

ELdoBA commented Jul 9, 2019

FrancescoBorzi commented Jul 9, 2019

solidmaxtor commented Jul 13, 2019 •

edited

Loading

FrancescoBorzi commented Jul 13, 2019

Winfidonarleyan commented Jul 13, 2019 •

edited

Loading

andoys commented Jul 24, 2019 •

edited

Loading

ELdoBA commented Jul 26, 2019

talamortis commented Jul 26, 2019 •

edited

Loading

andoys commented Aug 3, 2019 •

edited

Loading

Winfidonarleyan commented Aug 4, 2019

Winfidonarleyan commented Aug 4, 2019

andoys commented Aug 4, 2019 •

edited

Loading

Winfidonarleyan commented Aug 4, 2019

andoys commented Aug 4, 2019

tronx-antares commented Aug 4, 2019

Winfidonarleyan commented Aug 4, 2019

tronx-antares commented Aug 4, 2019

feat(Core/CFBG): Added support module mod-cfbg #2064

feat(Core/CFBG): Added support module mod-cfbg #2064

Conversation

Winfidonarleyan commented Jul 5, 2019 • edited Loading

Really? - Yes

CHANGES PROPOSED:

ISSUES ADDRESSED: No

TESTS PERFORMED:

HOW TO TEST THE CHANGES:

KNOWN ISSUES AND TODO LIST:

Target branch(es): Master

solidmaxtor commented Jul 5, 2019 • edited Loading

Winfidonarleyan commented Jul 5, 2019

solidmaxtor commented Jul 5, 2019 • edited Loading

solidmaxtor commented Jul 5, 2019

Winfidonarleyan commented Jul 6, 2019

FrancescoBorzi commented Jul 6, 2019

solidmaxtor commented Jul 6, 2019

solidmaxtor commented Jul 7, 2019

Winfidonarleyan commented Jul 7, 2019 • edited Loading

Winfidonarleyan commented Jul 7, 2019 • edited Loading

Winfidonarleyan commented Jul 7, 2019

FrancescoBorzi commented Jul 8, 2019

solidmaxtor commented Jul 9, 2019 • edited Loading

Winfidonarleyan commented Jul 9, 2019

ELdoBA commented Jul 9, 2019

FrancescoBorzi commented Jul 9, 2019

solidmaxtor commented Jul 13, 2019 • edited Loading

FrancescoBorzi commented Jul 13, 2019

Winfidonarleyan commented Jul 13, 2019 • edited Loading

andoys commented Jul 24, 2019 • edited Loading

ELdoBA commented Jul 26, 2019

talamortis commented Jul 26, 2019 • edited Loading

andoys commented Aug 3, 2019 • edited Loading

Winfidonarleyan commented Aug 4, 2019

Winfidonarleyan commented Aug 4, 2019

andoys commented Aug 4, 2019 • edited Loading

Winfidonarleyan commented Aug 4, 2019

andoys commented Aug 4, 2019

tronx-antares commented Aug 4, 2019

Winfidonarleyan commented Aug 4, 2019

tronx-antares commented Aug 4, 2019

Winfidonarleyan commented Jul 5, 2019 •

edited

Loading

solidmaxtor commented Jul 5, 2019 •

edited

Loading

solidmaxtor commented Jul 5, 2019 •

edited

Loading

Winfidonarleyan commented Jul 7, 2019 •

edited

Loading

Winfidonarleyan commented Jul 7, 2019 •

edited

Loading

solidmaxtor commented Jul 9, 2019 •

edited

Loading

solidmaxtor commented Jul 13, 2019 •

edited

Loading

Winfidonarleyan commented Jul 13, 2019 •

edited

Loading

andoys commented Jul 24, 2019 •

edited

Loading

talamortis commented Jul 26, 2019 •

edited

Loading

andoys commented Aug 3, 2019 •

edited

Loading

andoys commented Aug 4, 2019 •

edited

Loading