fix (Core/Raid/Boss Script): Naxxramas boss loatheb kill event #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 29, 2019 10:09
* Thx to mik1893 and TrinityCore
This reverts commit 5e21ad5.
|
@Selyria have you tested this? |
|
Tested, work fine now.... this issue is mark for "Priority - Low" I hate them for that HA HA |
|
Confirmed working |
ELdoBA
approved these changes
Jul 17, 2019
|
Thanks @GMKyle for PR, @Selyria , @solidmaxtor, @spinzaku for testing 👍 |
@FrancescoBorzi yes i have this tested |
ghost
merged commit 
ghost
mentioned this pull request
zqaazq
added a commit
to zqaazq/azerothcore-wotlk
that referenced
this pull request
Aug 5, 2019
* fix(Core/DB/Quest): Let Them Eat Crow (azerothcore#1680) * Import pending SQL update file... Referenced commit(s): 091e7c1 * fix (Core/Dungeon/Boss Script): Remove Goblin Rocket Pack from inventory. (azerothcore#2095) * fix(Core/Raid/Boss Script): Naxxramas boss loatheb kill event (azerothcore#2098) * fix(DB/SAI): Revamp Crystalweb Cavern (azerothcore#2105) * Import pending SQL update file... Referenced commit(s): 51e54da * chore: improved pull_request_template.md (azerothcore#2166) * chore(README.md): add Discord badge (azerothcore#2162) * fix(DB/Core): Throwing spells for Instructor Razuvious and Drakkari Battle Riders (azerothcore#2109) * Import pending SQL update file... Referenced commit(s): 5e34574
zqaazq
added a commit
to zqaazq/azerothcore-wotlk
that referenced
this pull request
Aug 12, 2019
* fix(Core/DB/Quest): Let Them Eat Crow (azerothcore#1680) * Import pending SQL update file... Referenced commit(s): 091e7c1 * fix (Core/Dungeon/Boss Script): Remove Goblin Rocket Pack from inventory. (azerothcore#2095) * fix(Core/Raid/Boss Script): Naxxramas boss loatheb kill event (azerothcore#2098) * fix(DB/SAI): Revamp Crystalweb Cavern (azerothcore#2105) * Import pending SQL update file... Referenced commit(s): 51e54da * chore: improved pull_request_template.md (azerothcore#2166) * chore(README.md): add Discord badge (azerothcore#2162) * fix(DB/Core): Throwing spells for Instructor Razuvious and Drakkari Battle Riders (azerothcore#2109) * Import pending SQL update file... Referenced commit(s): 5e34574 * feat(core/AI): implement DoCastSelf helper (azerothcore#2179) * Updated client data downloader url with vmaps 4.3 * feat(Core/CFBG): Added support module mod-cfbg (azerothcore#2064) https://github.com/Winfidonarleyan/mod-cfbg - Original module https://github.com/azerothcore/mod-cfbg - the fork in AC * fix(Core/Instance): Fix instance resetting exploit (azerothcore#2172) * fix(Core/Instance): Fix instance resetting exploit - Fix issue with instance reset exploit Co-Authored-By: Lee <talamortis@users.noreply.github.com> * Added another check Added a check to see if any players are in the current instance before teleporting the player to the entrance. * fix(DB/SAI): Mirage Raceway - goblin / gnome racing (azerothcore#2119) * Import pending SQL update file... Referenced commit(s): 825fde8 * fix(Scripts/Karazhan): Cleanup in opera event (azerothcore#2163) * fix(Core/Commands): Support morph uint32 ids (azerothcore#1753) * fix(DB/creature): Random movement for "Icemaw Bear" and "Ravenous Jormungar" (azerothcore#2149) * Import pending SQL update file... Referenced commit(s): 0232f0b * fix(Core/SpellInfo): Magmadar's Enrage dispel fix (azerothcore#2146) Putting the Magmadar's Enrage spell as a Buff to make it dispellable. * fix(DB/creature): Thorim position (Temple of Storms) (azerothcore#2160) * Import pending SQL update file... Referenced commit(s): ff1e6c0
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUES ADDRESSED:
When boss loatheb it's killed in Naxxramas, players remains trapped, and instance event is still running.
Closes
#2053
TESTS PERFORMED:
Build without errors and tested in-game. (Win10 and Debian 9 servers).
HOW TO TEST THE CHANGES:
Target branch(es):
Master