Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Core/SpellInfo.cpp) Magmadar's Enrage dispel fix #2146

Merged
merged 1 commit into from
Aug 10, 2019

Conversation

Shard-MW
Copy link
Member

Fixing Magmadar's Enrage spell

CHANGES PROPOSED:
  • Putting the Magmadar's Enrage spell as a Buff to make it dispelable.

Closes #2129

TESTS PERFORMED:

Dispelled Magmadar's Enrage successfully with Tranquilizing shot.
Windows 10.

Target branch(es):

Master

How to test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here in the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

Putting the Magmadar's Enrage spell as a Buff to make it dispelable.
@Knindzagxg
Copy link
Member

Tested and was able to dispel Enrage as well now.

@FrancescoBorzi FrancescoBorzi merged commit 82d53bf into azerothcore:master Aug 10, 2019
zqaazq added a commit to zqaazq/azerothcore-wotlk that referenced this pull request Aug 12, 2019
* fix(Core/DB/Quest): Let Them Eat Crow (azerothcore#1680)

* Import pending SQL update file...

Referenced commit(s): 091e7c1

* fix (Core/Dungeon/Boss Script): Remove Goblin Rocket Pack from inventory. (azerothcore#2095)

* fix(Core/Raid/Boss Script): Naxxramas boss loatheb kill event (azerothcore#2098)

* fix(DB/SAI): Revamp Crystalweb Cavern (azerothcore#2105)

* Import pending SQL update file...

Referenced commit(s): 51e54da

* chore: improved pull_request_template.md (azerothcore#2166)

* chore(README.md): add Discord badge (azerothcore#2162)

* fix(DB/Core): Throwing spells for Instructor Razuvious and Drakkari Battle Riders (azerothcore#2109)

* Import pending SQL update file...

Referenced commit(s): 5e34574

* feat(core/AI): implement DoCastSelf helper (azerothcore#2179)

* Updated client data downloader url with vmaps 4.3

* feat(Core/CFBG): Added support module mod-cfbg (azerothcore#2064)

https://github.com/Winfidonarleyan/mod-cfbg - Original module
https://github.com/azerothcore/mod-cfbg - the fork in AC

* fix(Core/Instance): Fix instance resetting exploit (azerothcore#2172)

* fix(Core/Instance): Fix instance resetting exploit

- Fix issue with instance reset exploit

Co-Authored-By: Lee <talamortis@users.noreply.github.com>

* Added another check

Added a check to see if any players are in the current instance before teleporting the player to the entrance.

* fix(DB/SAI): Mirage Raceway - goblin / gnome racing (azerothcore#2119)

* Import pending SQL update file...

Referenced commit(s): 825fde8

* fix(Scripts/Karazhan): Cleanup in opera event (azerothcore#2163)

* fix(Core/Commands): Support morph uint32 ids (azerothcore#1753)

* fix(DB/creature): Random movement for "Icemaw Bear" and "Ravenous Jormungar" (azerothcore#2149)

* Import pending SQL update file...

Referenced commit(s): 0232f0b

* fix(Core/SpellInfo): Magmadar's Enrage dispel fix (azerothcore#2146)

Putting the Magmadar's Enrage spell as a Buff to make it dispellable.

* fix(DB/creature): Thorim position (Temple of Storms) (azerothcore#2160)

* Import pending SQL update file...

Referenced commit(s): ff1e6c0
@Shard-MW Shard-MW deleted the patch-5 branch October 2, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hunter's Tranquilizing Shot cannot dispell Enrage(Spell ID 19451)
3 participants