Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB/SAI): Mirage Raceway - goblin / gnome racing #2119

Merged
1 commit merged into from Aug 7, 2019
Merged

fix(DB/SAI): Mirage Raceway - goblin / gnome racing #2119

1 commit merged into from Aug 7, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 21, 2019

CHANGES PROPOSED:
  • Implement racing between goblins and gnomes at the Mirage Raceway (Shimmering Flats). I did this from scratch as there exists only very sparse information about the race.
  • Fix a few position issues of the goblin / gnome pit crew (otherwise they are randomly moving on tents / tables).
ISSUES ADDRESSED:

Closes #2012

TESTS PERFORMED:

tested successfully in-game

HOW TO TEST THE CHANGES:
  • .tele MirageRaceway
  • the event will start ca. 30-90 seconds after Daisy is spawned (you'll see the Goblin / Gnome Racers slowly moving toward the start line)
  • just follow the racers (goblin / gnome team will win randomly)
  • after the race is finished the racers will despawn and after 10 minutes Daisy will also despawn
  • a new race will start after Daisy respawns again (5 minutes respawn time)
KNOWN ISSUES AND TODO LIST:

none

Target branch(es):

Master

@ghost ghost added the Waiting to be tested label Jul 21, 2019
@ELdoBA
Copy link
Contributor

ELdoBA commented Jul 21, 2019

Wow! Will look later , anyway great great job!!!!!

@Knindzagxg
Copy link
Member

Nice one mate.

Tested in-game, works perfect.

@ghost ghost merged commit 825fde8 into azerothcore:master Aug 7, 2019
@ghost ghost deleted the race branch August 7, 2019 06:05
zqaazq added a commit to zqaazq/azerothcore-wotlk that referenced this pull request Aug 12, 2019
* fix(Core/DB/Quest): Let Them Eat Crow (azerothcore#1680)

* Import pending SQL update file...

Referenced commit(s): 091e7c1

* fix (Core/Dungeon/Boss Script): Remove Goblin Rocket Pack from inventory. (azerothcore#2095)

* fix(Core/Raid/Boss Script): Naxxramas boss loatheb kill event (azerothcore#2098)

* fix(DB/SAI): Revamp Crystalweb Cavern (azerothcore#2105)

* Import pending SQL update file...

Referenced commit(s): 51e54da

* chore: improved pull_request_template.md (azerothcore#2166)

* chore(README.md): add Discord badge (azerothcore#2162)

* fix(DB/Core): Throwing spells for Instructor Razuvious and Drakkari Battle Riders (azerothcore#2109)

* Import pending SQL update file...

Referenced commit(s): 5e34574

* feat(core/AI): implement DoCastSelf helper (azerothcore#2179)

* Updated client data downloader url with vmaps 4.3

* feat(Core/CFBG): Added support module mod-cfbg (azerothcore#2064)

https://github.com/Winfidonarleyan/mod-cfbg - Original module
https://github.com/azerothcore/mod-cfbg - the fork in AC

* fix(Core/Instance): Fix instance resetting exploit (azerothcore#2172)

* fix(Core/Instance): Fix instance resetting exploit

- Fix issue with instance reset exploit

Co-Authored-By: Lee <talamortis@users.noreply.github.com>

* Added another check

Added a check to see if any players are in the current instance before teleporting the player to the entrance.

* fix(DB/SAI): Mirage Raceway - goblin / gnome racing (azerothcore#2119)

* Import pending SQL update file...

Referenced commit(s): 825fde8

* fix(Scripts/Karazhan): Cleanup in opera event (azerothcore#2163)

* fix(Core/Commands): Support morph uint32 ids (azerothcore#1753)

* fix(DB/creature): Random movement for "Icemaw Bear" and "Ravenous Jormungar" (azerothcore#2149)

* Import pending SQL update file...

Referenced commit(s): 0232f0b

* fix(Core/SpellInfo): Magmadar's Enrage dispel fix (azerothcore#2146)

Putting the Magmadar's Enrage spell as a Buff to make it dispellable.

* fix(DB/creature): Thorim position (Temple of Storms) (azerothcore#2160)

* Import pending SQL update file...

Referenced commit(s): ff1e6c0
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mirage Raceway: Missing goblin / gnome racing
3 participants