Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull upstream changes #3

Merged
merged 45 commits into from
Nov 11, 2020
Merged

Pull upstream changes #3

merged 45 commits into from
Nov 11, 2020

Commits on Oct 8, 2020

  1. BF: make TAB-like-separate TSV example use tabs 

    Original example in .md looks like tab separated since its
rendition is ugly, but it is just that -- spaces were not
used, not tabs.

Just so it might come handy (may be there is a command for that)
to display spaces and tabs for content in clipboard you could use
smth like

	$> xsel -o | sed -e 's, ,·,g' -e 's,\t,⇰,g'
	onset·duration⇰response_time⇰correct⇰stop_trial⇰go_trial
	200⇰200⇰0⇰n/a⇰n/a⇰n/a%
    @yarikoptic
    yarikoptic committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    c1506b3 View commit details
    Browse the repository at this point in the history

  2. ENH: add a note about tabs replaced with spaces in examples/html/pdf 

    More work needs to be done to make it all uniform and factually correct.
In "theory" markdown sources should use tabs.  HTML (and PDF) rendering should
provide nice rendition of those while layouting into a proper tabular presentation
and using some unicode characters to depict tab symbols.

For now -- note should suffice
    @yarikoptic
    yarikoptic committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    1cae338 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2020

  1. Fixing spec template on electrodes for eeg and ieeg.

    @adam2392
    adam2392 committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    d9da037 View commit details
    Browse the repository at this point in the history

  2. Update src/04-modality-specific-files/03-electroencephalography.md 

    Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
    @adam2392 @sappelhoff
    adam2392 and sappelhoff authored Oct 22, 2020
    Configuration menu
    Copy the full SHA
    a8ef7e5 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. enh: rewrite the fieldmaps subsection for consistency with rest of specs 

    this commit rewrites the fieldmaps subsection to better allocate the
proposed changes, while making its structure more consistent with the
previous contents of the section.
    @oesteban
    oesteban committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    648471c View commit details
    Browse the repository at this point in the history

  2. fix: replace weird example with plausible one

    @oesteban
    oesteban committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    ca5dcb8 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2020

  1. enh: summarize scenarios first following @sappelhoff's suggestion

    @oesteban
    oesteban committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    6e05ad6 View commit details
    Browse the repository at this point in the history

  2. fix: uprank the warning about dir-<label> to common principles 

    as this important principle was buried in the bottom of the fieldmaps
section.
    @oesteban
    oesteban committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    dd3c87f View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2020

  1. style for meg intro paragraphs

    @sappelhoff
    sappelhoff committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    c246aa6 View commit details
    Browse the repository at this point in the history

  2. introduce markers suffix in bids text

    @sappelhoff
    sappelhoff committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    3910133 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
    @sappelhoff @effigies @tsalo
    3 people authored Oct 27, 2020
    Configuration menu
    Copy the full SHA
    82f1271 View commit details
    Browse the repository at this point in the history

  2. update Contributing with info on how to respond to reviews

    @Remi-Gau
    Remi-Gau committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    d9a118f View commit details
    Browse the repository at this point in the history

  3. update information on how to add oneself as a contributor

    @Remi-Gau
    Remi-Gau committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    7a62cd0 View commit details
    Browse the repository at this point in the history

  4. update remi contributions

    @Remi-Gau
    Remi-Gau committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    ea70b05 View commit details
    Browse the repository at this point in the history

  5. fix: annotate magnitude2 map as OPTIONAL in case 1 template

    @oesteban
    oesteban authored Oct 27, 2020
    Configuration menu
    Copy the full SHA
    d81d291 View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
    @oesteban @tsalo
    oesteban and tsalo authored Oct 27, 2020
    Configuration menu
    Copy the full SHA
    7533998 View commit details
    Browse the repository at this point in the history

  7. Reorder the different section of CONTRIBUTING

    @Remi-Gau
    Remi-Gau committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    5f284b0 View commit details
    Browse the repository at this point in the history

  8. automatic enforcement of line length

    @Remi-Gau
    Remi-Gau committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    46ec071 View commit details
    Browse the repository at this point in the history

  9. enforce starting sentence on a new line

    @Remi-Gau
    Remi-Gau committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    d7636c7 View commit details
    Browse the repository at this point in the history

  10. add remi as maintainer

    @Remi-Gau
    Remi-Gau committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    37c7cca View commit details
    Browse the repository at this point in the history

  11. Merge pull request #657 from Remi-Gau/remi-add_maintainter 

    [MISC] add remi as maintainer
    @effigies
    effigies authored Oct 27, 2020
    Configuration menu
    Copy the full SHA
    222fd38 View commit details
    Browse the repository at this point in the history

  12. [DOC] Auto-generate changelog entry for PR #657

    @bids-maintenance
    bids-maintenance committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    5a88342 View commit details
    Browse the repository at this point in the history

  13. Update src/04-modality-specific-files/02-magnetoencephalography.md 

    #653 (comment)

Co-authored-by: Teon L Brooks <teon.brooks@gmail.com>
    @sappelhoff @teonbrooks
    sappelhoff and teonbrooks authored Oct 27, 2020
    Configuration menu
    Copy the full SHA
    7e7ef8f View commit details
    Browse the repository at this point in the history

  14. add historical perspective on KIT/yokogawa/ricoh data 

    Co-authored-by: Teon L Brooks <teon.brooks@gmail.com>
    @sappelhoff @teonbrooks
    sappelhoff and teonbrooks committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    b2cbd4a View commit details
    Browse the repository at this point in the history

  15. fix: indentation in example

    @oesteban
    oesteban authored Oct 27, 2020
    Configuration menu
    Copy the full SHA
    1c63137 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2020

  1. fix: more proper writing of B_0 and consistency changes

    @oesteban
    oesteban committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    9d1c49b View commit details
    Browse the repository at this point in the history

  2. fix: roll back nonstandard MAY NOT statement

    @oesteban
    oesteban committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    ea830e5 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review (from #622) 

    Co-authored-by: Chris Markiewicz <effigies@gmail.com>
    @oesteban @effigies
    oesteban and effigies committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    504dd30 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2020

  1. Merge pull request #650 from adam2392/elecs 

    [FIX] Fixing template string on electrodes for eeg and ieeg.
    @sappelhoff
    sappelhoff authored Oct 29, 2020
    Configuration menu
    Copy the full SHA
    14263cf View commit details
    Browse the repository at this point in the history

  2. [DOC] Auto-generate changelog entry for PR #650

    @bids-maintenance
    bids-maintenance committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    6394685 View commit details
    Browse the repository at this point in the history

  3. Improve note on spaces being used in this document 

    Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
    @yarikoptic @sappelhoff
    yarikoptic and sappelhoff authored Oct 29, 2020
    Configuration menu
    Copy the full SHA
    985cc8a View commit details
    Browse the repository at this point in the history

  4. add line break

    @sappelhoff
    sappelhoff authored Oct 29, 2020
    Configuration menu
    Copy the full SHA
    593d78f View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2020

  1. Merge pull request #653 from sappelhoff/markers 

    [FIX] add paragraph on MEG specific "markers" suffix in MEG spec
    @sappelhoff
    sappelhoff authored Oct 30, 2020
    Configuration menu
    Copy the full SHA
    8209147 View commit details
    Browse the repository at this point in the history

  2. [DOC] Auto-generate changelog entry for PR #653

    @bids-maintenance
    bids-maintenance committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    ae667b7 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Chris Markiewicz <effigies@gmail.com>
    @oesteban @effigies
    oesteban and effigies authored Oct 30, 2020
    Configuration menu
    Copy the full SHA
    353d346 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
    @Remi-Gau @sappelhoff
    Remi-Gau and sappelhoff authored Oct 31, 2020
    Configuration menu
    Copy the full SHA
    c187e03 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @Remi-Gau
    Remi-Gau authored Oct 31, 2020
    Configuration menu
    Copy the full SHA
    8a0618d View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2020

  1. fix wrong link to "help wanted" issues

    @Remi-Gau
    Remi-Gau committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    35b7830 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #643 from yarikoptic/bf-tab-example 

    [MISC] add brief note that TSV example in the spec may currently use either tab or space characters
    @sappelhoff
    sappelhoff authored Nov 2, 2020
    Configuration menu
    Copy the full SHA
    1c2d88d View commit details
    Browse the repository at this point in the history

  3. [DOC] Auto-generate changelog entry for PR #643

    @bids-maintenance
    bids-maintenance committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    6b337f9 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2020

  1. [ENH] Added white space after table 

    The next line following the table would otherwise be displayed as an extra row in the table. This was the case directly following the "Specific EEG fields MUST be present" table containing the `EEGReference`.
    @robertoostenveld
    robertoostenveld committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    ee5744e View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2020

  1. Merge pull request #660 from robertoostenveld/whitespace-after-table 

    [FIX] Added white space after table
    @effigies
    effigies authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    7d3f73a View commit details
    Browse the repository at this point in the history

  2. Merge pull request #651 from oesteban/rf/mri-fieldmaps 

    [FIX] Rewrite the MRI/fieldmaps subsection for consistency with the rest of specs
    @effigies
    effigies authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    4be793f View commit details
    Browse the repository at this point in the history

  3. Merge pull request #655 from Remi-Gau/remi-update_contributing 

    update Contributing with info on how to respond to reviews
    @effigies
    effigies authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    596a5d6 View commit details
    Browse the repository at this point in the history

  4. [DOC] Auto-generate changelog entry for PR #655

    @bids-maintenance
    bids-maintenance committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    580183f View commit details
    Browse the repository at this point in the history