Hirad/78900/add derived functionality #6788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
… are locked (binary-com#4644) * Ignore IDV verification if client is high risk * Fix formatting * Fix cfd-poi issue due to client store unavailability * Fix formatting * Merge with master * Fix formatting * Merge with master * Revert "Merge with master" This reverts commit 4bead99. * Fix merge issues * Chain extra condition to cover wrong status returned from BE * Fix: wrong component shown when manual upload is triggered
…s to TS (binary-com#6361) * perf(cashier routes): convert csahier routes to TS * perf(cashier routes): convert error-component to TS * refactor(error-dialog, types): refactor error-dialog types, move error type to shared types * perf(cashier): convert cashier to TS * perf(types): refactor types * refactor(routes with sub routes): refactor default subroute * refactor(types): add/refactor server error type * test: refactor pathname * refactor(route types): refactor route types * fix: fix ts error in React.Suspense
…#6343) * perf(cashier withdraw): convert withdrawal-verification-email to TS * perf: add data-testid for checklist action * perf(cashier withdraw): convert withdrawal-locked to TS * perf(types): add types for TClinetStore * perf(cashier withdraw): convert withdraw to TS * perf(cashier withdraw): convert crypto-withdraw-receipt to TS * perf(cashier withdraw): convert crypto-withdraw-form to TS * perf(cashier withdraw): convert withdrawal to TS * refactor(cashier withdraw): refactor array syntax (ts) * test(cashier withdraw): remove eslint disables for tests
…thdraw all his allowable withdrawal amount (binary-com#6032) * fix(cashier): ✨ handle `PACommisionWithdrawalLimit` state in `CashierLocked` * test(cashier): ✅ add test case to `CashierLocked` for `PACommisionWithdrawalLimit` * Trigger Build
* chore: update appstore tsconfig * chore: update appstore tsconfig * chore: add react and types/react packages to appstore * refactor: remove unnecessary includes * refactor: change from reexports to import -> export
…6275) * fix: trader typscript configuration issue * fix: tsc errors on trader
…m#6276) * chores: add typescript configuration on reports * fix: remove extra paths * fix: revert removing packages
* refactor(p2p-cashier): migrate p2p-cashier component to TS * commit * perf(types): add types for notification store * perf(types): add types for ui store * perf(types): convert p2p-cashier to TS * refactor(types): change RootStore type to TRootStore * test(p2p-cashier): test fix (change wrapper order fro p2p-cashier component) * refactor(types): refactor current_focus type * test(p2p-cashier): remove eslint disables
* refactor: converted on-ramp module into typescript * refactor: included type related to store in on-ramp * ts fix in on-ramp-provider-card.spec.tsx * added path in tsconfig * added path in tsconfig * added type for react-router-dom * added ts related change required for migrating all components (binary-com#5760) * changed the name of data-testid in on-ramp component * ts-migration-crypto-fiat-converter (binary-com#5796) * Trigger build * Update package-lock * ts-migration-cashier-notifications (binary-com#5765) * implemented review comments and updated branch as per latest upstream branch * bahar/funds_protection_component-ts-migration (binary-com#5756) * funds_protection_component-ts-migration * remove_extra_type_file * fix_merge_issue * hamid/migrate-transfer-confirm-to-ts (binary-com#5815) * Migrate TransferConfirm to TS * Rename component in test file * Replace Confirm with TransferConfirm in PAs * Enhance Tests * ts-migration-page-404 (binary-com#5766) * corrected imports in on-ramp pages * coreected setSideNotes type in on-ramp file * arranged the order of imports in on-ramp * refactor: add menu-option type to types folder in cashier * replaced type for FormEvent in on-ramp from Types * added types from TRootstore * added types of TClientStore, TUiStore and TCommonStore in on-ramp Co-authored-by: Nijil Nirmal <nijil@deriv.com> Co-authored-by: Bahar <bahar@firstsource.tech> Co-authored-by: Hamid <hamid@re-work.dev>
* Migrate Account Transfer to TS * Enhance type names * Remove eslint ignore line * Remove generic type from useState * trigger tests * Fix test errors * Change data-testid name
…6273) * fix: account typscript configuration issue * text: remove include comment on account tsconfig
* fix: circle ci issue * fix: circle ci issue
…y-com#6306) * build: add typescript to all packages * build: move typescript to devdependency * add some TS configs to eslint file * fix: conflicts
* checking circle/ci test * removed test changes * fix: updated tsconfig and fixed some errors * fix: updated tsconfig and added globals.d.ts * chore: removed experimentalsDecorators from local config
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
* Fix sidenote in mobile view of account-transfer * Remove duplicate title * Add sideNote title
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
…y-com#6177)" (binary-com#6424) This reverts commit 503e77e.
* carol/ P2P: 2FA (binary-com#6009) * add: icons * add: one more icon * add email verification modal * add invalid verification link modal * add email verified * add email blocked modal * add email blocked modal * use align prop instead * carol/ P2P: Email verification for orders (binary-com#6299) * fix: quotes * add: email verification * cleanup * don't kill me * add response checks * add comment * add: amount + currency * fixed loading of order details and chat * fixed design on responsive * fixed verification modal in responsive * show modal if error * fix * fixed truncated modal in ios * fix time * fix invalid verification modal * fix * fix * fixed verification modal in desktop * fix responsive +logged out user * fix: design for seller * the solution to all my problems * fix: modal * fix logout + modal * hide extra modal * i got 99 problems and 2fa is all of em * fix * fix * fix: amount * fix: amount * fix: add modal * fix: rating modal Co-authored-by: Farrah Mae Ochoa <farrah@deriv.com> Co-authored-by: Nijil Nirmal <nijil@deriv.com> Co-authored-by: Farrah Mae Ochoa <farrah@deriv.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
…m#6284) * checking circle/ci test * removed test changes * fix: updated ts config and fixed two errors returnd by tsc * fix: fixing errors returned by tsc (WIP) * fix: fixed all ts errors * chore: removed experimentalDecorators from tsconfig * fix: removed unnecessary path from tsconfig * fix: type added to transfer_to_hint
…inary-com#6027) * fix(components): 🐛 fix date picker month issue for non english languages by setting moment locale to `en` * refactor(components): ♻️ refactor `calendar-months` component to rely on month number instead of month name * fix(components): 🌐 add localization support for date picker month names * refactor(components): 🔥 remove redundant `month_headers` * chore(components): ➖ remove redundant `@deriv/translations` dependency * Trigger Build * fix(cashier): 📝 resolve PR comments
* Fix word break in payment agent contant details * Fix word break in payment agent contant details
* remove extra modal from 2FA flow * hide reasons
* created scam warning pop up message * Update website logo * Updated Scam Message Logo * changed client_country to br * rearrange imports * Updated all issue according to github comments * Update scss design * Update scss and modal * Update className and scss * Update scss margins for title * Update Modal into the correct component * Update dark mode and change country code from my to br * Update ui store to call function and set function * change my to br * Update UI Store and Update Scss modal * Update ui store * Remove unused width in modal * Update my to br * Update values for locaization for brandName and remove unuse scamMessageDisplay * Update logic for local storage * Update Toggle Modal Element * Update logout to remove localStorage element for scamMessage * Moving localStorage.removeItem to cleanUp function * Update scss and remove is_dark_mode * Update my to br * Not to display on Signup Page * Update new logic on not displaying message in new account * rearrange functions * Update Scss for mobile view * Update packages/core/src/App/Containers/WarningScamMessageModal/warning-scam-message.jsx Co-authored-by: Farzin Mirzaie <72082844+farzin-fs@users.noreply.github.com> * Update Scss format * Update divider into the modal Co-authored-by: Farzin Mirzaie <72082844+farzin-fs@users.noreply.github.com> Co-authored-by: Carol Sachdeva <58209918+carol-binary@users.noreply.github.com>
* fix: added a fallback case if virtual account is not available * fix: added fallback to missing objects containing loginid Co-authored-by: Carol Sachdeva <58209918+carol-binary@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
* Add required packages and icon and update qrcode * CFD dashboard for demo account * Fix tests errors * Fix PR comments * Add Huawei Link * Resolve PR comments * Edit SCSS classes * Resolve conflict * Change dxtrade type from synthetic to all * Resolve PR comments * Change texts * Apply QA commnets * Update AccoutSwitcher * Fix tests errors * Remove unneeded code * Enhance code * Run svgo for new dxtrade icons * Change QRCode url * Change QRCode url * Enhance Code * Check enabled property for existing accounts * Hide disabled account in the Account-Switcher * Change icon and text of the succes modal * Change Title of account information modal: currency * Add mobile app hint * Update Password Modal Text * Add TODO Co-authored-by: Yashim Wong <yashim@deriv.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
…into pre-appstore
…into pre-appstore
hirad-deriv
requested review from
matin-deriv and
balakrishna-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…into hirad/78900/add-derived-functionality
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
Codecov Report
@@ Coverage Diff @@
## pre-appstore #6788 +/- ##
===============================================
Coverage ? 21.11%
===============================================
Files ? 1536
Lines ? 34324
Branches ? 6044
===============================================
Hits ? 7248
Misses ? 26596
Partials ? 480 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Kudos, SonarCloud Quality Gate passed!
|
thisyahlen-deriv
approved these changes
Oct 20, 2022
mahdiyeh-deriv
approved these changes
Oct 20, 2022
mahdiyeh-deriv
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change