feat: add address verification for preferences step #3715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…phic-Radius-Set-Up
…oding-Showing-Name-and-Relationship-on-Preference-Screens
…g-Name-and-Relationship-on-Preference-Screens # Conflicts: # sites/partners/src/components/settings/PreferenceDrawer.tsx
…nce-Screens' into 3672/Geocoding-Preference-Address-Verification
KrissDrawing
added
the
2 reviews needed
19 tasks
ColinBuyck
previously requested changes
Nov 17, 2023
…nce-Screens' into 3672/Geocoding-Preference-Address-Verification
Base automatically changed from
3687/Geocoding-Showing-Name-and-Relationship-on-Preference-Screens
to
main
November 20, 2023 16:56
✅ Deploy Preview for bloom-demo-public ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Those addressForm was imported from |
sites/public/src/components/applications/ApplicationMultiselectQuestionStep.tsx
Outdated
Show resolved
Hide resolved
sites/public/src/components/applications/ApplicationMultiselectQuestionStep.tsx
Outdated
Show resolved
Hide resolved
sites/public/src/components/applications/ApplicationMultiselectQuestionStep.tsx
Show resolved
Hide resolved
ludtkemorgan
approved these changes
Nov 27, 2023
ludtkemorgan
added
1 review needed
ColinBuyck
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
LGTM 🥼 after the merge conflict are resolved.
Also just a note on the Figma/UIC piece! I think we'd generally want to avoid adding in any custom UIC components to the Bloom codebase as opposed to making UIC changes directly. After getting some thoughts from Emily + Morgan, I think this is okay for now since that UIC component will be phased out soon by using seeds components to build something similar in shared helpers.
If you notice the Figma isn't matching the available components in the future though, do you mind tagging design to get their perspective?
ColinBuyck
added
ready to merge
KrissDrawing
deleted the
3672/Geocoding-Preference-Address-Verification
branch
ludtkemorgan
pushed a commit
to housingbayarea/bloom
that referenced
this pull request
Jan 23, 2024
* feat: add collectAddress checkbox with subfields * test: update preference tests * fix: add minimum value validation for radius field * fix: make collect address not required * fix: expand collect address fields * fix: change fields order in PreferenceDrawer * feat: add address holder fields to application * fix: make added field optional * fix: display errors properly * feat: add address holder fields to application summary * feat: add address verification for preferences step * feat: adjust padding for application summary * fix: move address holder name and relationship fields to extraData * fix: remove redundant backend address holder fields * fix: use enum for address holder fields * fix: add alternate address form component * fix: remove redundant fields from new address form * fix: verify preferences address when collectAddress true * fix: block going back on address verification add string to translation * fix: use onClick to block address Verification back button
ludtkemorgan
added a commit
to housingbayarea/bloom
that referenced
this pull request
Jan 25, 2024
* feat: seeds button uptake (bloom-housing#3677) * fix: validate radius geocoding preferences (bloom-housing#3718) * fix: validate radius geocoding preferences * fix: move to more generic * fix: add test * fix: one more test * fix: change to true/false * feat: add address verification for preferences step (bloom-housing#3715) * feat: add collectAddress checkbox with subfields * test: update preference tests * fix: add minimum value validation for radius field * fix: make collect address not required * fix: expand collect address fields * fix: change fields order in PreferenceDrawer * feat: add address holder fields to application * fix: make added field optional * fix: display errors properly * feat: add address holder fields to application summary * feat: add address verification for preferences step * feat: adjust padding for application summary * fix: move address holder name and relationship fields to extraData * fix: remove redundant backend address holder fields * fix: use enum for address holder fields * fix: add alternate address form component * fix: remove redundant fields from new address form * fix: verify preferences address when collectAddress true * fix: block going back on address verification add string to translation * fix: use onClick to block address Verification back button * fix: update dependencies for backend (bloom-housing#3694) * feat: core changes for application style alignment (bloom-housing#3662) * test: fix cypress lat long error (bloom-housing#3746) * fix: padding issue on address verify (bloom-housing#3745) * feat: add show mandated accounts flag (bloom-housing#3773) * feat: mA-3752 feat: add SHOW_MANDATED_ACCOUNTS flag * fix: add feature flag to bloom public next config * fix: remove flag from partners * feat: add address holder fields to paper application (bloom-housing#3716) * feat: add collectAddress checkbox with subfields * test: update preference tests * fix: add minimum value validation for radius field * fix: make collect address not required * fix: expand collect address fields * fix: change fields order in PreferenceDrawer * feat: add address holder fields to application * fix: make added field optional * fix: display errors properly * feat: add address holder fields to application summary * feat: adjust padding for application summary * feat: add address holder fields to paper application * fix: use enum for address holder paper application fields * fix: remove redundant backend fields * fix: add correct labels, and values for extraData summary * fix: export geocoding values enum from backend * fix: display address as last extraData field * fix: remove placeholders from form * fix: set default values after listingDto fetched * style: adjust details multiselect question * feat: add geocoding preference label (bloom-housing#3765) * feat: add additional fields info to add listing preferences * feat: add additional fields column to table * refactor: reuse additional field tag * refactor: change base tag style * fix: revert onClose drawer function * fix: add geocoding fields to csv (bloom-housing#3778) * fix: update seeds button (bloom-housing#3793) * fix: add translations for geocoding (bloom-housing#3784) * fix: add translations for geocoding * fix: capitalize translation for qualifying address in vi.json * fix: provides additional fields info text overflows (bloom-housing#3809) * fix: provides additional fields info text overflows * fix: check if length of links greater than 0 * refactor: remove console.log * fix: add links to preference description (bloom-housing#3813) * fix: seeds button layout fixes for Partners Application sidebar (bloom-housing#3789) * feat: geocoding preference set up fixed layers (bloom-housing#3808) * feat: add geocoding map layers to multiselect option * fix: remove link from select description * fix: default value for mapLayerId * fix: add decorators for mapLayers dto's and entities * fix: use smaller font for mapLayer select helper text * fix: test fixes * fix: add map layer geocoding checks (bloom-housing#3825) * fix: add map layer geocoding checks * fix: review comment fix --------- Co-authored-by: Krzysztof Zięcina <kziecina@airnauts.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> Co-authored-by: cade-exygy <131277283+cade-exygy@users.noreply.github.com> Co-authored-by: ColinBuyck <53269332+ColinBuyck@users.noreply.github.com> Co-authored-by: Jared White <jared@jaredwhite.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Issue Overview
This PR addresses #3672
Description
Adds verification step for preferences that requires address verification. So the one that has validationMethod specified (so the one from geocoding pipeline)
How Can This Be Tested/Reviewed?
All checkbox / radio questions in application that are not in preferences step should NOT be affected by this change. After populating database, without changes in settings => options it should also work the same as before.
in /settings => options you can set
Do you want to collect address information?true and fill other options (doesn't really matter how for this change).Then after checking a preference field that has address it should verify it after click
next.Try to check different multi checks variants (like first and last, first - middle - last, 2nd with address checked and then second last without address checked etc.).
Checklist:
yarn generate:clientand/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.