-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add geocoding preference label #3765
Conversation
✅ Deploy Preview for bloom-demo-public ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There's a letter-spacing override applied to the seeds Tags in partners that we don't want to see on the tags in the preference table. At the moment on this PR there is too much letter spacing. We can make a new class for the letter-spacing override and apply it to the other tags so that this one can stay default :) |
* feat: add additional fields info to add listing preferences * feat: add additional fields column to table * refactor: reuse additional field tag * refactor: change base tag style * fix: revert onClose drawer function
* feat: seeds button uptake (bloom-housing#3677) * fix: validate radius geocoding preferences (bloom-housing#3718) * fix: validate radius geocoding preferences * fix: move to more generic * fix: add test * fix: one more test * fix: change to true/false * feat: add address verification for preferences step (bloom-housing#3715) * feat: add collectAddress checkbox with subfields * test: update preference tests * fix: add minimum value validation for radius field * fix: make collect address not required * fix: expand collect address fields * fix: change fields order in PreferenceDrawer * feat: add address holder fields to application * fix: make added field optional * fix: display errors properly * feat: add address holder fields to application summary * feat: add address verification for preferences step * feat: adjust padding for application summary * fix: move address holder name and relationship fields to extraData * fix: remove redundant backend address holder fields * fix: use enum for address holder fields * fix: add alternate address form component * fix: remove redundant fields from new address form * fix: verify preferences address when collectAddress true * fix: block going back on address verification add string to translation * fix: use onClick to block address Verification back button * fix: update dependencies for backend (bloom-housing#3694) * feat: core changes for application style alignment (bloom-housing#3662) * test: fix cypress lat long error (bloom-housing#3746) * fix: padding issue on address verify (bloom-housing#3745) * feat: add show mandated accounts flag (bloom-housing#3773) * feat: mA-3752 feat: add SHOW_MANDATED_ACCOUNTS flag * fix: add feature flag to bloom public next config * fix: remove flag from partners * feat: add address holder fields to paper application (bloom-housing#3716) * feat: add collectAddress checkbox with subfields * test: update preference tests * fix: add minimum value validation for radius field * fix: make collect address not required * fix: expand collect address fields * fix: change fields order in PreferenceDrawer * feat: add address holder fields to application * fix: make added field optional * fix: display errors properly * feat: add address holder fields to application summary * feat: adjust padding for application summary * feat: add address holder fields to paper application * fix: use enum for address holder paper application fields * fix: remove redundant backend fields * fix: add correct labels, and values for extraData summary * fix: export geocoding values enum from backend * fix: display address as last extraData field * fix: remove placeholders from form * fix: set default values after listingDto fetched * style: adjust details multiselect question * feat: add geocoding preference label (bloom-housing#3765) * feat: add additional fields info to add listing preferences * feat: add additional fields column to table * refactor: reuse additional field tag * refactor: change base tag style * fix: revert onClose drawer function * fix: add geocoding fields to csv (bloom-housing#3778) * fix: update seeds button (bloom-housing#3793) * fix: add translations for geocoding (bloom-housing#3784) * fix: add translations for geocoding * fix: capitalize translation for qualifying address in vi.json * fix: provides additional fields info text overflows (bloom-housing#3809) * fix: provides additional fields info text overflows * fix: check if length of links greater than 0 * refactor: remove console.log * fix: add links to preference description (bloom-housing#3813) * fix: seeds button layout fixes for Partners Application sidebar (bloom-housing#3789) * feat: geocoding preference set up fixed layers (bloom-housing#3808) * feat: add geocoding map layers to multiselect option * fix: remove link from select description * fix: default value for mapLayerId * fix: add decorators for mapLayers dto's and entities * fix: use smaller font for mapLayer select helper text * fix: test fixes * fix: add map layer geocoding checks (bloom-housing#3825) * fix: add map layer geocoding checks * fix: review comment fix --------- Co-authored-by: Krzysztof Zięcina <kziecina@airnauts.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> Co-authored-by: cade-exygy <131277283+cade-exygy@users.noreply.github.com> Co-authored-by: ColinBuyck <53269332+ColinBuyck@users.noreply.github.com> Co-authored-by: Jared White <jared@jaredwhite.com>
Pull Request Template
Issue Overview
This PR addresses #3690
Description
Adds tag with information if we have additional fields. In reality it will check if
collectAddress
is true.How Can This Be Tested/Reviewed?
On partners page go to
add/edit
listing.Housing Preferences
table should have additional column.Same with table after click
add preference
,edit preference
.In
select preferences
there will be tag below preference, and additional text near option after clickpreview
.Make sure that
programs
section is not affected by that change.Checklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.