Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add links to preference description #3813

Merged
merged 1 commit into from
Jan 16, 2024
Merged

fix: add links to preference description #3813

merged 1 commit into from
Jan 16, 2024

Conversation

KrissDrawing
Copy link
Collaborator

Pull Request Template

Issue Overview

This PR addresses #3799

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Display preference link in application process. Even though it seem that we can only add one link for preference i used map to display whole array of links (as it was implemented like this in other place: public listing view -> Housing Preferences).

How Can This Be Tested/Reviewed?

fill application with preferences that have a link. On preferences step it will display link below title and description (if present)

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@KrissDrawing KrissDrawing added the 1 review needed Requires 1 more review before ready to merge label Jan 15, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 15, 2024 •
edited
Loading

✅ Deploy Preview for bloom-demo-public ready!

Name Link
🔨 Latest commit 4ee9836
🔍 Latest deploy log https://app.netlify.com/sites/bloom-demo-public/deploys/65a573b5ca7b8c00088197b7
😎 Deploy Preview https://deploy-preview-3813--bloom-demo-public.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 15, 2024

✅ Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 4ee9836
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/65a573b529e63400085d6879
😎 Deploy Preview https://deploy-preview-3813--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ludtkemorgan
ludtkemorgan approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ludtkemorgan ludtkemorgan added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Jan 16, 2024
@KrissDrawing KrissDrawing merged commit af18a9b into main Jan 16, 2024
24 checks passed
@KrissDrawing KrissDrawing deleted the 3799/Surface-URL-in-preferences-on-application branch January 16, 2024 16:48
ludtkemorgan pushed a commit to housingbayarea/bloom that referenced this pull request Jan 23, 2024
@KrissDrawing @ludtkemorgan
fix: add links to preference description (bloom-housing#3813)
7797bb8
@ludtkemorgan ludtkemorgan mentioned this pull request Jan 23, 2024
Merged
ludtkemorgan added a commit to housingbayarea/bloom that referenced this pull request Jan 25, 2024
@ludtkemorgan @KrissDrawing
@emilyjablonski @cade-exygy @ColinBuyck @jaredcwhite
Release: 2024-01-23 (#658)
65d949d 
* feat: seeds button uptake (bloom-housing#3677)

* fix: validate radius geocoding preferences (bloom-housing#3718)

* fix: validate radius geocoding preferences

* fix: move to more generic

* fix: add test

* fix: one more test

* fix: change to true/false

* feat: add address verification for preferences step (bloom-housing#3715)

* feat: add collectAddress checkbox with subfields

* test: update preference tests

* fix: add minimum value validation for radius field

* fix: make collect address not required

* fix: expand collect address fields

* fix: change fields order in PreferenceDrawer

* feat: add address holder fields to application

* fix: make added field optional

* fix: display errors properly

* feat: add address holder fields to application summary

* feat: add address verification for preferences step

* feat: adjust padding for application summary

* fix: move address holder name and relationship fields to extraData

* fix: remove redundant backend address holder fields

* fix: use enum for address holder fields

* fix: add alternate address form component

* fix: remove redundant fields from new address form

* fix: verify preferences address when collectAddress true

* fix: block going back on address verification

add string to translation

* fix: use onClick to block address Verification back button

* fix: update dependencies for backend (bloom-housing#3694)

* feat: core changes for application style alignment (bloom-housing#3662)

* test: fix cypress lat long error (bloom-housing#3746)

* fix: padding issue on address verify (bloom-housing#3745)

* feat: add show mandated accounts flag (bloom-housing#3773)

* feat: mA-3752 feat: add SHOW_MANDATED_ACCOUNTS flag

* fix: add feature flag to bloom public next config

* fix: remove flag from partners

* feat: add address holder fields to paper application (bloom-housing#3716)

* feat: add collectAddress checkbox with subfields

* test: update preference tests

* fix: add minimum value validation for radius field

* fix: make collect address not required

* fix: expand collect address fields

* fix: change fields order in PreferenceDrawer

* feat: add address holder fields to application

* fix: make added field optional

* fix: display errors properly

* feat: add address holder fields to application summary

* feat: adjust padding for application summary

* feat: add address holder fields to paper application

* fix: use enum for address holder paper application fields

* fix: remove redundant backend fields

* fix: add correct labels, and values for extraData summary

* fix: export geocoding values enum from backend

* fix: display address as last extraData field

* fix: remove placeholders from form

* fix: set default values after listingDto fetched

* style: adjust details multiselect question

* feat: add geocoding preference label (bloom-housing#3765)

* feat: add additional fields info to add listing preferences

* feat: add additional fields column to table

* refactor: reuse additional field tag

* refactor: change base tag style

* fix: revert onClose drawer function

* fix: add geocoding fields to csv (bloom-housing#3778)

* fix: update seeds button (bloom-housing#3793)

* fix: add translations for geocoding (bloom-housing#3784)

* fix: add translations for geocoding

* fix: capitalize translation for qualifying address in vi.json

* fix: provides additional fields info text overflows (bloom-housing#3809)

* fix: provides additional fields info text overflows

* fix: check if length of links greater than 0

* refactor: remove console.log

* fix: add links to preference description (bloom-housing#3813)

* fix: seeds button layout fixes for Partners Application sidebar (bloom-housing#3789)

* feat: geocoding preference set up fixed layers (bloom-housing#3808)

* feat: add geocoding map layers to multiselect option

* fix: remove link from select description

* fix: default value for mapLayerId

* fix: add decorators for mapLayers dto's and entities

* fix: use smaller font for mapLayer select helper text

* fix: test fixes

* fix: add map layer geocoding checks (bloom-housing#3825)

* fix: add map layer geocoding checks

* fix: review comment fix

---------

Co-authored-by: Krzysztof Zięcina <kziecina@airnauts.com>
Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Co-authored-by: cade-exygy <131277283+cade-exygy@users.noreply.github.com>
Co-authored-by: ColinBuyck <53269332+ColinBuyck@users.noreply.github.com>
Co-authored-by: Jared White <jared@jaredwhite.com>
@ludtkemorgan ludtkemorgan mentioned this pull request Jan 30, 2024
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludtkemorgan ludtkemorgan ludtkemorgan approved these changes

Assignees
No one assigned
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KrissDrawing @ludtkemorgan