Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developers SBAT check contract code existence in Proxy contract #909

Closed
asaj opened this issue Sep 11, 2019 · 0 comments · Fixed by #1003, #1152 or #1289
Closed

Developers SBAT check contract code existence in Proxy contract #909

asaj opened this issue Sep 11, 2019 · 0 comments · Fixed by #1003, #1152 or #1289
Assignees
@aaitor
Labels
good first issue Good for newcomers protocol All issues relating to protocol packages

Comments

@asaj
Copy link
Contributor

asaj commented Sep 11, 2019

Expected Behavior

Use EXTCODESIZE to check contract existence before delegatecall in Proxy.sol

Current Behavior

No check
@asaj asaj added the protocol All issues relating to protocol packages label Sep 11, 2019
@asaj asaj added the good first issue Good for newcomers label Sep 11, 2019
@r00ted199 r00ted199 mentioned this issue Sep 15, 2019
Merged
@aaitor aaitor self-assigned this Sep 15, 2019
@aaitor aaitor mentioned this issue Oct 1, 2019
Merged
ashishb pushed a commit that referenced this issue Oct 7, 2019
@aaitor @ashishb
Feature #909 proxy delegatecall (#1152)
78afc93
asaj added a commit that referenced this issue Oct 8, 2019
@asaj
Revert "Feature #909 proxy delegatecall (#1152)"
b491453 
This reverts commit 78afc93.
asaj added a commit that referenced this issue Oct 8, 2019
@asaj
Revert "Feature #909 proxy delegatecall (#1152)" (#1241)
d05e4c5 
This reverts commit 78afc93.
aaronmgdr added a commit that referenced this issue Oct 8, 2019
@aaronmgdr
Merge branch 'master' into aaronmgdr/oct-bits
f059a61 
* master: (35 commits)
  [Wallet] Fix top of emojis cut off in the activity feed (#1243)
  Adding a contract to store minimum required client version (#1081)
  Revert "Feature #909 proxy delegatecall (#1152)" (#1241)
  Use ContractKit to get addresses for Blockchain API (#1175)
  Feature #909 proxy delegatecall (#1152)
  Fix Faucet done message (#1217)
  Updated SETUP.md with new yarn process (#1224)
  Adding `increaseAllowance` and `decreaseAllowance` methods (#1196)
  extracting function signatures (#1061)
  Fix integration hardcode (#1208)
  Fixing flaky governance test (#1155)
  Restore CI branch (#1223)
  [wallet] e2e back to green (#1210)
  [Wallet] Implement new import wallet flow designs (#1209)
  [Wallet] Fix disable conditions for butons on Enter Invite screen (#1214)
  [protocol] Rename infrastructureFraction to proposerFraction (#1174)
  [ck] Proper promise treatment to avoid UnhandledPromises (#1219)
  [ck] Transform StableToken parameters from fixidity format (#1218)
  [wallet]Store encrypted local signing key (#1188)
  2019-10-03 alfajores deployment (#1200)
  ...
@aaitor aaitor mentioned this issue Oct 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaitor aaitor

Labels
good first issue Good for newcomers protocol All issues relating to protocol packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/909 proxy delegatecall
Feature #909 proxy delegatecall
Feature/909 proxy delegatecall
2 participants
@aaitor @asaj