Adding a contract to store minimum required client version #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-chrzan
reviewed
Sep 23, 2019
Codecov Report
@@ Coverage Diff @@
## master #1081 +/- ##
==========================================
+ Coverage 66.47% 66.59% +0.11%
==========================================
Files 262 257 -5
Lines 7648 7394 -254
Branches 509 430 -79
==========================================
- Hits 5084 4924 -160
+ Misses 2462 2375 -87
+ Partials 102 95 -7
Continue to review full report at Codecov.
|
m-chrzan
reviewed
Sep 26, 2019
packages/protocol/contracts/governance/BlockchainParameters.sol
Outdated
Show resolved
Hide resolved
packages/protocol/contracts/governance/BlockchainParameters.sol
Outdated
Show resolved
Hide resolved
packages/protocol/contracts/governance/BlockchainParameters.sol
Outdated
Show resolved
Hide resolved
packages/protocol/contracts/governance/BlockchainParameters.sol
Outdated
Show resolved
Hide resolved
asaj
reviewed
Oct 2, 2019
packages/protocol/contracts/governance/BlockchainParameters.sol
Outdated
Show resolved
Hide resolved
|
I renamed the migrations because they are the ones that have to run last. |
|
Rather than rename it to 51, can we keep the sequential naming? |
asaj
approved these changes
Oct 7, 2019
| * @dev For example if the version is 1.9.2, 1 is the major version, 9 is minor, | ||
| * and 2 is the patch level. | ||
| */ | ||
| function setMinimumClientVersion(uint256 major, uint256 minor, uint256 patch) public onlyOwner { |
There was a problem hiding this comment.
Should this be external rather than public?
There was a problem hiding this comment.
I call it from the initializer, that's why it is public...
packages/protocol/contracts/governance/BlockchainParameters.sol
Outdated
Show resolved
Hide resolved
aaronmgdr
added a commit
that referenced
this pull request
Oct 8, 2019
* master: (35 commits) [Wallet] Fix top of emojis cut off in the activity feed (#1243) Adding a contract to store minimum required client version (#1081) Revert "Feature #909 proxy delegatecall (#1152)" (#1241) Use ContractKit to get addresses for Blockchain API (#1175) Feature #909 proxy delegatecall (#1152) Fix Faucet done message (#1217) Updated SETUP.md with new yarn process (#1224) Adding `increaseAllowance` and `decreaseAllowance` methods (#1196) extracting function signatures (#1061) Fix integration hardcode (#1208) Fixing flaky governance test (#1155) Restore CI branch (#1223) [wallet] e2e back to green (#1210) [Wallet] Implement new import wallet flow designs (#1209) [Wallet] Fix disable conditions for butons on Enter Invite screen (#1214) [protocol] Rename infrastructureFraction to proposerFraction (#1174) [ck] Proper promise treatment to avoid UnhandledPromises (#1219) [ck] Transform StableToken parameters from fixidity format (#1218) [wallet]Store encrypted local signing key (#1188) 2019-10-03 alfajores deployment (#1200) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a smart contract where the variables can be changed using governance. As a first variable, we have the minimum client version. In celo-blockchain PR, the client will check this variable and will exit if the required version on the blockchain is higher than current version.
Tested
There is a unit test for the contract, not sure where to add a test where geth exits.
Other changes
Changed migration numbering.
Related issues
Backwards compatibility