[Wallet] Implement new import wallet flow designs #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Write import saga test Cleanup jest mocks for ZeroSync
jmrossy
requested review from
jeanregisser,
ashishb,
martinvol,
cmcewen and
annakaz
Codecov Report
@@ Coverage Diff @@
## master #1209 +/- ##
==========================================
+ Coverage 66.09% 66.45% +0.36%
==========================================
Files 261 262 +1
Lines 7618 7647 +29
Branches 440 440
==========================================
+ Hits 5035 5082 +47
+ Misses 2487 2466 -21
- Partials 96 99 +3
Continue to review full report at Codecov.
|
jeanregisser
approved these changes
Oct 7, 2019
|
|
||
| describe('Import wallet saga', () => { | ||
| it('imports a valid phrase', async () => { | ||
| // @ts-ignore |
There was a problem hiding this comment.
It seems like a bug with expectSaga's typings for saga parameters
aaronmgdr
added a commit
that referenced
this pull request
Oct 8, 2019
* master: (35 commits) [Wallet] Fix top of emojis cut off in the activity feed (#1243) Adding a contract to store minimum required client version (#1081) Revert "Feature #909 proxy delegatecall (#1152)" (#1241) Use ContractKit to get addresses for Blockchain API (#1175) Feature #909 proxy delegatecall (#1152) Fix Faucet done message (#1217) Updated SETUP.md with new yarn process (#1224) Adding `increaseAllowance` and `decreaseAllowance` methods (#1196) extracting function signatures (#1061) Fix integration hardcode (#1208) Fixing flaky governance test (#1155) Restore CI branch (#1223) [wallet] e2e back to green (#1210) [Wallet] Implement new import wallet flow designs (#1209) [Wallet] Fix disable conditions for butons on Enter Invite screen (#1214) [protocol] Rename infrastructureFraction to proposerFraction (#1174) [ck] Proper promise treatment to avoid UnhandledPromises (#1219) [ck] Transform StableToken parameters from fixidity format (#1218) [wallet]Store encrypted local signing key (#1188) 2019-10-03 alfajores deployment (#1200) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tested
Ran through import flow with valid wallet
Ran through import flow with invalid wallet
Ran through import flow with empty wallet
Related issues
Backwards compatibility
Yes