Feature #909 proxy delegatecall #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bringing last changes
Bringing master
Update CLI docs (#1056)
bringing celo:master
…00ted42/celo-monorepo into feature/909-proxy-delegatecall
Bringing celo-monorepo:master
…00ted42/celo-monorepo into feature/909-proxy-delegatecall
bringing master
…00ted42/celo-monorepo into feature/909-proxy-delegatecall
Codecov Report
@@ Coverage Diff @@
## master #1152 +/- ##
=======================================
Coverage 66.47% 66.47%
=======================================
Files 262 262
Lines 7648 7648
Branches 441 509 +68
=======================================
Hits 5084 5084
+ Misses 2464 2462 -2
- Partials 100 102 +2
Continue to review full report at Codecov.
|
asaj
approved these changes
Oct 7, 2019
aaronmgdr
added a commit
that referenced
this pull request
Oct 8, 2019
* master: (35 commits) [Wallet] Fix top of emojis cut off in the activity feed (#1243) Adding a contract to store minimum required client version (#1081) Revert "Feature #909 proxy delegatecall (#1152)" (#1241) Use ContractKit to get addresses for Blockchain API (#1175) Feature #909 proxy delegatecall (#1152) Fix Faucet done message (#1217) Updated SETUP.md with new yarn process (#1224) Adding `increaseAllowance` and `decreaseAllowance` methods (#1196) extracting function signatures (#1061) Fix integration hardcode (#1208) Fixing flaky governance test (#1155) Restore CI branch (#1223) [wallet] e2e back to green (#1210) [Wallet] Implement new import wallet flow designs (#1209) [Wallet] Fix disable conditions for butons on Enter Invite screen (#1214) [protocol] Rename infrastructureFraction to proposerFraction (#1174) [ck] Proper promise treatment to avoid UnhandledPromises (#1219) [ck] Transform StableToken parameters from fixidity format (#1218) [wallet]Store encrypted local signing key (#1188) 2019-10-03 alfajores deployment (#1200) ...
ashishb
added a commit
that referenced
this pull request
Oct 8, 2019
Earlier, it would take the first page of commits from the GitHub's PR commits page. Now, it follows the next link url to fetch all commits. Tested with ``` CIRCLE_PROJECT_USERNAME=celo-org CIRCLE_PROJECT_REPONAME=celo-monorepo CIRCLE_PULL_REQUEST="#1152" ./scripts/ci_check_if_test_should_run_v2.sh $PWD/packages/protocol ``` Earlier, this would check (First) 30 commits. Now, it checks all 46 commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The intention of this PR is to validate if an address is a contract or EOA before calling the
delegatecallTested
Test added in proxy.ts calling _setAndInitializeImplementation with a EOA address.
Other changes
The isContract function shouldn't be called from a constructor. Calling this function from a constructor will return 0 independently if the address given as parameter is a contract or EOA
Related issues
Fixes #909 , #910, #911
Backwards compatibility
Brief explanation of why these changes are/are not backwards compatible.