Enable floating promises check everywhere (fix issues) #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcewen
reviewed
Sep 26, 2019
| @@ -22,8 +21,8 @@ export class AddressRegistry { | |||
| async addressFor(contract: CeloContract): Promise<Address> { | |||
| if (!this.cache.has(contract)) { | |||
| debug('Fetching address from Registry for %s', contract) | |||
| const hash = Web3.utils.soliditySha3({ type: 'string', value: contract }) | |||
| const address = await this.registry.methods.getAddressFor(hash).call() | |||
| // const hash = Web3.utils.soliditySha3({ type: 'string', value: contract }) | |||
There was a problem hiding this comment.
Thanks for catching this.. my commit included some other work that should not be here.
Now that's fixed
Removes floagint promises on all packages that inherit from tslint parent config. Only in mobile package, the config is overrided as a "warning". Also: updates tslint & tslint rule set to their last versions.
mcortesi
force-pushed
the
mc/floating-promises
branch
from
f348708
to
a366e8f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1115 +/- ##
=======================================
Coverage 66.59% 66.59%
=======================================
Files 257 257
Lines 7394 7394
Branches 494 430 -64
=======================================
Hits 4924 4924
- Misses 2373 2375 +2
+ Partials 97 95 -2
Continue to review full report at Codecov.
|
cmcewen
approved these changes
Sep 26, 2019
aaronmgdr
added a commit
that referenced
this pull request
Oct 1, 2019
* master: (31 commits) Upgrade to Node 10 (#1148) [faucet] Add custom metrics (#1143) Add IdentityMetadata to Contractkit (#1126) [Wallet] Local currency v1.1 (#1137) Add attestation-service deploy (#1128) [Wallet] A few docs and build cleanup (#1138) [CircleCI]Add comment on how to fix lint checks (#1134) 2019-09-30 integration deployment (#1149) Update web3 provider to new integration url (#1151) [celotool]Add fast mode to celotool invite (#1135) Revert "Feature/909 proxy delegatecall" (#1146) Use contractkit in notification service (#1118) Feature/909 proxy delegatecall (#1003) integration deployment for 2019-09-29 (#1139) Add instructions for npm publication to tag commit (#1117) Client Logs Data Flow script update (#1055) Deploying latest proxy code in genesis (#1122) Enable floating promises check everywhere (fix issues) (#1115) [cli] Solution for build error contractkit on Linux 19.04 distro (#960) [Wallet] Merge back changes made for mx pilot (#1113) ... # Conflicts: # yarn.lock
aaronmgdr
added a commit
that referenced
this pull request
Oct 1, 2019
* master: (35 commits) [Wallet] Network fee in transaction feed (#1145) New About Page Cover (#905) Upgrade to Node 10 (#1148) [faucet] Add custom metrics (#1143) Add IdentityMetadata to Contractkit (#1126) [Wallet] Local currency v1.1 (#1137) Add attestation-service deploy (#1128) [Wallet] A few docs and build cleanup (#1138) [CircleCI]Add comment on how to fix lint checks (#1134) 2019-09-30 integration deployment (#1149) Update web3 provider to new integration url (#1151) [celotool]Add fast mode to celotool invite (#1135) Revert "Feature/909 proxy delegatecall" (#1146) Use contractkit in notification service (#1118) Feature/909 proxy delegatecall (#1003) integration deployment for 2019-09-29 (#1139) Add instructions for npm publication to tag commit (#1117) Client Logs Data Flow script update (#1055) Deploying latest proxy code in genesis (#1122) Enable floating promises check everywhere (fix issues) (#1115) ... # Conflicts: # packages/web/src/about/About.tsx # packages/web/src/about/images/index.ts # packages/web/static/locales/en/about.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes floagint promises on all packages that inherit from tslint
parent config.
Only in
mobilepackage, the config is overrided as a "warning".Also: updates tslint & tslint rule set to their last versions.
Tested
yarn lintOther changes
Upgrade tslint
Related issues