Use contractkit in notification service #1118

annakaz · 2019-09-26T22:07:51Z

Description

Use contractkit in notification service to query the exchange rate. This replaces walletkit is being deprecated

Tested

Locally with yarn start:local

Issues

Addresses #225

Other changes

Use contractkit to get token addresses instead of hardcoding.
Update to readme with instructions to get the IP address of a web3 provider

codecov · 2019-09-27T02:23:59Z

Codecov Report

Merging #1118 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1118   +/-   ##
=======================================
  Coverage   66.59%   66.59%           
=======================================
  Files         257      257           
  Lines        7394     7394           
  Branches      430      430           
=======================================
  Hits         4924     4924           
  Misses       2375     2375           
  Partials       95       95

Flag	Coverage Δ
#mobile	`66.59% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecc3d1b...523eadd. Read the comment docs.

cmcewen · 2019-09-27T02:25:55Z

@annakaz @jmrossy had to make some changes and publish some things to get this working - please take a look

jmrossy

See comment below.
Another possible issue, why does this add a yarn.lock in the notification service package?

jmrossy · 2019-09-27T13:21:50Z

packages/notification-service/app.integration.yaml

+service: integration
+instance_class: F4
+automatic_scaling:


I tried this when I first created the service and found that automatic scaling would always eventually kill the service since it wasn't receiving any inbound network requests. Seems like app engine is kind of hard wired to run web servers and not well suited to other kinds of apps...
It's possible this issue has since been fixed but please test that before changing this.
Also worth it to double check that we have alerting for when the service goes down

It seems like the version that I deployed has been running for a while - do you remember when it would get killed? https://console.cloud.google.com/appengine/instances?project=celo-org-mobile&instancesTablesize=20&versionId=20190926t191656

It also looks like we have an uptime check https://app.google.stackdriver.com/uptime/efe3d6cc3966ae961e398dd5b73d2094?project=celo-testnet

Does this seem okay to you then?

Why use automatic scaling if min and max instances are both set to 1?

cmcewen · 2019-09-27T17:27:52Z

@jmrossy the yarn.lock is actually a symlink to the root one. @nityas figured out to add it to the website which we have been using for a while - it means we actually pin deps to the right version 😄

annakaz · 2019-09-27T17:48:48Z

Can't approve through github since it's my own PR

Approving (assuming we test that app engine does not kill the service after deploying this)

…orepo into annakaz/to-contractkit

annakaz · 2019-09-27T20:24:16Z

This may have caused the stackdriver alert with logs disappearing

If we no longer expect logs on standard env, can you update the alert policy here?
https://app.google.stackdriver.com/policies/edit/14455258600176610656?project=celo-testnet

Service handed off

…orepo into annakaz/to-contractkit

mcortesi · 2019-10-01T16:19:42Z

yarn.lock

+    lodash "^4.17.14"
+    web3-utils "1.0.0-beta.37"
+
+"@celo/utils@^0.0.6-beta5":


@cmcewen @annakaz
It's merged, but check this. yarn.lock now has 2 version of contractkit and utils... when should be none.

very strange

* master: (31 commits) Upgrade to Node 10 (#1148) [faucet] Add custom metrics (#1143) Add IdentityMetadata to Contractkit (#1126) [Wallet] Local currency v1.1 (#1137) Add attestation-service deploy (#1128) [Wallet] A few docs and build cleanup (#1138) [CircleCI]Add comment on how to fix lint checks (#1134) 2019-09-30 integration deployment (#1149) Update web3 provider to new integration url (#1151) [celotool]Add fast mode to celotool invite (#1135) Revert "Feature/909 proxy delegatecall" (#1146) Use contractkit in notification service (#1118) Feature/909 proxy delegatecall (#1003) integration deployment for 2019-09-29 (#1139) Add instructions for npm publication to tag commit (#1117) Client Logs Data Flow script update (#1055) Deploying latest proxy code in genesis (#1122) Enable floating promises check everywhere (fix issues) (#1115) [cli] Solution for build error contractkit on Linux 19.04 distro (#960) [Wallet] Merge back changes made for mx pilot (#1113) ... # Conflicts: # yarn.lock

* master: (35 commits) [Wallet] Network fee in transaction feed (#1145) New About Page Cover (#905) Upgrade to Node 10 (#1148) [faucet] Add custom metrics (#1143) Add IdentityMetadata to Contractkit (#1126) [Wallet] Local currency v1.1 (#1137) Add attestation-service deploy (#1128) [Wallet] A few docs and build cleanup (#1138) [CircleCI]Add comment on how to fix lint checks (#1134) 2019-09-30 integration deployment (#1149) Update web3 provider to new integration url (#1151) [celotool]Add fast mode to celotool invite (#1135) Revert "Feature/909 proxy delegatecall" (#1146) Use contractkit in notification service (#1118) Feature/909 proxy delegatecall (#1003) integration deployment for 2019-09-29 (#1139) Add instructions for npm publication to tag commit (#1117) Client Logs Data Flow script update (#1055) Deploying latest proxy code in genesis (#1122) Enable floating promises check everywhere (fix issues) (#1115) ... # Conflicts: # packages/web/src/about/About.tsx # packages/web/src/about/images/index.ts # packages/web/static/locales/en/about.json

Switch to contractkit

8cdc4c9

annakaz requested review from cmcewen and jmrossy as code owners September 26, 2019 22:07

annakaz assigned cmcewen Sep 26, 2019

Fix install

f01efb0

cmcewen added the automerge Have PR merge automatically when checks pass label Sep 27, 2019

cmcewen approved these changes Sep 27, 2019

View reviewed changes

cmcewen removed the automerge Have PR merge automatically when checks pass label Sep 27, 2019

cmcewen added 2 commits September 26, 2019 19:08

Try publishing to get notification service to work

6811c07

Missing dep

497e378

cmcewen assigned annakaz and jmrossy Sep 27, 2019

jmrossy previously requested changes Sep 27, 2019

View reviewed changes

jmrossy removed their assignment Sep 27, 2019

annakaz removed their assignment Sep 27, 2019

Make a real symlink

d0a7529

annakaz and others added 3 commits September 27, 2019 11:14

Merge branch 'master' into annakaz/to-contractkit

aa8febc

Update dappkit deps

a736220

Merge branch 'annakaz/to-contractkit' of github.com:celo-org/celo-mon…

c006051

…orepo into annakaz/to-contractkit

annakaz and others added 3 commits September 27, 2019 15:09

Only get contract addresses with contractkit

eb85e9e

Update staging web3 provider

3008be4

Pin utils version

0e7dea4

annakaz requested review from ashishb and yerdua as code owners September 27, 2019 22:43

Add reference to attestation service

dce622a

cmcewen and others added 2 commits September 29, 2019 21:42

Fix build

9d57b00

Merge branch 'master' into annakaz/to-contractkit

1f2178f

annakaz changed the title ~~Use contractkit instead of walletkit for exchange querying~~ Use contractkit in notification service Sep 30, 2019

annakaz and others added 3 commits September 30, 2019 12:10

Merge branch 'master' into annakaz/to-contractkit

b4e03b5

New utils package config

fda7c09

Merge branch 'annakaz/to-contractkit' of github.com:celo-org/celo-mon…

815c9a1

…orepo into annakaz/to-contractkit

annakaz requested review from aaronmgdr, asaj, m-chrzan, mcortesi and nambrot as code owners September 30, 2019 19:23

annakaz and others added 2 commits September 30, 2019 12:33

Update integration web3 provider url

753635d

Add test config

8308ac1

cmcewen approved these changes Sep 30, 2019

View reviewed changes

annakaz and others added 3 commits September 30, 2019 13:57

Remove empty string blockscout_api in jest setup:

84f8d10

Update notification service code owner

02e3e31

Merge branch 'master' into annakaz/to-contractkit

523eadd

annakaz added the automerge Have PR merge automatically when checks pass label Sep 30, 2019

annakaz assigned annakaz and unassigned cmcewen Sep 30, 2019

cmcewen merged commit d36c24f into master Sep 30, 2019

cmcewen deleted the annakaz/to-contractkit branch September 30, 2019 22:10

mcortesi reviewed Oct 1, 2019

View reviewed changes

annakaz restored the annakaz/to-contractkit branch October 16, 2019 18:34

annakaz deleted the annakaz/to-contractkit branch October 16, 2019 18:49

lili2311 mentioned this pull request Sep 18, 2024

[Snyk-dev] Fix for 9 vulnerabilities lili2311/lerna-celo-monorepo#547

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use contractkit in notification service #1118

Use contractkit in notification service #1118

annakaz commented Sep 26, 2019 •

edited

Loading

codecov bot commented Sep 27, 2019 •

edited

Loading

cmcewen commented Sep 27, 2019

jmrossy left a comment

jmrossy Sep 27, 2019

cmcewen Sep 27, 2019

annakaz Sep 27, 2019

cmcewen commented Sep 27, 2019

annakaz commented Sep 27, 2019

annakaz commented Sep 27, 2019

mcortesi Oct 1, 2019

cmcewen Oct 1, 2019

Use contractkit in notification service #1118

Use contractkit in notification service #1118

Conversation

annakaz commented Sep 26, 2019 • edited Loading

Description

Tested

Issues

Other changes

codecov bot commented Sep 27, 2019 • edited Loading

Codecov Report

cmcewen commented Sep 27, 2019

jmrossy left a comment

Choose a reason for hiding this comment

jmrossy Sep 27, 2019

Choose a reason for hiding this comment

cmcewen Sep 27, 2019

Choose a reason for hiding this comment

annakaz Sep 27, 2019

Choose a reason for hiding this comment

cmcewen commented Sep 27, 2019

annakaz commented Sep 27, 2019

annakaz commented Sep 27, 2019

mcortesi Oct 1, 2019

Choose a reason for hiding this comment

cmcewen Oct 1, 2019

Choose a reason for hiding this comment

annakaz commented Sep 26, 2019 •

edited

Loading

codecov bot commented Sep 27, 2019 •

edited

Loading