[cli] Solution for build error contractkit on Linux 19.04 distro #960
Conversation
diminator
changed the title
Codecov Report
@@ Coverage Diff @@
## master #960 +/- ##
=======================================
Coverage 66.59% 66.59%
=======================================
Files 257 257
Lines 7394 7394
Branches 494 494
=======================================
Hits 4924 4924
Misses 2373 2373
Partials 97 97
Continue to review full report at Codecov.
|
packages/cli/README.md
Outdated
| Make sure you do NOT overwrite any existing contracts, migrations or tests. | ||
|
|
||
| ```bash | ||
| > npm i -g truffle |
There was a problem hiding this comment.
this sounds weird...
why would you need to initialize truffle?
Do you have a more specific error log?
There was a problem hiding this comment.
node v8.16.1
Linux dimi-xps 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
`
> git clone git@github.com:celo-org/celo-monorepo.git
> yarn
> cd packages/protocol/
> yarn build
yarn run v1.17.3
$ ts-node ./scripts/build.ts && yarn build:ts
Compiling
Warning: Both truffle-config.js and truffle.js were found. Using truffle-config.js.
Compiling your contracts...
===========================
> Everything is up to date, there is nothing to compile.
{ Error: ENOENT: no such file or directory, open '/home/dimi/celo/celo-monorepo-test/packages/protocol/build/contracts/Proxy.json'
Observations:
- Truffle doesn't recognize the
contractsdirectory - Truffle is finding some
truffle-config.js(there's a few in thenode_modules, maybe somewhere else on my system)
There was a problem hiding this comment.
renaming protocol/truffle.js to protocol/truffle-config.js is a potential fix
There was a problem hiding this comment.
that sounds more reasonable.
Still is strange that none other has the same issue... are you using yarn or npm?
There was a problem hiding this comment.
> yarn
> cd packages/protocol/
> yarn build
There was a problem hiding this comment.
maybe you can test by adding an empty truffle-config.js and try building?
so you can see if your truffle is also having that config pref
There was a problem hiding this comment.
sorry a bit confused here
we started by saying that we need to do truffle init to make the repo build on linux. That's what i found strange. Surely the truffle-config.js is a result of running init, right?
There was a problem hiding this comment.
I understand the confusion. Forget about the truffle init solution.
When I do a vanilla yarn && yarn build on the repo I get the error. So without init.
Seems that truffle finds somewhere truffle-config.js it will prefer that one over the existing truffle.js. That seems to be the case for me.
There was a problem hiding this comment.
Not sure if it's an actual issue or just something on my local device due to previous projects using ganache
diminator
force-pushed
the
diminator/docs-cli-build-error
branch
from
3cc1310
to
73cbfdf
Compare
|
@mcortesi I reframed the error. Is this good to go? |
that would be too easy :) |
* master: (31 commits) Upgrade to Node 10 (#1148) [faucet] Add custom metrics (#1143) Add IdentityMetadata to Contractkit (#1126) [Wallet] Local currency v1.1 (#1137) Add attestation-service deploy (#1128) [Wallet] A few docs and build cleanup (#1138) [CircleCI]Add comment on how to fix lint checks (#1134) 2019-09-30 integration deployment (#1149) Update web3 provider to new integration url (#1151) [celotool]Add fast mode to celotool invite (#1135) Revert "Feature/909 proxy delegatecall" (#1146) Use contractkit in notification service (#1118) Feature/909 proxy delegatecall (#1003) integration deployment for 2019-09-29 (#1139) Add instructions for npm publication to tag commit (#1117) Client Logs Data Flow script update (#1055) Deploying latest proxy code in genesis (#1122) Enable floating promises check everywhere (fix issues) (#1115) [cli] Solution for build error contractkit on Linux 19.04 distro (#960) [Wallet] Merge back changes made for mx pilot (#1113) ... # Conflicts: # yarn.lock
Description
Solution to build error
cannot find module @celo/contractkitTested
Works on Linux 19.04 distro
Related issues
No issue was created