[faucet] Add custom metrics #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcortesi
force-pushed
the
mc/faucet/metrics
branch
from
132a4ff
to
dbf54d8
Compare
Log events based on execution result
mcortesi
force-pushed
the
mc/faucet/metrics
branch
from
dbf54d8
to
9bd89d5
Compare
Codecov Report
@@ Coverage Diff @@
## master #1143 +/- ##
==========================================
- Coverage 66.7% 66.59% -0.11%
==========================================
Files 259 257 -2
Lines 7454 7394 -60
Branches 432 494 +62
==========================================
- Hits 4972 4924 -48
+ Misses 2386 2373 -13
- Partials 96 97 +1
Continue to review full report at Codecov.
|
nambrot
approved these changes
Oct 1, 2019
| @@ -0,0 +1,52 @@ | |||
| import { Logging } from '@google-cloud/logging' | |||
There was a problem hiding this comment.
So of course we do not have any standardization so to speak, but I generally would prefer for us not to directly log to GCP. Instead, GCP already aggregates the logs for us from STDOUT/STDERR and deals with doing so in a performant manner, batch, etc.
It also avoids us having to configure the client below, give the appropriate labels like project/region, and many more useful information such as execution id, severity etc.
There was a problem hiding this comment.
In general, I agree. But this is different.
The reason I'm using this library is to create my own LogEntry for stackdriver.
See that I'm using:
- A different resource (fantasy function name on the metadata)
- structured log entry, not a string
See the screenshot of an actual log:
This allow to easily create new metric with metric labels using structured fields.
aaronmgdr
added a commit
that referenced
this pull request
Oct 1, 2019
* master: (31 commits) Upgrade to Node 10 (#1148) [faucet] Add custom metrics (#1143) Add IdentityMetadata to Contractkit (#1126) [Wallet] Local currency v1.1 (#1137) Add attestation-service deploy (#1128) [Wallet] A few docs and build cleanup (#1138) [CircleCI]Add comment on how to fix lint checks (#1134) 2019-09-30 integration deployment (#1149) Update web3 provider to new integration url (#1151) [celotool]Add fast mode to celotool invite (#1135) Revert "Feature/909 proxy delegatecall" (#1146) Use contractkit in notification service (#1118) Feature/909 proxy delegatecall (#1003) integration deployment for 2019-09-29 (#1139) Add instructions for npm publication to tag commit (#1117) Client Logs Data Flow script update (#1055) Deploying latest proxy code in genesis (#1122) Enable floating promises check everywhere (fix issues) (#1115) [cli] Solution for build error contractkit on Linux 19.04 distro (#960) [Wallet] Merge back changes made for mx pilot (#1113) ... # Conflicts: # yarn.lock
aaronmgdr
added a commit
that referenced
this pull request
Oct 1, 2019
* master: (35 commits) [Wallet] Network fee in transaction feed (#1145) New About Page Cover (#905) Upgrade to Node 10 (#1148) [faucet] Add custom metrics (#1143) Add IdentityMetadata to Contractkit (#1126) [Wallet] Local currency v1.1 (#1137) Add attestation-service deploy (#1128) [Wallet] A few docs and build cleanup (#1138) [CircleCI]Add comment on how to fix lint checks (#1134) 2019-09-30 integration deployment (#1149) Update web3 provider to new integration url (#1151) [celotool]Add fast mode to celotool invite (#1135) Revert "Feature/909 proxy delegatecall" (#1146) Use contractkit in notification service (#1118) Feature/909 proxy delegatecall (#1003) integration deployment for 2019-09-29 (#1139) Add instructions for npm publication to tag commit (#1117) Client Logs Data Flow script update (#1055) Deploying latest proxy code in genesis (#1122) Enable floating promises check everywhere (fix issues) (#1115) ... # Conflicts: # packages/web/src/about/About.tsx # packages/web/src/about/images/index.ts # packages/web/static/locales/en/about.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Log events based on execution result
Tested
Deploy and faucet. Then check logs
Other changes
Yarn lock updated a couple of things, don't know why. I've only added google cloudl ogging library
Related issues