feat: Expose tx_hash on BroadcastSuccess event #4561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcellorigotti
requested review from
dandanlen,
kylezs,
AlastairHolmes and
a team
as code owners
marcellorigotti
requested review from
jerryafr and
zoheb391
and removed request for
a team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4561 +/- ##
======================================
- Coverage 73% 72% -0%
======================================
Files 401 401
Lines 66210 66224 +14
Branches 66210 66224 +14
======================================
- Hits 48089 47986 -103
- Misses 15802 15914 +112
- Partials 2319 2324 +5 ☔ View full report in Codecov by Sentry. |
kylezs
reviewed
Feb 23, 2024
There was a problem hiding this comment.
Mostly naming related - seems like @dandanlen is chatting to you about this PR too, so will pause the review here :)
api/bin/chainflip-ingress-egress-tracker/src/witnessing/state_chain.rs
Outdated
Show resolved
Hide resolved
kylezs
reviewed
Feb 26, 2024
|
Get at least a review from product here too |
niklasnatter
approved these changes
Feb 27, 2024
It should be included for free there - but I'm not sure how you guys are getting and writing the data now with the redis addition |
|
I'll close this PR and start working on the ingress-egress-tracker on a new one |
syan095
added a commit
that referenced
this pull request
Feb 28, 2024
…ero-liquidity * origin/main: fix: disable try-state checks (#4576) chore: debug solana in CI 🐛 (#4580) refactor: pass tx_ref as an extrinsic parameter (#4579) fix: remove bounded balance check (#4575) Solana: update image to latest tag (#4574) feat: add boost lp account to bouncer and fund it on setup_swaps (#4552) feat: Expose tx_hash on BroadcastSuccess event (#4561) feat: Relative Slippage Limits (PRO-1207) (#4547) chore: disable localnet solana in CI ⏱️ (#4569) feat: store prewitnessed deposits with id (#4496) Feat: Scheduled Swaps Subscription (#4525) # Conflicts: # state-chain/pallets/cf-pools/src/tests.rs
syan095
added a commit
that referenced
this pull request
Feb 29, 2024
…utxo * origin/main: feat: expose command for broker fee withdrawal (#4581) Chore/fix arbitrum deployment (#4570) Added Range order pool price to the pool_price_v2 rpc call (#4548) fix: just check that the balance after is greater than before (#4587) chore: add origin to ccm failed (#4586) fix: runtime upgrade state check uses AllPalletsWithoutSystem (#4583) chore: add zellic audit to repo (#4585) fix: disable try-state checks (#4576) chore: debug solana in CI 🐛 (#4580) refactor: pass tx_ref as an extrinsic parameter (#4579) fix: remove bounded balance check (#4575) Solana: update image to latest tag (#4574) feat: add boost lp account to bouncer and fund it on setup_swaps (#4552) feat: Expose tx_hash on BroadcastSuccess event (#4561) feat: Relative Slippage Limits (PRO-1207) (#4547) chore: disable localnet solana in CI ⏱️ (#4569) feat: store prewitnessed deposits with id (#4496) Feat: Scheduled Swaps Subscription (#4525)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1195
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Updated transaction_succeeded and BroadcastSuccess Event to include the tx_ref which represent the transaction hash (or an equivalent way of identifying a transaction depending on the chain)
Breaking changes
This PR is breaking, both an extrinsic used in the engine and an event changed