feat: expose command for broker fee withdrawal #4581
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4581 +/- ##
=====================================
- Coverage 73% 72% -0%
=====================================
Files 401 401
Lines 66745 66794 +49
Branches 66745 66794 +49
=====================================
+ Hits 48415 48416 +1
- Misses 15982 16032 +50
+ Partials 2348 2346 -2 ☔ View full report in Codecov by Sentry. |
kylezs
changed the title
| clean_foreign_chain_address(asset.into(), &destination_address)?, | ||
| ) | ||
| .await | ||
| .map(|tx_hash| format!("{tx_hash:#x}"))?) |
There was a problem hiding this comment.
As discussed, better to return the hash here and rely on Serialize rather than converting to a string explicitly.
| })) | ||
| .await | ||
| .until_in_block() | ||
| .await |
There was a problem hiding this comment.
At this point we can also get the egress details, we should return these too.
api/lib/src/lib.rs
Outdated
| egress_amount: _, | ||
| egress_fee: _, | ||
| destination_address: _, |
There was a problem hiding this comment.
Why not return all of the information? All of this is interesting to the broker.
api/bin/chainflip-cli/src/main.rs
Outdated
| println!( | ||
| "Withdrawal request successfull submitted. Tx hash: {:#x}", | ||
| withdraw_details.tx_hash | ||
| ); | ||
| println!("Egress id: {:?}", withdraw_details.egress_id); |
There was a problem hiding this comment.
| println!( | |
| "Withdrawal request successfull submitted. Tx hash: {:#x}", | |
| withdraw_details.tx_hash | |
| ); | |
| println!("Egress id: {:?}", withdraw_details.egress_id); | |
| println!( | |
| "Withdrawal request successfully submitted: {}", | |
| withdraw_details | |
| ); |
(and implement Display for WithdrawalDetails.
api/lib/src/lib.rs
Outdated
| } else { | ||
| bail!("No WithdrawalRequested event was found"); | ||
| } | ||
| // Ok(tx_hash) |
|
I left the impl of Deserialize for EncodedAddress as unimplemented, is that ok? |
state-chain/chains/src/address.rs
Outdated
| where | ||
| D: serde::Deserializer<'de>, | ||
| { | ||
| unimplemented!() |
There was a problem hiding this comment.
I would rather we didn't have this, seems a bit dangerous.
The implementation is just clean_foreign_chain_address from the api crate, but refactoring and moving all this is beyond the scope of this PR.
I'll make the change and then we can merge.
|
Thanks @marcellorigotti |
…utxo * origin/main: feat: expose command for broker fee withdrawal (#4581) Chore/fix arbitrum deployment (#4570) Added Range order pool price to the pool_price_v2 rpc call (#4548) fix: just check that the balance after is greater than before (#4587) chore: add origin to ccm failed (#4586) fix: runtime upgrade state check uses AllPalletsWithoutSystem (#4583) chore: add zellic audit to repo (#4585) fix: disable try-state checks (#4576) chore: debug solana in CI 🐛 (#4580) refactor: pass tx_ref as an extrinsic parameter (#4579) fix: remove bounded balance check (#4575) Solana: update image to latest tag (#4574) feat: add boost lp account to bouncer and fund it on setup_swaps (#4552) feat: Expose tx_hash on BroadcastSuccess event (#4561) feat: Relative Slippage Limits (PRO-1207) (#4547) chore: disable localnet solana in CI ⏱️ (#4569) feat: store prewitnessed deposits with id (#4496) Feat: Scheduled Swaps Subscription (#4525)
…ero-liquidity * origin/main: feat: expose command for broker fee withdrawal (#4581) Chore/fix arbitrum deployment (#4570) Added Range order pool price to the pool_price_v2 rpc call (#4548) fix: just check that the balance after is greater than before (#4587) chore: add origin to ccm failed (#4586) fix: runtime upgrade state check uses AllPalletsWithoutSystem (#4583) chore: add zellic audit to repo (#4585) # Conflicts: # Cargo.lock
Pull Request
Closes: PRO-1219
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Expose command for broker fee withdrawal
Non-Breaking changes