Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add origin to ccm failed #4586

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

albert-llimos
Copy link
Contributor

@albert-llimos albert-llimos commented Feb 29, 2024

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

Add origin to ccmFailed event so it can be associated to a deposit channel.

@albert-llimos albert-llimos added the non-breaking Merging this PR will create a cherry-pick onto release label Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73%. Comparing base (e0c7b58) to head (b14f929).

Files Patch % Lines
state-chain/pallets/cf-swapping/src/lib.rs 50% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4586   +/-   ##
=====================================
- Coverage     73%     73%   -0%     
=====================================
  Files        401     401           
  Lines      66735   66738    +3     
  Branches   66735   66738    +3     
=====================================
  Hits       48416   48416           
- Misses     15974   15975    +1     
- Partials    2345    2347    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albert-llimos albert-llimos marked this pull request as ready for review February 29, 2024 11:44
@dandanlen dandanlen merged commit 3b1ba4e into main Feb 29, 2024
43 checks passed
@dandanlen dandanlen deleted the chore/add-origin-ccm-failed branch February 29, 2024 13:06
chainflip-bot pushed a commit that referenced this pull request Feb 29, 2024
syan095 added a commit that referenced this pull request Feb 29, 2024
…utxo

* origin/main:
  feat: expose command for broker fee withdrawal (#4581)
  Chore/fix arbitrum deployment (#4570)
  Added Range order pool price to the pool_price_v2 rpc call (#4548)
  fix: just check that the balance after is greater than before (#4587)
  chore: add origin to ccm failed (#4586)
  fix: runtime upgrade state check uses AllPalletsWithoutSystem (#4583)
  chore: add zellic audit to repo (#4585)
  fix: disable try-state checks (#4576)
  chore: debug solana in CI 🐛 (#4580)
  refactor: pass tx_ref as an extrinsic parameter (#4579)
  fix: remove bounded balance check (#4575)
  Solana: update image to latest tag (#4574)
  feat: add boost lp account to bouncer and fund it on setup_swaps (#4552)
  feat: Expose tx_hash on BroadcastSuccess event (#4561)
  feat: Relative Slippage Limits (PRO-1207) (#4547)
  chore: disable localnet solana in CI ⏱️ (#4569)
  feat: store prewitnessed deposits with id (#4496)
  Feat: Scheduled Swaps Subscription (#4525)
syan095 added a commit that referenced this pull request Feb 29, 2024
…ero-liquidity

* origin/main:
  feat: expose command for broker fee withdrawal (#4581)
  Chore/fix arbitrum deployment (#4570)
  Added Range order pool price to the pool_price_v2 rpc call (#4548)
  fix: just check that the balance after is greater than before (#4587)
  chore: add origin to ccm failed (#4586)
  fix: runtime upgrade state check uses AllPalletsWithoutSystem (#4583)
  chore: add zellic audit to repo (#4585)

# Conflicts:
#	Cargo.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-breaking Merging this PR will create a cherry-pick onto release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants