Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/fix arbitrum deployment #4570

Merged
merged 6 commits into from
Feb 29, 2024
Merged

Conversation

albert-llimos
Copy link
Contributor

@albert-llimos albert-llimos commented Feb 27, 2024

Pull Request

Closes: PLA-1151

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

Fix Arbitrum deployment with the latest flow in the eth-contracts repo.

@albert-llimos albert-llimos added the non-breaking Merging this PR will create a cherry-pick onto release label Feb 27, 2024
@albert-llimos albert-llimos requested review from ahasna and tomjohnburton and removed request for a team February 27, 2024 09:48
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73%. Comparing base (d3d4fbd) to head (ce68f52).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4570   +/-   ##
=====================================
  Coverage     73%     73%           
=====================================
  Files        401     401           
  Lines      66738   66738           
  Branches   66738   66738           
=====================================
  Hits       48417   48417           
- Misses     15975   15976    +1     
+ Partials    2346    2345    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albert-llimos
Copy link
Contributor Author

albert-llimos commented Feb 27, 2024

It's not passing the bouncer due to the flaky test fee collection test but it has nothing to do with this PR.
Now not passing due to an issue with the Solana localnet, but also not related to this PR.

@albert-llimos albert-llimos merged commit c3393b8 into main Feb 29, 2024
43 checks passed
@albert-llimos albert-llimos deleted the chore/fix-arbitrum-deployment branch February 29, 2024 14:29
syan095 added a commit that referenced this pull request Feb 29, 2024
…utxo

* origin/main:
  feat: expose command for broker fee withdrawal (#4581)
  Chore/fix arbitrum deployment (#4570)
  Added Range order pool price to the pool_price_v2 rpc call (#4548)
  fix: just check that the balance after is greater than before (#4587)
  chore: add origin to ccm failed (#4586)
  fix: runtime upgrade state check uses AllPalletsWithoutSystem (#4583)
  chore: add zellic audit to repo (#4585)
  fix: disable try-state checks (#4576)
  chore: debug solana in CI 🐛 (#4580)
  refactor: pass tx_ref as an extrinsic parameter (#4579)
  fix: remove bounded balance check (#4575)
  Solana: update image to latest tag (#4574)
  feat: add boost lp account to bouncer and fund it on setup_swaps (#4552)
  feat: Expose tx_hash on BroadcastSuccess event (#4561)
  feat: Relative Slippage Limits (PRO-1207) (#4547)
  chore: disable localnet solana in CI ⏱️ (#4569)
  feat: store prewitnessed deposits with id (#4496)
  Feat: Scheduled Swaps Subscription (#4525)
syan095 added a commit that referenced this pull request Feb 29, 2024
…ero-liquidity

* origin/main:
  feat: expose command for broker fee withdrawal (#4581)
  Chore/fix arbitrum deployment (#4570)
  Added Range order pool price to the pool_price_v2 rpc call (#4548)
  fix: just check that the balance after is greater than before (#4587)
  chore: add origin to ccm failed (#4586)
  fix: runtime upgrade state check uses AllPalletsWithoutSystem (#4583)
  chore: add zellic audit to repo (#4585)

# Conflicts:
#	Cargo.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-breaking Merging this PR will create a cherry-pick onto release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants