-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: RPC for returning scale-encoded System events #4638
Conversation
The returned data is Vec<frame_system::Event> in scale-encoded bytes format (hex encoded). It does not include extra information in the EventRecord. Let me know if we want to include the event record as well, I can change this. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4638 +/- ##
=====================================
- Coverage 72% 72% -0%
=====================================
Files 414 414
Lines 68288 68312 +24
Branches 68288 68312 +24
=====================================
+ Hits 49046 49056 +10
- Misses 16852 16855 +3
- Partials 2390 2401 +11 ☔ View full report in Codecov by Sentry. |
Pretty sure we need the |
instead of just the event. Refactored the CustomRuntimeApi::get_events() function to remove duplicates.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment 👌
…tation * origin/main: feat: support account deletion (#4314) fix: cf_pools_environment rpc encoding (#4674) fix: submission watcher could confuse/lose track of submissions (#4667) fix(github_actions/release_checks): update confusing runtime spec version check 🤦♂️ (#4672) feat: fix log messages, evm chain specific (#4652) fix: remove cfe events migration (#4671) chore: run CI on `nscloud` runners 🚀 (#4505) logging: lp-api panic in submission watcher (#4664) chore(localnet): append timestamp to log files 🪵 (#4660) fix(chainflip-broker-api): replace u128 with U256 (#4656) fix: remove unused cli command line options (#4644) chore: revert addition of cargo make (#4659) fix: correct cfe-events pallet version (#4658) chore: update systemd config to match 1.4 version 🚀 (#4655) fix: publish `chainflip-engine1.3` to debian packages 🐞 (#4653) Remove aptly check from publish workflow (#4650) fix: more try-runtime unwraps. (#4648) feat: RPC for returning scale-encoded System events (#4638)
Pull Request
Closes: PRO-1185
Checklist
Please conduct a thorough self-review before opening the PR.
Summary:
Created a RPC call that returns System events (In EventRecord) scale encoded.
Changed the original get_events rpc to return event records instead of just the Raw events