fix(chainflip-broker-api): replace u128 with U256 #4656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4656 +/- ##
======================================
- Coverage 72% 72% -0%
======================================
Files 414 414
Lines 68457 68313 -144
Branches 68457 68313 -144
======================================
- Hits 49252 49054 -198
- Misses 16802 16855 +53
- Partials 2403 2404 +1 ☔ View full report in Codecov by Sentry. |
marcellorigotti
approved these changes
Mar 18, 2024
acdibble
added
the
non-breaking
AlastairHolmes
suggested changes
Mar 19, 2024
|
Also I believe this is a breaking change right? |
acdibble
removed
the
non-breaking
|
Actually I looked into it and the u128 will get serialized to a string. |
It won't be if it's included in 1.3 release |
acdibble
changed the title
AlastairHolmes
approved these changes
Mar 20, 2024
martin-chainflip
pushed a commit
that referenced
this pull request
Mar 20, 2024
martin-chainflip
added a commit
that referenced
this pull request
Mar 20, 2024
syan095
added a commit
that referenced
this pull request
Mar 22, 2024
…tation * origin/main: feat: support account deletion (#4314) fix: cf_pools_environment rpc encoding (#4674) fix: submission watcher could confuse/lose track of submissions (#4667) fix(github_actions/release_checks): update confusing runtime spec version check 🤦♂️ (#4672) feat: fix log messages, evm chain specific (#4652) fix: remove cfe events migration (#4671) chore: run CI on `nscloud` runners 🚀 (#4505) logging: lp-api panic in submission watcher (#4664) chore(localnet): append timestamp to log files 🪵 (#4660) fix(chainflip-broker-api): replace u128 with U256 (#4656) fix: remove unused cli command line options (#4644) chore: revert addition of cargo make (#4659) fix: correct cfe-events pallet version (#4658) chore: update systemd config to match 1.4 version 🚀 (#4655) fix: publish `chainflip-engine1.3` to debian packages 🐞 (#4653) Remove aptly check from publish workflow (#4650) fix: more try-runtime unwraps. (#4648) feat: RPC for returning scale-encoded System events (#4638)
dandanlen
pushed a commit
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
For consistency, this should return
NumberOrHexinstead ofu128.u128is too large to be safely represented in JSON, but in this case there shouldn't be any issues because the fee shouldn't exceed 2^53 - 1 (at least immediately).