fix: remove cfe events migration #4671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not needed since cfe events are always deleted at the start of a block.
kylezs
approved these changes
Mar 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4671 +/- ##
=====================================
Coverage 72% 72%
=====================================
Files 414 413 -1
Lines 68319 68272 -47
Branches 68319 68272 -47
=====================================
+ Hits 49053 49057 +4
+ Misses 16860 16812 -48
+ Partials 2406 2403 -3 ☔ View full report in Codecov by Sentry. |
syan095
added a commit
that referenced
this pull request
Mar 22, 2024
…tation * origin/main: feat: support account deletion (#4314) fix: cf_pools_environment rpc encoding (#4674) fix: submission watcher could confuse/lose track of submissions (#4667) fix(github_actions/release_checks): update confusing runtime spec version check 🤦♂️ (#4672) feat: fix log messages, evm chain specific (#4652) fix: remove cfe events migration (#4671) chore: run CI on `nscloud` runners 🚀 (#4505) logging: lp-api panic in submission watcher (#4664) chore(localnet): append timestamp to log files 🪵 (#4660) fix(chainflip-broker-api): replace u128 with U256 (#4656) fix: remove unused cli command line options (#4644) chore: revert addition of cargo make (#4659) fix: correct cfe-events pallet version (#4658) chore: update systemd config to match 1.4 version 🚀 (#4655) fix: publish `chainflip-engine1.3` to debian packages 🐞 (#4653) Remove aptly check from publish workflow (#4650) fix: more try-runtime unwraps. (#4648) feat: RPC for returning scale-encoded System events (#4638)
dandanlen
added a commit
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another try-runtime fix.
This migration is not needed since cfe events are always deleted at the start of a block.