fix: cf_pools_environment rpc encoding #4674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlastairHolmes
added
bug
AlastairHolmes
force-pushed
the
fix/cf_pools_environment_encoding
branch
from
e5078bc
to
2d8d90f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4674 +/- ##
=====================================
Coverage 72% 72%
=====================================
Files 413 413
Lines 68348 68350 +2
Branches 68348 68350 +2
=====================================
+ Hits 49057 49061 +4
+ Misses 16889 16886 -3
- Partials 2402 2403 +1 ☔ View full report in Codecov by Sentry. |
dandanlen
approved these changes
Mar 21, 2024
dandanlen
pushed a commit
that referenced
this pull request
Mar 21, 2024
ahasna
added a commit
that referenced
this pull request
Mar 21, 2024
* fix(github_actions/release_checks): update confusing runtime spec version check 🤦♂️ (#4672) * fix: submission watcher could confuse/lose track of submissions (#4667) * fix: ensure always unique IDs The request ids could be reused, but submissions could last longer than the lifetime of the original request. Sometimes request_id (+ submission_id) was not unique. This was a particular problem, with `submission_status_futures` where an old submission could be confused as being for a newer request. And we could think a submission of the new request was in a block, when it wasn't, but actually it was just the old requests submission that was in the block. * fix: allow submissions from different requests with matching nonce and submission_id Basically previously we would lose track of some submissions under some specific unlikely situations. As we used a BTreeMap over submission_id which aren't globally unique (Only unique to a single request). This would previously cause the submission-watcher to miss a successful submission and retry or fail the request. * refactor: simplify internal behaviour The submission_status_future is no longer valid at this point, and we know it can be removed. By moving the remove outside the if, we ensure submission_status_futures is always inline with the submissions in submission_by_nonce, i.e. that both storage items have matching understanding of the pending submissions. Note the `self.submissions_by_nonce.remove(nonce)` above this. Here the change is basically that everytime we remove i.e. `self.submissions_by_nonce.remove(nonce)` we should remove all the matching submissions from `submission_status_futures` so they are kept up to date. **This was not a bug** * fix: cf_pools_environment rpc encoding (#4674) * chore: bump version to 1.3.1 --------- Co-authored-by: Assem <asem.hasna@gmail.com> Co-authored-by: Alastair Holmes <42404303+AlastairHolmes@users.noreply.github.com>
syan095
added a commit
that referenced
this pull request
Mar 22, 2024
…tation * origin/main: feat: support account deletion (#4314) fix: cf_pools_environment rpc encoding (#4674) fix: submission watcher could confuse/lose track of submissions (#4667) fix(github_actions/release_checks): update confusing runtime spec version check 🤦♂️ (#4672) feat: fix log messages, evm chain specific (#4652) fix: remove cfe events migration (#4671) chore: run CI on `nscloud` runners 🚀 (#4505) logging: lp-api panic in submission watcher (#4664) chore(localnet): append timestamp to log files 🪵 (#4660) fix(chainflip-broker-api): replace u128 with U256 (#4656) fix: remove unused cli command line options (#4644) chore: revert addition of cargo make (#4659) fix: correct cfe-events pallet version (#4658) chore: update systemd config to match 1.4 version 🚀 (#4655) fix: publish `chainflip-engine1.3` to debian packages 🐞 (#4653) Remove aptly check from publish workflow (#4650) fix: more try-runtime unwraps. (#4648) feat: RPC for returning scale-encoded System events (#4638)
dandanlen
pushed a commit
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem here was we tried to serialise a non-string json object as the key to a json map. This happened as the OldAsset encodes all the old assets as strings of the asset name i.e.
"Eth", but the newer recently introduced assets likeArbitrum-Ethas a pair of chain and asset. So we can disambiguate which version of Eth it is.