Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add log position to FE #2826

Merged
merged 3 commits into from
Sep 25, 2024
Merged

[ENH] Add log position to FE #2826

merged 3 commits into from
Sep 25, 2024

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Sep 20, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • This PR simply hydrates the python representation of the collection with the log position that comes from the proto. Following the convention for version, this is 0 and unused in single node.
  • New functionality
    • None

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Collaborator Author

HammadB commented Sep 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @HammadB and the rest of your teammates on Graphite Graphite

@HammadB HammadB force-pushed the hammad/add_log_position branch from 83fac49 to b057336 Compare September 25, 2024 17:52
Copy link
Collaborator Author

HammadB commented Sep 25, 2024

Merge activity

  • Sep 25, 1:54 PM EDT: @HammadB started a stack merge that includes this pull request via Graphite.
  • Sep 25, 1:54 PM EDT: @HammadB merged this pull request with Graphite.

@HammadB HammadB merged commit bab17a1 into main Sep 25, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants