Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Propagate version through system #2839

Merged
merged 7 commits into from
Sep 25, 2024
Merged

[ENH] Propagate version through system #2839

merged 7 commits into from
Sep 25, 2024

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Sep 23, 2024 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Pass the request_version_context into the protobufs and to the rust code. In the rust orchestrators, we error on mismatches and propagate this error up to python.
  • New functionality
    • None

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

This was referenced Sep 23, 2024
Merged
Merged
Closed
@HammadB Graphite App
Copy link
Collaborator Author

HammadB commented Sep 23, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @HammadB and the rest of your teammates on Graphite Graphite

@HammadB HammadB mentioned this pull request Sep 23, 2024
Merged
1 task
@HammadB HammadB force-pushed the hammad/request_version_context_proto branch from 9655191 to 7d7efe6 Compare September 24, 2024 13:08
@HammadB HammadB force-pushed the hammad/request_version_rust branch from 7df31ca to 73b664c Compare September 24, 2024 13:08
@HammadB HammadB force-pushed the hammad/request_version_context_proto branch from 7d7efe6 to 2c6ff47 Compare September 24, 2024 13:49
@HammadB HammadB force-pushed the hammad/request_version_rust branch from 73b664c to f1748e2 Compare September 24, 2024 13:49
@HammadB HammadB force-pushed the hammad/request_version_context_proto branch from 2c6ff47 to d9fbe68 Compare September 24, 2024 13:57
@HammadB HammadB force-pushed the hammad/request_version_rust branch 2 times, most recently from bd105c6 to cc4d3bf Compare September 24, 2024 14:21
This was referenced Sep 24, 2024
Merged
Merged
HammadB
HammadB commented Sep 25, 2024
View reviewed changes
rust/error/src/lib.rs
@@ -10,7 +10,7 @@ pub enum ErrorCodes {
// CANCELLED indicates the operation was cancelled (typically by the caller).
Cancelled = 1,
// UNKNOWN indicates an unknown error.
UNKNOWN = 2,
Unknown = 2,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleanup

HammadB
HammadB commented Sep 25, 2024
View reviewed changes
rust/error/src/lib.rs
@@ -39,6 +37,10 @@ pub enum ErrorCodes {
Unavailable = 14,
// DATA_LOSS indicates unrecoverable data loss or corruption.
DataLoss = 15,
// UNAUTHENTICATED indicates the request does not have valid authentication credentials for the operation.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleanup reordering

@HammadB HammadB marked this pull request as ready for review September 25, 2024 06:11
@HammadB HammadB mentioned this pull request Sep 25, 2024
Closed
1 task
@HammadB HammadB force-pushed the hammad/request_version_context_proto branch from 667bc3f to 9bc5f5f Compare September 25, 2024 17:52
@HammadB HammadB force-pushed the hammad/request_version_rust branch from cce9f81 to fe32510 Compare September 25, 2024 17:52
@HammadB Graphite App
Copy link
Collaborator Author

HammadB commented Sep 25, 2024 •
edited
Loading

Merge activity

  • Sep 25, 1:54 PM EDT: @HammadB started a stack merge that includes this pull request via Graphite.
  • Sep 25, 2:03 PM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 25, 2:04 PM EDT: @HammadB merged this pull request with Graphite.

@HammadB HammadB changed the base branch from hammad/request_version_context_proto to graphite-base/2839 September 25, 2024 17:59
@HammadB HammadB changed the base branch from graphite-base/2839 to main September 25, 2024 18:01
@HammadB HammadB force-pushed the hammad/request_version_rust branch from fe32510 to 3c6a0c4 Compare September 25, 2024 18:02
@HammadB HammadB merged commit 2c382a8 into main Sep 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketkedia sanketkedia sanketkedia approved these changes

@codetheweb codetheweb Awaiting requested review from codetheweb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HammadB @sanketkedia