Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add proto conversions for RequestMetadata #2831

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Sep 20, 2024

Description of changes

Summarize the changes made by this PR.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

Copy link
Collaborator Author

HammadB commented Sep 20, 2024

@HammadB HammadB mentioned this pull request Sep 20, 2024
1 task
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@HammadB HammadB force-pushed the hammad/request_version_context_proto branch from a2492bc to 9655191 Compare September 20, 2024 17:38
@HammadB HammadB changed the title [ENH] Add proto conversions for RequestMetadta [ENH] Add proto conversions for RequestMetadata Sep 23, 2024
@HammadB HammadB force-pushed the hammad/go_debug_proto branch from 36b988e to de191d2 Compare September 24, 2024 13:08
@HammadB HammadB force-pushed the hammad/request_version_context_proto branch 2 times, most recently from 7d7efe6 to 2c6ff47 Compare September 24, 2024 13:49
@HammadB HammadB changed the base branch from hammad/go_debug_proto to hammad/request_version_context September 24, 2024 13:49
@HammadB HammadB force-pushed the hammad/request_version_context branch from 90caacb to 52d7b8e Compare September 24, 2024 13:57
@HammadB HammadB force-pushed the hammad/request_version_context_proto branch from 2c6ff47 to d9fbe68 Compare September 24, 2024 13:57
@HammadB HammadB requested a review from sanketkedia September 24, 2024 14:18
@HammadB HammadB marked this pull request as ready for review September 24, 2024 14:18
@@ -93,6 +93,11 @@ message OperationRecord {
Operation operation = 4;
}

message RequestVersionContext {
uint32 collection_version = 1;
uint64 log_position = 2;
Copy link
Contributor

@sanketkedia sanketkedia Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: log_offset is the name used everywhere else. Don't have any strong preference on which is better but should we have a consistent naming everywhere?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should. But this inconsistency is not introduced here (i.e "name used everywhere else" is not true").

If you look at message Collection {} for example

message Collection {
  string id = 1;
  string name = 2;
  string configuration_json_str = 3;
  optional UpdateMetadata metadata = 4;
  optional int32 dimension = 5;
  string tenant = 6;
  string database = 7;
  int64 log_position = 8;
  int32 version = 9;
}

It is log_position. I went off what the collection called it, I don't know how to choose haha.

@HammadB HammadB force-pushed the hammad/request_version_context branch from 52d7b8e to cc48788 Compare September 25, 2024 17:52
@HammadB HammadB force-pushed the hammad/request_version_context_proto branch from 667bc3f to 9bc5f5f Compare September 25, 2024 17:52
Copy link
Collaborator Author

HammadB commented Sep 25, 2024

Merge activity

  • Sep 25, 1:54 PM EDT: @HammadB started a stack merge that includes this pull request via Graphite.
  • Sep 25, 2:00 PM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 25, 2:01 PM EDT: @HammadB merged this pull request with Graphite.

@HammadB HammadB changed the base branch from hammad/request_version_context to graphite-base/2831 September 25, 2024 17:55
@HammadB HammadB changed the base branch from graphite-base/2831 to main September 25, 2024 17:57
@HammadB HammadB force-pushed the hammad/request_version_context_proto branch from 9bc5f5f to 74f8e7f Compare September 25, 2024 17:59
@HammadB HammadB merged commit 7a29ad4 into main Sep 25, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants