Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Propagate error codes through rust services #2842

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Sep 24, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Send error codes back to calling services from Box<dyn ChromaError>s
  • New functionality
    • None

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Collaborator Author

HammadB commented Sep 24, 2024

rust/error/src/lib.rs Show resolved Hide resolved
@HammadB HammadB force-pushed the hammad/rust_version_error_prop branch 2 times, most recently from 85ba1c3 to a173bc4 Compare September 25, 2024 04:19
@HammadB HammadB force-pushed the hammad/request_version_rust branch from cce9f81 to fe32510 Compare September 25, 2024 17:52
@HammadB HammadB force-pushed the hammad/rust_version_error_prop branch from a173bc4 to d90661c Compare September 25, 2024 17:52
Copy link
Collaborator Author

HammadB commented Sep 25, 2024

Merge activity

  • Sep 25, 1:54 PM EDT: @HammadB started a stack merge that includes this pull request via Graphite.
  • Sep 25, 2:06 PM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 25, 2:07 PM EDT: @HammadB merged this pull request with Graphite.

@HammadB HammadB changed the base branch from hammad/request_version_rust to graphite-base/2842 September 25, 2024 18:02
@HammadB HammadB changed the base branch from graphite-base/2842 to main September 25, 2024 18:04
@HammadB HammadB force-pushed the hammad/rust_version_error_prop branch from d90661c to 3af135b Compare September 25, 2024 18:05
@HammadB HammadB merged commit e3da324 into main Sep 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants