Add compatibility for newest acado release #248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library file has been renamed and the execution of the generator requires the library path to be given.
rhinodavid
pushed a commit
to rhinodavid/openpilot
that referenced
this pull request
Mar 6, 2019
Update generator.cpp to parameterize the follow time. Then, using the process outlined in the ACADO docs (https://acado.github.io/cgt_overview.html), rebuild the generator binary and run it to regenerate the source files in lib_mpc_export, then manually copy them into the openpilot repo. Update longitudinal_mpc.c, libmpc_py.py, and planner.py to take in the additional follow_time parameter. Incorporate arne182's PR to update the Makefile (commaai#248). Note that I did not use the generate recipie inside the repo; I created the files outside of the repo as stated above.
rhinodavid
pushed a commit
to rhinodavid/openpilot
that referenced
this pull request
Mar 11, 2019
Update generator.cpp to parameterize the follow time. Then, using the process outlined in the ACADO docs (https://acado.github.io/cgt_overview.html), rebuild the generator binary and run it to regenerate the source files in lib_mpc_export, then manually copy them into the openpilot repo. Update longitudinal_mpc.c, libmpc_py.py, and planner.py to take in the additional follow_time parameter. Incorporate arne182's PR to update the Makefile (commaai#248). Note that I did not use the generate recipie inside the repo; I created the files outside of the repo as stated above.
rhinodavid
pushed a commit
to rhinodavid/openpilot
that referenced
this pull request
Mar 12, 2019
Update generator.cpp to parameterize the follow time. Then, using the process outlined in the ACADO docs (https://acado.github.io/cgt_overview.html), rebuild the generator binary and run it to regenerate the source files in lib_mpc_export, then manually copy them into the openpilot repo. Update longitudinal_mpc.c, libmpc_py.py, and planner.py to take in the additional follow_time parameter. Incorporate arne182's PR to update the Makefile (commaai#248). Note that I did not use the generate recipie inside the repo; I created the files outside of the repo as stated above.
rhinodavid
pushed a commit
to rhinodavid/openpilot
that referenced
this pull request
Mar 14, 2019
Update generator.cpp to parameterize the follow time. Then, using the process outlined in the ACADO docs (https://acado.github.io/cgt_overview.html), rebuild the generator binary and run it to regenerate the source files in lib_mpc_export, then manually copy them into the openpilot repo. Update longitudinal_mpc.c, libmpc_py.py, and planner.py to take in the additional follow_time parameter. Incorporate arne182's PR to update the Makefile (commaai#248). Note that I did not use the generate recipie inside the repo; I created the files outside of the repo as stated above.
rhinodavid
added a commit
to rhinodavid/openpilot
that referenced
this pull request
Mar 16, 2019
* Update longitudinal mpc with follow distance param Update generator.cpp to parameterize the follow time. Then, using the process outlined in the ACADO docs (https://acado.github.io/cgt_overview.html), rebuild the generator binary and run it to regenerate the source files in lib_mpc_export, then manually copy them into the openpilot repo. Update longitudinal_mpc.c, libmpc_py.py, and planner.py to take in the additional follow_time parameter. Incorporate arne182's PR to update the Makefile (commaai#248). Note that I did not use the generate recipie inside the repo; I created the files outside of the repo as stated above. * Add distance cost parameter to longitudinal mpc The distance cost was hardcoded, allow with the time gap. But as we lower the time gap we will need to increase the distance cost for reliable control * Scale the time gap up as we slow down
rhinodavid
added a commit
to rhinodavid/openpilot
that referenced
this pull request
Apr 8, 2019
* Update longitudinal mpc with follow distance param Update generator.cpp to parameterize the follow time. Then, using the process outlined in the ACADO docs (https://acado.github.io/cgt_overview.html), rebuild the generator binary and run it to regenerate the source files in lib_mpc_export, then manually copy them into the openpilot repo. Update longitudinal_mpc.c, libmpc_py.py, and planner.py to take in the additional follow_time parameter. Incorporate arne182's PR to update the Makefile (commaai#248). Note that I did not use the generate recipie inside the repo; I created the files outside of the repo as stated above. * Add distance cost parameter to longitudinal mpc The distance cost was hardcoded, allow with the time gap. But as we lower the time gap we will need to increase the distance cost for reliable control * Scale the time gap up as we slow down
rhinodavid
added a commit
to rhinodavid/openpilot
that referenced
this pull request
Apr 25, 2019
* Update longitudinal mpc with follow distance param Update generator.cpp to parameterize the follow time. Then, using the process outlined in the ACADO docs (https://acado.github.io/cgt_overview.html), rebuild the generator binary and run it to regenerate the source files in lib_mpc_export, then manually copy them into the openpilot repo. Update longitudinal_mpc.c, libmpc_py.py, and planner.py to take in the additional follow_time parameter. Incorporate arne182's PR to update the Makefile (commaai#248). Note that I did not use the generate recipie inside the repo; I created the files outside of the repo as stated above. * Add distance cost parameter to longitudinal mpc The distance cost was hardcoded, allow with the time gap. But as we lower the time gap we will need to increase the distance cost for reliable control * Scale the time gap up as we slow down
pd0wm
pushed a commit
that referenced
this pull request
May 6, 2020
fb6c1ee2 Better GEAR signal tracking the gear stick rather than the gear box (#257) d7a2efbb Raw angle signal data for easy checksum calc, and one less gear bit (#254) 7456061a add checksum check to can parser for subaru 7f3b1774 Chrysler: calculate checksum in can packer/parser (#255) 0c021551 Rename BYTE_ to SET_ME_X (#253) 1efe437c Add values for a static 0xe5 (honda bosch) (#250) 7dffe0bd Create DBC for HRV (#248) b6939852 Add LFAHDA message to hyundai a57e7ddb CANPacker: Subaru checksum support (#241) 36c471e5 Fixed signals order and added new signals for subaru global (#221) 7b5a1fcc BMW 2008-2013 (#230) cc09af76 Add RPM signal (#216) 47db9238 Add SWA_01 message detail and CRC support for VW MQB (#236) c98fe2ab Fixed signal unknown1 overlapping the button bits (#239) 572261ee Rear Cross Traffic Alert 044730ae Speed limit signs 87b1a21f Pedals/gear, gas pedal scale value ce78044d Tracking the steer angle with LKAS signal 7f19ab41 Introduce the new mazda 3 2019/2020 dbc e5852061 traffic sign speed limit 00bad5ee Speed Auto High Beam Traffic signs 9d080ea4 Nissan leaf (#238) 50fbbe73 nissan x trail cleanup (#237) git-subtree-dir: opendbc git-subtree-split: fb6c1ee2b481deb42997c3ca20582c8247cd33b9
pd0wm
pushed a commit
that referenced
this pull request
May 8, 2020
fb6c1ee2 Better GEAR signal tracking the gear stick rather than the gear box (#257) d7a2efbb Raw angle signal data for easy checksum calc, and one less gear bit (#254) 7456061a add checksum check to can parser for subaru 7f3b1774 Chrysler: calculate checksum in can packer/parser (#255) 0c021551 Rename BYTE_ to SET_ME_X (#253) 1efe437c Add values for a static 0xe5 (honda bosch) (#250) 7dffe0bd Create DBC for HRV (#248) b6939852 Add LFAHDA message to hyundai a57e7ddb CANPacker: Subaru checksum support (#241) 36c471e5 Fixed signals order and added new signals for subaru global (#221) 7b5a1fcc BMW 2008-2013 (#230) cc09af76 Add RPM signal (#216) 47db9238 Add SWA_01 message detail and CRC support for VW MQB (#236) c98fe2ab Fixed signal unknown1 overlapping the button bits (#239) 572261ee Rear Cross Traffic Alert 044730ae Speed limit signs 87b1a21f Pedals/gear, gas pedal scale value ce78044d Tracking the steer angle with LKAS signal 7f19ab41 Introduce the new mazda 3 2019/2020 dbc e5852061 traffic sign speed limit 00bad5ee Speed Auto High Beam Traffic signs 9d080ea4 Nissan leaf (#238) 50fbbe73 nissan x trail cleanup (#237) git-subtree-dir: opendbc git-subtree-split: fb6c1ee2b481deb42997c3ca20582c8247cd33b9
pd0wm
pushed a commit
that referenced
this pull request
May 8, 2020
fb6c1ee2 Better GEAR signal tracking the gear stick rather than the gear box (#257) d7a2efbb Raw angle signal data for easy checksum calc, and one less gear bit (#254) 7456061a add checksum check to can parser for subaru 7f3b1774 Chrysler: calculate checksum in can packer/parser (#255) 0c021551 Rename BYTE_ to SET_ME_X (#253) 1efe437c Add values for a static 0xe5 (honda bosch) (#250) 7dffe0bd Create DBC for HRV (#248) b6939852 Add LFAHDA message to hyundai a57e7ddb CANPacker: Subaru checksum support (#241) 36c471e5 Fixed signals order and added new signals for subaru global (#221) 7b5a1fcc BMW 2008-2013 (#230) cc09af76 Add RPM signal (#216) 47db9238 Add SWA_01 message detail and CRC support for VW MQB (#236) c98fe2ab Fixed signal unknown1 overlapping the button bits (#239) 572261ee Rear Cross Traffic Alert 044730ae Speed limit signs 87b1a21f Pedals/gear, gas pedal scale value ce78044d Tracking the steer angle with LKAS signal 7f19ab41 Introduce the new mazda 3 2019/2020 dbc e5852061 traffic sign speed limit 00bad5ee Speed Auto High Beam Traffic signs 9d080ea4 Nissan leaf (#238) 50fbbe73 nissan x trail cleanup (#237) git-subtree-dir: opendbc git-subtree-split: fb6c1ee2b481deb42997c3ca20582c8247cd33b9
pd0wm
pushed a commit
that referenced
this pull request
May 8, 2020
fb6c1ee2 Better GEAR signal tracking the gear stick rather than the gear box (#257) d7a2efbb Raw angle signal data for easy checksum calc, and one less gear bit (#254) 7456061a add checksum check to can parser for subaru 7f3b1774 Chrysler: calculate checksum in can packer/parser (#255) 0c021551 Rename BYTE_ to SET_ME_X (#253) 1efe437c Add values for a static 0xe5 (honda bosch) (#250) 7dffe0bd Create DBC for HRV (#248) b6939852 Add LFAHDA message to hyundai a57e7ddb CANPacker: Subaru checksum support (#241) 36c471e5 Fixed signals order and added new signals for subaru global (#221) 7b5a1fcc BMW 2008-2013 (#230) cc09af76 Add RPM signal (#216) 47db9238 Add SWA_01 message detail and CRC support for VW MQB (#236) c98fe2ab Fixed signal unknown1 overlapping the button bits (#239) 572261ee Rear Cross Traffic Alert 044730ae Speed limit signs 87b1a21f Pedals/gear, gas pedal scale value ce78044d Tracking the steer angle with LKAS signal 7f19ab41 Introduce the new mazda 3 2019/2020 dbc e5852061 traffic sign speed limit 00bad5ee Speed Auto High Beam Traffic signs 9d080ea4 Nissan leaf (#238) 50fbbe73 nissan x trail cleanup (#237) git-subtree-dir: opendbc git-subtree-split: fb6c1ee2b481deb42997c3ca20582c8247cd33b9
pd0wm
pushed a commit
that referenced
this pull request
May 9, 2020
fb6c1ee2 Better GEAR signal tracking the gear stick rather than the gear box (#257) d7a2efbb Raw angle signal data for easy checksum calc, and one less gear bit (#254) 7456061a add checksum check to can parser for subaru 7f3b1774 Chrysler: calculate checksum in can packer/parser (#255) 0c021551 Rename BYTE_ to SET_ME_X (#253) 1efe437c Add values for a static 0xe5 (honda bosch) (#250) 7dffe0bd Create DBC for HRV (#248) b6939852 Add LFAHDA message to hyundai a57e7ddb CANPacker: Subaru checksum support (#241) 36c471e5 Fixed signals order and added new signals for subaru global (#221) 7b5a1fcc BMW 2008-2013 (#230) cc09af76 Add RPM signal (#216) 47db9238 Add SWA_01 message detail and CRC support for VW MQB (#236) c98fe2ab Fixed signal unknown1 overlapping the button bits (#239) 572261ee Rear Cross Traffic Alert 044730ae Speed limit signs 87b1a21f Pedals/gear, gas pedal scale value ce78044d Tracking the steer angle with LKAS signal 7f19ab41 Introduce the new mazda 3 2019/2020 dbc e5852061 traffic sign speed limit 00bad5ee Speed Auto High Beam Traffic signs 9d080ea4 Nissan leaf (#238) 50fbbe73 nissan x trail cleanup (#237) git-subtree-dir: opendbc git-subtree-split: fb6c1ee2b481deb42997c3ca20582c8247cd33b9
pd0wm
pushed a commit
that referenced
this pull request
May 9, 2020
fb6c1ee2 Better GEAR signal tracking the gear stick rather than the gear box (#257) d7a2efbb Raw angle signal data for easy checksum calc, and one less gear bit (#254) 7456061a add checksum check to can parser for subaru 7f3b1774 Chrysler: calculate checksum in can packer/parser (#255) 0c021551 Rename BYTE_ to SET_ME_X (#253) 1efe437c Add values for a static 0xe5 (honda bosch) (#250) 7dffe0bd Create DBC for HRV (#248) b6939852 Add LFAHDA message to hyundai a57e7ddb CANPacker: Subaru checksum support (#241) 36c471e5 Fixed signals order and added new signals for subaru global (#221) 7b5a1fcc BMW 2008-2013 (#230) cc09af76 Add RPM signal (#216) 47db9238 Add SWA_01 message detail and CRC support for VW MQB (#236) c98fe2ab Fixed signal unknown1 overlapping the button bits (#239) 572261ee Rear Cross Traffic Alert 044730ae Speed limit signs 87b1a21f Pedals/gear, gas pedal scale value ce78044d Tracking the steer angle with LKAS signal 7f19ab41 Introduce the new mazda 3 2019/2020 dbc e5852061 traffic sign speed limit 00bad5ee Speed Auto High Beam Traffic signs 9d080ea4 Nissan leaf (#238) 50fbbe73 nissan x trail cleanup (#237) git-subtree-dir: opendbc git-subtree-split: fb6c1ee2b481deb42997c3ca20582c8247cd33b9
pd0wm
pushed a commit
that referenced
this pull request
May 9, 2020
fb6c1ee2 Better GEAR signal tracking the gear stick rather than the gear box (#257) d7a2efbb Raw angle signal data for easy checksum calc, and one less gear bit (#254) 7456061a add checksum check to can parser for subaru 7f3b1774 Chrysler: calculate checksum in can packer/parser (#255) 0c021551 Rename BYTE_ to SET_ME_X (#253) 1efe437c Add values for a static 0xe5 (honda bosch) (#250) 7dffe0bd Create DBC for HRV (#248) b6939852 Add LFAHDA message to hyundai a57e7ddb CANPacker: Subaru checksum support (#241) 36c471e5 Fixed signals order and added new signals for subaru global (#221) 7b5a1fcc BMW 2008-2013 (#230) cc09af76 Add RPM signal (#216) 47db9238 Add SWA_01 message detail and CRC support for VW MQB (#236) c98fe2ab Fixed signal unknown1 overlapping the button bits (#239) 572261ee Rear Cross Traffic Alert 044730ae Speed limit signs 87b1a21f Pedals/gear, gas pedal scale value ce78044d Tracking the steer angle with LKAS signal 7f19ab41 Introduce the new mazda 3 2019/2020 dbc e5852061 traffic sign speed limit 00bad5ee Speed Auto High Beam Traffic signs 9d080ea4 Nissan leaf (#238) 50fbbe73 nissan x trail cleanup (#237) git-subtree-dir: opendbc git-subtree-split: fb6c1ee2b481deb42997c3ca20582c8247cd33b9
pd0wm
pushed a commit
that referenced
this pull request
May 9, 2020
4e796e06 Fix wrong message sizes in Nissan fb6c1ee2 Better GEAR signal tracking the gear stick rather than the gear box (#257) d7a2efbb Raw angle signal data for easy checksum calc, and one less gear bit (#254) 7456061a add checksum check to can parser for subaru 7f3b1774 Chrysler: calculate checksum in can packer/parser (#255) 0c021551 Rename BYTE_ to SET_ME_X (#253) 1efe437c Add values for a static 0xe5 (honda bosch) (#250) 7dffe0bd Create DBC for HRV (#248) b6939852 Add LFAHDA message to hyundai a57e7ddb CANPacker: Subaru checksum support (#241) 36c471e5 Fixed signals order and added new signals for subaru global (#221) 7b5a1fcc BMW 2008-2013 (#230) cc09af76 Add RPM signal (#216) 47db9238 Add SWA_01 message detail and CRC support for VW MQB (#236) c98fe2ab Fixed signal unknown1 overlapping the button bits (#239) 572261ee Rear Cross Traffic Alert 044730ae Speed limit signs 87b1a21f Pedals/gear, gas pedal scale value ce78044d Tracking the steer angle with LKAS signal 7f19ab41 Introduce the new mazda 3 2019/2020 dbc e5852061 traffic sign speed limit 00bad5ee Speed Auto High Beam Traffic signs 9d080ea4 Nissan leaf (#238) 50fbbe73 nissan x trail cleanup (#237) git-subtree-dir: opendbc git-subtree-split: 4e796e06dd44757bb73042f0ec26fd9b6ddc7142
pd0wm
pushed a commit
that referenced
this pull request
May 9, 2020
f1e69a6cf Fix wrong message size in Chrysler 54482cfb0 Fix GM message signal sizes 4e796e06d Fix wrong message sizes in Nissan fb6c1ee2b Better GEAR signal tracking the gear stick rather than the gear box (#257) d7a2efbbd Raw angle signal data for easy checksum calc, and one less gear bit (#254) 7456061a7 add checksum check to can parser for subaru 7f3b1774d Chrysler: calculate checksum in can packer/parser (#255) 0c0215516 Rename BYTE_ to SET_ME_X (#253) 1efe437cf Add values for a static 0xe5 (honda bosch) (#250) 7dffe0bd9 Create DBC for HRV (#248) b69398525 Add LFAHDA message to hyundai a57e7ddbd CANPacker: Subaru checksum support (#241) 36c471e59 Fixed signals order and added new signals for subaru global (#221) 7b5a1fcc1 BMW 2008-2013 (#230) cc09af763 Add RPM signal (#216) 47db9238f Add SWA_01 message detail and CRC support for VW MQB (#236) c98fe2ab9 Fixed signal unknown1 overlapping the button bits (#239) 572261ee3 Rear Cross Traffic Alert 044730aeb Speed limit signs 87b1a21fb Pedals/gear, gas pedal scale value ce78044d8 Tracking the steer angle with LKAS signal 7f19ab415 Introduce the new mazda 3 2019/2020 dbc e58520619 traffic sign speed limit 00bad5ee7 Speed Auto High Beam Traffic signs 9d080ea42 Nissan leaf (#238) 50fbbe739 nissan x trail cleanup (#237) git-subtree-dir: opendbc git-subtree-split: f1e69a6cf91cdaf1b8008d73f6fbb6634fbbeb42
pd0wm
pushed a commit
that referenced
this pull request
May 10, 2020
f1e69a6cf Fix wrong message size in Chrysler 54482cfb0 Fix GM message signal sizes 4e796e06d Fix wrong message sizes in Nissan fb6c1ee2b Better GEAR signal tracking the gear stick rather than the gear box (#257) d7a2efbbd Raw angle signal data for easy checksum calc, and one less gear bit (#254) 7456061a7 add checksum check to can parser for subaru 7f3b1774d Chrysler: calculate checksum in can packer/parser (#255) 0c0215516 Rename BYTE_ to SET_ME_X (#253) 1efe437cf Add values for a static 0xe5 (honda bosch) (#250) 7dffe0bd9 Create DBC for HRV (#248) b69398525 Add LFAHDA message to hyundai a57e7ddbd CANPacker: Subaru checksum support (#241) 36c471e59 Fixed signals order and added new signals for subaru global (#221) 7b5a1fcc1 BMW 2008-2013 (#230) cc09af763 Add RPM signal (#216) 47db9238f Add SWA_01 message detail and CRC support for VW MQB (#236) c98fe2ab9 Fixed signal unknown1 overlapping the button bits (#239) 572261ee3 Rear Cross Traffic Alert 044730aeb Speed limit signs 87b1a21fb Pedals/gear, gas pedal scale value ce78044d8 Tracking the steer angle with LKAS signal 7f19ab415 Introduce the new mazda 3 2019/2020 dbc e58520619 traffic sign speed limit 00bad5ee7 Speed Auto High Beam Traffic signs 9d080ea42 Nissan leaf (#238) 50fbbe739 nissan x trail cleanup (#237) git-subtree-dir: opendbc git-subtree-split: f1e69a6cf91cdaf1b8008d73f6fbb6634fbbeb42
pd0wm
pushed a commit
that referenced
this pull request
May 10, 2020
f1e69a6cf Fix wrong message size in Chrysler 54482cfb0 Fix GM message signal sizes 4e796e06d Fix wrong message sizes in Nissan fb6c1ee2b Better GEAR signal tracking the gear stick rather than the gear box (#257) d7a2efbbd Raw angle signal data for easy checksum calc, and one less gear bit (#254) 7456061a7 add checksum check to can parser for subaru 7f3b1774d Chrysler: calculate checksum in can packer/parser (#255) 0c0215516 Rename BYTE_ to SET_ME_X (#253) 1efe437cf Add values for a static 0xe5 (honda bosch) (#250) 7dffe0bd9 Create DBC for HRV (#248) b69398525 Add LFAHDA message to hyundai a57e7ddbd CANPacker: Subaru checksum support (#241) 36c471e59 Fixed signals order and added new signals for subaru global (#221) 7b5a1fcc1 BMW 2008-2013 (#230) cc09af763 Add RPM signal (#216) 47db9238f Add SWA_01 message detail and CRC support for VW MQB (#236) c98fe2ab9 Fixed signal unknown1 overlapping the button bits (#239) 572261ee3 Rear Cross Traffic Alert 044730aeb Speed limit signs 87b1a21fb Pedals/gear, gas pedal scale value ce78044d8 Tracking the steer angle with LKAS signal 7f19ab415 Introduce the new mazda 3 2019/2020 dbc e58520619 traffic sign speed limit 00bad5ee7 Speed Auto High Beam Traffic signs 9d080ea42 Nissan leaf (#238) 50fbbe739 nissan x trail cleanup (#237) git-subtree-dir: opendbc git-subtree-split: f1e69a6cf91cdaf1b8008d73f6fbb6634fbbeb42
pd0wm
pushed a commit
that referenced
this pull request
May 11, 2020
f1e69a6cf Fix wrong message size in Chrysler 54482cfb0 Fix GM message signal sizes 4e796e06d Fix wrong message sizes in Nissan fb6c1ee2b Better GEAR signal tracking the gear stick rather than the gear box (#257) d7a2efbbd Raw angle signal data for easy checksum calc, and one less gear bit (#254) 7456061a7 add checksum check to can parser for subaru 7f3b1774d Chrysler: calculate checksum in can packer/parser (#255) 0c0215516 Rename BYTE_ to SET_ME_X (#253) 1efe437cf Add values for a static 0xe5 (honda bosch) (#250) 7dffe0bd9 Create DBC for HRV (#248) b69398525 Add LFAHDA message to hyundai a57e7ddbd CANPacker: Subaru checksum support (#241) 36c471e59 Fixed signals order and added new signals for subaru global (#221) 7b5a1fcc1 BMW 2008-2013 (#230) cc09af763 Add RPM signal (#216) 47db9238f Add SWA_01 message detail and CRC support for VW MQB (#236) c98fe2ab9 Fixed signal unknown1 overlapping the button bits (#239) 572261ee3 Rear Cross Traffic Alert 044730aeb Speed limit signs 87b1a21fb Pedals/gear, gas pedal scale value ce78044d8 Tracking the steer angle with LKAS signal 7f19ab415 Introduce the new mazda 3 2019/2020 dbc e58520619 traffic sign speed limit 00bad5ee7 Speed Auto High Beam Traffic signs 9d080ea42 Nissan leaf (#238) 50fbbe739 nissan x trail cleanup (#237) git-subtree-dir: opendbc git-subtree-split: f1e69a6cf91cdaf1b8008d73f6fbb6634fbbeb42
nworb-cire
pushed a commit
to opgm/openpilot
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library file has been renamed and the execution of the generator requires the library path to be given.