GM: disengage on radar fault #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah... the opendbc changes needs to be done together with these op changes (otherwise radard would crash). |
|
I've been testing it on my 2018 Volt with no issues. |
|
Verified. |
Merged
|
Also needs commaai/opendbc#116 to be re-added to opendbc repo. |
|
@vntarasov , sounds good. |
klaus385
pushed a commit
to klaus385/openpilot
that referenced
this pull request
Dec 31, 2018
* GM: copy cadillac's radar header DBC * Remove unused interface imports * Rename num targets message to radar header * Catch various radar faults
pd0wm
pushed a commit
that referenced
this pull request
Dec 14, 2019
a648cca Add os import 042562d Extracted wifi connect from test helpers ac0fd5d query fw versions example - use extended diagnostic session 4e9d788 Remove not-needed cadillac-init f0a5d15 typo c093286 Add bootkick after re-enabling phone power (#401) eadb0db security upgrades (#397) 7c13bec Command to get signature (#399) dad439a static assert on size of health packet (#398) da9da46 Fix VERSION df4159c Revert "Revert "Register readback on most modules. Still need to convert the other ones (#396)"" 56ec215 Revert "Register readback on most modules. Still need to convert the other ones (#396)" 893e486 Register readback on most modules. Still need to convert the other ones (#396) 6bbae7b VW safety: allow cancel spam on both buses to be compatible with camera and gateway integration d5f7a28 bump panda 1bcc351 ignition_can: set it to False after 2s of not seeing CAN msgs 96137f1 VW can based ignition not needed. it has ignition line at camera as well. 1b004a1 Same flake8 version as the one in openpilot e82ba5f Same pylint version as the one in openpilot 656f99b Interrupt refactor (NVIC_SM_1: #334) and Fault handling (#377) (PR #373) 000282e Fix can_logger.py to run correctly on python3 (#392) 7f9b4a5 Fix USB device enumeration on Windows 8.1 and Windows 10 (#393) dec565c Update Misra test coverage, which now includes rule 2.7 fb6bc3b Fix Misra 878dd00 solve race condition is relay_malfunction right after changing the relay status by adding a counter 2d4cb05 add a safety mode counter a6797a21 Implement USB power mode on uno 670f90c Merge branch 'master' of github.com:commaai/panda ca39a5d Added faults integer to health packet e1c34a1 Panda Jungle testing (#394) 2a093a3 Added heartbeat to echo test 2246435 Fixed health struct size. We should really get an automated test for this f458d67 Add uptime counter to the health packet (#391) 1662481 enable CAN transcievers outside the set_safety_mode function, which is not related a7c9874 bump panda ver 1192d93 Power saving refactor (#389) d58d08f Fix Misra 17.8: can't mod function params bc685ac Minor indent a54b86c Failure of set_safety_mode falls back to SILENT. Failure to set silent results in hanging 597436d NOOUTPUT safety mode is now SILENT. NOOUTPUT still exists but keeps C… (#388) d229f8d ESP forced off in EON build. this prevents ESP to be turned on when e… (#387) 8a044b3 forgot Hyundai: now also using make_msg 4f9c879 remove abunch of lines from safety regression tests by using common make_msg function fb81414 mispelled word 57f5ef8 Fix misra: addr can't be more than 29 bits anyway 68ff501 typo d5c772b Fixe Toyota message white-list 48197a9 Better masking for ELM mode b8fe78c VW is also tested for safety replay 212d336 Safety Chrysler: Added cancel spam button check d44b562 fix print in example 02d579a functional addr handling 6249a18 tx_hook shall have a white-list of messages (#381) 8138fc1 uds: handle function addrs and fw version query example 6626a54 Fixed python health api b9b79e8 uds zero second timeout e0de1a4 define ALLOW_DEBUG in safety tests 86dec4b Safety modes that violate ISO26262 requirements are not compiled in RELEASE build e74ed93 safety tests a bit more simplified 2027765 relay malfunction test centralized 8af1a01 clean up safety tests e8f7a3b upd panda cfcce8f WIP: Relay malfunction (#384) 69d9d61 No tabs in mazda safety a86418c insignificant changes f239b99 single addr was better d063a18 Hyundai safety: re-enable button spam safety check 4d1edc0 skip tx_hook if a message is forwarded (#379) df2ff04 bump version 168461d added fault state to health packet b3e1a13 uds: better debug prints 68c39fb uds: no need for threads if you always drain rx 91b7c5b bump Panda Ver 26cb4dc Fixed pylint error 32725cc Fixed misra compliance e33b4be Added echo script 312ba62 minor comment cleanupo e90897a Fix board detection on white 0e72c18 always stop executing if safety mode fails to be set (suggested by jyoung8607) e8d7ed1 Rename function name to not confuse safety_set_mode and set_safety_mode ff86db6 improve uds message processing 512ab3f except Exception 37ce507 py3 all bac4d85 dos and python3 501db8d uds drain before send and use has_obd() f2cbec1 Added has_obd() to python library 48e5b18 Add SDK downloading to the build step (#314) e0762c2 Add Python & USB API for controlling phone power (#313) ba9fb69 New health packet struct also in the python libs git-subtree-dir: panda git-subtree-split: a648cca
dragonpilot
pushed a commit
to dragonpilot-community/dragonpilot
that referenced
this pull request
Apr 7, 2020
* GM: copy cadillac's radar header DBC * Remove unused interface imports * Rename num targets message to radar header * Catch various radar faults
Vaggysag
pushed a commit
to Vaggysag/openpilot
that referenced
this pull request
Apr 21, 2020
…es (commaai#396) * Added an initial working implementation of the register readback and applied it to the LLCAN registers. Also fixed an init bug in CAN. * Locally disable pylint import error * Reverted change to CAN-obj->FA1R setting * Fixed misra compliance * Changed hash function name * Fixed CAN filter setting * Added voltage health test * Converted ADC to register functions * Converted clock to use register setters * Added check to see if fault status is zero after running test * Converted DAC to use register setters * Converted fan to use register setters * Converted gmlan bitbanging to use register setters * Changed over interrupt driver to use register setters. Also moved some includes and definition places for critical sections * Fixed build * Converted LLGPIO to use register setters * Converted pwm to use register setters * Fixed cold boot * Fixed health fault check in automated tests * Added comment for the future (issue commaai#367) * Converted RTC driver to use register setters * Converted SPI to use register setters * Converted timer driver to use register setters * Fixed register fault on white pandas and disabled showing of fault for release * Bump version
Vaggysag
pushed a commit
to Vaggysag/openpilot
that referenced
this pull request
Apr 21, 2020
…other ones (commaai#396)" This reverts commit 893e486.
Vaggysag
pushed a commit
to Vaggysag/openpilot
that referenced
this pull request
Apr 21, 2020
…ert the other ones (commaai#396)"" This reverts commit 56ec215.
dkiiv
pushed a commit
to dkiiv/openpilot
that referenced
this pull request
Aug 28, 2024
* deprecated * cruise main state * v cruise non pcm state * acc mads combo * cancel cruise state * sp common state * sp event * custom stock long * started mads * v cruise non pcm state old * acc mads old * started mads old
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GM radar is notorious for getting into some sort of miscalibrated state (a.k,a. "alignment fault"). Without handling the fault, openpilot thinks the path is clear while it should disengage.
Tested there are no false-positives on stop and go and highway driving, on 2017 Volt.
Driving for about half an hour with stock ASCM on highway speeds is known to fix that radar fault. I haven't looked into how ASCM does it or how openpilot can replicate the behavior.