fix(baseapp): preblock events are not emmitted correctly #21444
Conversation
WalkthroughWalkthroughThe recent changes involve modifications to the Changes
Sequence Diagram(s)sequenceDiagram
participant BaseApp
participant EventManager
participant Manager
BaseApp->>EventManager: Initialize with sdk.NewEventManager()
BaseApp->>Manager: Call preBlock
Manager->>BaseApp: Execute pre-block logic
BaseApp->>EventManager: Handle events during pre-block
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add Documentation and Community
|
facundomedica
added
the
backport/v0.50.x
|
@facundomedica your pull request is missing a changelog! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (2)
- baseapp/baseapp.go (1 hunks)
- types/module/module.go (1 hunks)
Additional context used
Path-based instructions (2)
types/module/module.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.baseapp/baseapp.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (2)
types/module/module.go (1)
Line range hint
713-722: Verify context's event manager.The
PreBlockfunction no longer initializes a new event manager. Ensure that the context already has an event manager or that this change is intentional and does not break event handling.Run the following script to verify the context's event manager initialization:
Verification successful
Context's Event Manager Initialization Verified
The context is being initialized with an event manager in other parts of the codebase, ensuring that the
PreBlockfunction operates with a context that already has an event manager. The removal of event manager initialization inPreBlockis intentional and should not disrupt event handling.
- Verified in
types/module/module.goandbaseapp/msg_service_router.go.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the context already has an event manager. # Test: Search for the context initialization. Expect: Context should have an event manager. rg --type go -A 5 $'ctx.WithEventManager'Length of output: 1295
baseapp/baseapp.go (1)
Line range hint
714-722: LGTM!The function now includes an event manager in the context, which likely improves event handling during block finalization.
The code changes are approved.
julienrbrt
added
the
backport/v0.52.x
julienrbrt
changed the title
|
Let's create a changelog in the v0.50 backport. |
(cherry picked from commit 58bbcd9)
(cherry picked from commit 58bbcd9) # Conflicts: # baseapp/baseapp.go # types/module/module.go
Description
Follow up to #21159
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
PreBlockmethod, which may influence event management during pre-block operations across modules.