forked from AlexsLemonade/OpenPBTA-analysis
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mtp tables qc checks to include expression tpm tables #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pm_mean_sd_quantile_group_wise_zscore.tsv.gz to current
ewafula
approved these changes
Dec 1, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What scientific question is your analysis addressing?
Update mtp tables qc checks to include expression tpm tables
What was your approach?
mutation-frequencies-table-checks
tomtp-tables-qc-checks
02-tpm-tables-checks.Rmd
. The script adapts logic and code from the script01-frequencies-tables-checks.Rmd
. The results include:a) number of samples in each cohort
b) cancer groups represented in multiple cohorts
c) a subset of sorted top 50 records from a static cancer group (
Neuroblastoma
) that should not changed) changes in common columns among both gene and group wise TPM tables with non-dynamic values.
run_frequencies-tables-checks.sh
to include running the new02-tpm-tables-checks.Rmd
What GitHub issue does your pull request address?
Issue#446
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Please review the results for the TPM tables :
long_n_tpm_mean_sd_quantile_gene_wise_zscore.xlsx
long_n_tpm_mean_sd_quantile_group_wise_zscore.xlsx
Also please closely review the code logic applied for finding the number samples in each cohort in lines 66 to 77 of the script
02-tpm-tables-checks.Rmd
. Please suggest any other improvement or suggestions for the code logic, organization and documentation as well.Is there anything that you want to discuss further?
No
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes
Results
What types of results are included (e.g., table, figure)?
Table
What is your summary of the results?
For both the gene and group wise TPM tables, we generate a QC check table in excel format in the results folder and the script report is generated as html file in the main repo of the module. For both the gene and group wise tables:
n_samples
for each gene is lower in V11.Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.