Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IHG subtyping #305

Merged
merged 19 commits into from
Feb 11, 2023
Merged

Update IHG subtyping #305

merged 19 commits into from
Feb 11, 2023

Conversation

zzgeng
Copy link

@zzgeng zzgeng commented Jan 12, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

Update molecular-subtyping-HGG module

What was your approach?

Add new subtype IHG, including
IHG, NTRK-altered
IHG, ROS1-altered
IHG, ALK-altered
IHG, MET-altered
IHG, To be classified

What GitHub issue does your pull request address?

d3b-center/ticket-tracker-OPC#474

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

07-HGG-molecular-subtyping-combine-table.Rmd
HGG_cleaned_all_table.tsv

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

Tables

What is your summary of the results?

Add IGH molecular subtype

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@jharenza jharenza changed the base branch from dev to update_MET_fusion January 13, 2023 20:41
Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zzgeng I will go through this today, but can you merge update_MET_fusion into this branch when you get a chance? That will allow these PRs to be staggered.

Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zzgeng - can you make the few requested changes and I will continue after that?

@jharenza jharenza self-requested a review January 31, 2023 02:29
Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zzgeng thank you so much for working on this and sorry for the delay in review. I left some comments for making code a bit more concise and a change to use the fusion summary file here.

I also suggested to put all methylation bs_ids in the final table as well.

For the final molecular_subtypes.tsv table, I see fusion evidence is NA for the IHG samples - can you add the fusions to this table?

Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few typos I noticed

@jharenza jharenza self-requested a review February 11, 2023 02:32
@jharenza jharenza changed the base branch from update_MET_fusion to dev February 11, 2023 02:35
Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to get this in to build into mol #315

@jharenza
Copy link
Member

going to merge since this has passed HGG subtyping

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants