Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v12 pre-release files (1/N) #321

Merged
merged 414 commits into from
Apr 30, 2023
Merged

Update v12 pre-release files (1/N) #321

merged 414 commits into from
Apr 30, 2023

Conversation

ewafula
Copy link

@ewafula ewafula commented Feb 19, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

Generate analysis pre-release files for v12

What was your approach?

updated analysis pre-release modules and generated analysis pre-release files using scripts/generated-analysis-files.sh bash script

What GitHub issue does your pull request address?

NA

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Review update module code and results

Is there anything that you want to discuss further?

None

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

YES

Results

What types of results are included (e.g., table, figure)?

results for the v12 pre-release modules

What is your summary of the results?

results for the v12 pre-release modules

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@jharenza jharenza changed the title Update v12 pre-release files Update v12 pre-release files (1/N) Feb 25, 2023
@jharenza jharenza self-requested a review February 28, 2023 00:00
@jharenza jharenza mentioned this pull request Mar 5, 2023
5 tasks
@ewafula
Copy link
Author

ewafula commented Apr 10, 2023

Updated analysis pre-release files for reharmonized RNAseq data regenerated and uploaded to s3 bucket v12 folder, including the latest efo-mondo-map.tsv in PR #350

@jharenza
Copy link
Member

All checks have passed, so this is ready to merge upon confirming data download is up to date and working properly cc @ewafula

@jharenza
Copy link
Member

🚀

@jharenza jharenza merged commit 36ab93b into dev Apr 30, 2023
@jharenza jharenza deleted the v12-analysis-files branch April 30, 2023 22:11
This was referenced May 1, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants