Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the output format in molecular-subtyping-HGG module #374

Merged
merged 12 commits into from
Dec 6, 2023
Merged

Conversation

zzgeng
Copy link

@zzgeng zzgeng commented Jun 5, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

Change the format of HGG molecular subtype table.

What was your approach?

In the previous version, the molecular subtype table contains three columns for Biospecimen ID, Kids_First_Biospecimen_ID_RNA, Kids_First_Biospecimen_ID_DNA, and Kids_First_Biospecimen_ID_Methyl. In this version, the molecular subtype table only contain one column Kids_First_Biospecimen_ID.

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

07-HGG-molecular-subtyping-combine-table.Rmd
results/HGG_molecular_subtype_tp53.tsv
results/HGG_molecular_subtype.tsv

Is there anything that you want to discuss further?

No

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

Table

What is your summary of the results?

Change the format of HGG molecular subtype table.

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@zzgeng zzgeng requested a review from a team as a code owner November 29, 2023 20:58
@jharenza
Copy link
Member

looks like you are getting an error here:

                           
Quitting from lines 25-39 (10-HGG-TP53-annotation.Rmd) 
Error in `$<-`:
! Assigned data
  `as.character(hgg_subtypes$Kids_First_Biospecimen_ID_RNA)` must be compatible
  with existing data.
✖ Existing data has 1050 rows.
✖ Assigned data has 0 rows.
ℹ Only vectors of size 1 are recycled.
Caused by error in `vectbl_recycle_rhs_rows()`:
! Can't recycle input of size 0 to size 1050.
Backtrace:
 1. base::`$<-`(`*tmp*`, Kids_First_Biospecimen_ID_RNA, value = `<chr>`)
 2. tibble:::`$<-.tbl_df`(...)
 3. tibble:::tbl_subassign(...)
 4. tibble:::vectbl_recycle_rhs_rows(value, fast_nrow(xo), i_arg = NULL, value_arg, call)
  |...................................                 |  67% (unnamed-chunk-2)

@jharenza
Copy link
Member

jharenza commented Dec 1, 2023

@zzgeng this will need another rerun since #450 was merged

@jharenza jharenza requested a review from rjcorb December 4, 2023 02:00
@jharenza
Copy link
Member

jharenza commented Dec 4, 2023

@zzgeng can you fix merge conflicts here please? Then @rjcorb can you review? Thanks!

Copy link

@rjcorb rjcorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jharenza jharenza merged commit 2685571 into dev Dec 6, 2023
22 checks passed
@jharenza jharenza deleted the hgg_output branch December 6, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants