Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PXA to molecular subtype #450

Merged
merged 5 commits into from
Dec 1, 2023
Merged

add PXA to molecular subtype #450

merged 5 commits into from
Dec 1, 2023

Conversation

zzgeng
Copy link

@zzgeng zzgeng commented Oct 19, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

Add pleomorphic xanthoastrocytoma (PXA) to HGG molecular subtyping module

What was your approach?

Based on WHO guidebook, samples with

  • BRAF mutation and
  • homozygous deletion of CDKN2A and/or CDKN2B and
  • methylation profile as PXA
    as "PXA"

What GitHub issue does your pull request address?

#443

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

03, 07 R script and output results.

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

Table

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@zzgeng zzgeng requested a review from a team as a code owner October 19, 2023 18:48
Copy link

@rjcorb rjcorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added code for PXA subtyping aligns with the overall workflow for HGG subtyping, so I am approving. My only comment is this code create a PXA subtype data frame to be added to final subtyping df, despite there not currently being any samples subtyped as PXA. But for oligodendroglioma, there is just a check for any samples with this subtype, and since there are currently zero there is no code to create a df and add to final subtyped df. It may be worth using the same strategy for oligo as is done for PXA: no samples currently, but will be added to final output in the future if any oligo samples are added to future cohort.

@jharenza
Copy link
Member

@zzgeng can you fix conflicts here/merge dev/rerun

@jharenza jharenza merged commit 54627b0 into dev Dec 1, 2023
22 checks passed
@jharenza jharenza deleted the zzgeng/Add_PXA branch December 1, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants